[Bug 31271] New: "Edit search" always resets search options to keyword
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Bug ID: 31271 Summary: "Edit search" always resets search options to keyword Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, nick@bywatersolutions.com To test: - Go to the advanced search in the staff interface - Select Barcode as search option and search for a non-existing barcode - From the search results, go back by Edit search link - Verify the search option flipped back to Keyword :( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Is it a regression? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #1)
Is it a regression?
Hum, guess no. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #3 from Donna <bwsdonna@gmail.com> --- I would argue it is a regression - in previous versions, when I click back to the advanced search to edit the search, the search options are retained. The edit search button should do the same thing. I can click the back arrow and the fields are retained, so having the behavior differ between using the "proper" edit link vs back arrow is rather frustrating. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22605 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I also felt like I had tested this when the edit link was added... Adding Nick. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 [Bug 22605] Adding the option to modify/edit searches on the staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143086&action=edit Bug 31271: Preselect previous search index This patch passes the constructed value of the preselect to search_indexes.inc To test: 1 - Perform an advanced search, making sure to select different indexes 2 - Click 'Edit search' on results page 3 - Confirm index selections are preselected 4 - Enable IntranetCatalogSearchPulldown 5 - Do a search form the top bar using an index 6 - Confirm 'Edit search' correctly popluates the chosen index -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143086|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 143139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143139&action=edit Bug 31271: Preselect previous search index This patch passes the constructed value of the preselect to search_indexes.inc To test: 1 - Perform an advanced search, making sure to select different indexes 2 - Click 'Edit search' on results page 3 - Confirm index selections are preselected 4 - Enable IntranetCatalogSearchPulldown 5 - Do a search form the top bar using an index 6 - Confirm 'Edit search' correctly popluates the chosen index Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32100 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32100 [Bug 32100] "edit search" feature quote-wraps search terms if original search had no results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143139|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143496&action=edit Bug 31271: Preselect previous search index This patch passes the constructed value of the preselect to search_indexes.inc To test: 1 - Perform an advanced search, making sure to select different indexes 2 - Click 'Edit search' on results page 3 - Confirm index selections are preselected 4 - Enable IntranetCatalogSearchPulldown 5 - Do a search form the top bar using an index 6 - Confirm 'Edit search' correctly popluates the chosen index Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32100 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32100 [Bug 32100] "edit search" feature quote-wraps search terms if original search had no results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Bug 31271 depends on bug 22605, which changed state. Bug 22605 Summary: Adding the option to modify/edit searches on the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org