https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 16856 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51238|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 53491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53491&action=edit Bug 16449: Remove "no method selected" warning from unimarc_field_4XX Because of bug 14828, the unimarc_field_4XX now raises a warning: "No method selected!" There are no need to select an item type on this page, the default (all) is always selected. Test plan: Link the unimarc_field_4XX value builder with on of the subfield Edit a record, click on the value builder icon Note the warning without the patch and that it's gone with the patch applied NOTE: Code fix that I derived was identical. Ran prove t/db_dependent/FrameworkPlugin.t to confirm it works. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53491|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 55109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55109&action=edit Bug 16449: Remove "no method selected" warning from unimarc_field_4XX Because of bug 14828, the unimarc_field_4XX now raises a warning: "No method selected!" There are no need to select an item type on this page, the default (all) is always selected. Test plan: Link the unimarc_field_4XX value builder with on of the subfield Edit a record, click on the value builder icon Note the warning without the patch and that it's gone with the patch applied NOTE: Code fix that I derived was identical. Ran prove t/db_dependent/FrameworkPlugin.t to confirm it works. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449 Bug 16449 depends on bug 14828, which changed state. Bug 14828 Summary: Move the item types related code to Koha::ItemTypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.