[Bug 12929] New: bug 12716 introduces a regression on the patron import tools
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Bug ID: 12929 Summary: bug 12716 introduces a regression on the patron import tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 12716 removes too many lines. See bug 12859 for the history. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12716, 12859 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31637&action=edit Bug 12929: Restore behavior before bug 12716 This patch remove borrowernumber from the borrower list fields and display the field list in the notes. Test plan: - verify that the list of fields is displayed on the right (Notes). - verify the borrowernumber is not displayed anymore in the field list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31637|0 |1 is obsolete| | --- Comment #2 from Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> --- Created attachment 31969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31969&action=edit Bug 12929: Restore behavior before bug 12716 This patch remove borrowernumber from the borrower list fields and display the field list in the notes. Test plan: - verify that the list of fields is displayed on the right (Notes). - verify the borrowernumber is not displayed anymore in the field list. Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com> Confirmed that this patch removes borrowernumber from list of default values, and reintroduces missing list of CSV columns in the Notes field. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, the patch applies correctly here. Switch the status back to SO. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32129&action=edit Bug 12929 [QA Followup] - Hide borrownumber from sample csv file -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31969|Bug 12929: Restore behavior |[SIGNED-OFF] Bug 12929: description|before bug 12716 |Restore behavior before bug | |12716 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32129|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 32143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32143&action=edit Bug 12929 [QA Followup] - Hide borrownumber from sample csv file Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31969|0 |1 is obsolete| | Attachment #32143|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32279&action=edit [PASSED QA] Bug 12929: Restore behavior before bug 12716 This patch remove borrowernumber from the borrower list fields and display the field list in the notes. Test plan: - verify that the list of fields is displayed on the right (Notes). - verify the borrowernumber is not displayed anymore in the field list. Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com> Confirmed that this patch removes borrowernumber from list of default values, and reintroduces missing list of CSV columns in the Notes field. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32280&action=edit [PASSED QA] Bug 12929 [QA Followup] - Hide borrownumber from sample csv file Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, hides the borrowernumber from the list of fields to edit and also brings back the list of fields for the sample file in the documentation. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan and Kyle. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32335&action=edit Bug 12929 [QA Followup] - Hide borrownumber from sample csv file Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, hides the borrowernumber from the list of fields to edit and also brings back the list of fields for the sample file in the documentation. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org