https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55175&action=edit Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib The subroutine C4::Koha::GetKohaAuthorisedValueLib just retrieves a description (lib) for a given authorised value. We can easily replace it using: Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av })->lib or Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av })->opac_description Test plan: - On the detail page of a bibliographic record, the description for notforloan, restricted and stack (?) should be correctly displayed - View a shelf, the location (LOC) description should be displayed - On the search result page, the location description should be displayed in the facets - Set AcqCreateItem=ordering and receiving items. The description for notforloan, restricted, location, ccode, etc. field should be displayed. - When creating item in the acquisition module, the dropdown list for field linked to AV should display the AV' descriptions - On the transfers page, the description of the location should be displayed. - On the checkout list from the circulation.pl and returns.pl pages, the description for "materials" should be displayed - Fill some OPAC_SUG AV and create a suggestion, the reason dropdown list should display the description of OPAC_SUG -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55175|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55183&action=edit Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib The subroutine C4::Koha::GetKohaAuthorisedValueLib just retrieves a description (lib) for a given authorised value. We can easily replace it using: Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av })->lib or Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av })->opac_description Test plan: - On the detail page of a bibliographic record, the description for notforloan, restricted and stack (?) should be correctly displayed - View a shelf, the location (LOC) description should be displayed - On the search result page, the location description should be displayed in the facets - Set AcqCreateItem=ordering and receiving items. The description for notforloan, restricted, location, ccode, etc. field should be displayed. - When creating item in the acquisition module, the dropdown list for field linked to AV should display the AV' descriptions - On the transfers page, the description of the location should be displayed. - On the checkout list from the circulation.pl and returns.pl pages, the description for "materials" should be displayed - Fill some OPAC_SUG AV and create a suggestion, the reason dropdown list should display the description of OPAC_SUG -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Claire Gravely from comment #3)

could not apply bug 17216 (depends on) CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt Failed to merge in the changes.

Rebased. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55183|0 |1 is obsolete| | --- Comment #5 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 55267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55267&action=edit Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib The subroutine C4::Koha::GetKohaAuthorisedValueLib just retrieves a description (lib) for a given authorised value. We can easily replace it using: Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av })->lib or Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av })->opac_description Test plan: - On the detail page of a bibliographic record, the description for notforloan, restricted and stack (?) should be correctly displayed - View a shelf, the location (LOC) description should be displayed - On the search result page, the location description should be displayed in the facets - Set AcqCreateItem=ordering and receiving items. The description for notforloan, restricted, location, ccode, etc. field should be displayed. - When creating item in the acquisition module, the dropdown list for field linked to AV should display the AV' descriptions - On the transfers page, the description of the location should be displayed. - On the checkout list from the circulation.pl and returns.pl pages, the description for "materials" should be displayed - Fill some OPAC_SUG AV and create a suggestion, the reason dropdown list should display the description of OPAC_SUG Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- just a rebase. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55377|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 56267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56267&action=edit [PASSED QA] Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib The subroutine C4::Koha::GetKohaAuthorisedValueLib just retrieves a description (lib) for a given authorised value. We can easily replace it using: Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av })->lib or Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av })->opac_description Test plan: - On the detail page of a bibliographic record, the description for notforloan, restricted and stack (?) should be correctly displayed - View a shelf, the location (LOC) description should be displayed - On the search result page, the location description should be displayed in the facets - Set AcqCreateItem=ordering and receiving items. The description for notforloan, restricted, location, ccode, etc. field should be displayed. - When creating item in the acquisition module, the dropdown list for field linked to AV should display the AV' descriptions - On the transfers page, the description of the location should be displayed. - On the checkout list from the circulation.pl and returns.pl pages, the description for "materials" should be displayed - Fill some OPAC_SUG AV and create a suggestion, the reason dropdown list should display the description of OPAC_SUG Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23912 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23912 [Bug 23912] Get correct authorised values for location and collections facets -- You are receiving this mail because: You are watching all bug changes.