[Bug 38667] New: Point of sale transaction history should not appear to be sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38667 Bug ID: 38667 Summary: Point of sale transaction history should not appear to be sortable Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Point of Sale Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@ptfs-europe.com The configurations of the Transactions to date and Older transactions tables contain "orderFixed: [ 0, 'asc']" which sets a fixed order on the hidden first column. We should add "ordering: false" so that column sorting controls don't appear in the table headers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38667 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38667 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175363&action=edit Bug 38667: Point of sale transaction history should not appear to be sortable This patch adds configuration options to the Point of sale "Transactions to date" and "Older transactions" tables so that they don't appear to be sortable. Both have an option that makes their sorting fixed. To test, apply the patch and go to Point of Sale. - Enable 'EnablePointOfSale' and 'UseCashRegisters' system preferences. - Add a least one cash register (Administration -> Cash registers). - Add a least one debit type (Administration -> Debit types). Check "Can be sold." - Go to the Point of Sale page. - Under "Items for purchase" click "Add" next to an item. - Under "Collect payment," fill out the form, including the cash register selection, and submit. - Click "Transaction history for..." in the sidebar menu. (You may have to click "Cash summary for..." and then the name of the register you used in your transaction. - Check that the "Transactions to date" and "Older transactions" tables do not have sorting indicators in the table headers. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38667 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38667 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175363|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 175944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175944&action=edit Bug 38667: Point of sale transaction history should not appear to be sortable This patch adds configuration options to the Point of sale "Transactions to date" and "Older transactions" tables so that they don't appear to be sortable. Both have an option that makes their sorting fixed. To test, apply the patch and go to Point of Sale. - Enable 'EnablePointOfSale' and 'UseCashRegisters' system preferences. - Add a least one cash register (Administration -> Cash registers). - Add a least one debit type (Administration -> Debit types). Check "Can be sold." - Go to the Point of Sale page. - Under "Items for purchase" click "Add" next to an item. - Under "Collect payment," fill out the form, including the cash register selection, and submit. - Click "Transaction history for..." in the sidebar menu. (You may have to click "Cash summary for..." and then the name of the register you used in your transaction. - Check that the "Transactions to date" and "Older transactions" tables do not have sorting indicators in the table headers. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38667 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This removes the column release notes| |sorting icons from the | |point of sale "Transactions | |to date" and "Older | |transactions" tables. The | |sort order for these tables | |is fixed, and clicking the | |icons had no effect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38667 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA by RM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38667 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38667 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38667 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38667 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38667 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 24.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38667 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x (or 23.XX) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org