[Bug 20652] New: Sort After Item Type Search Fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Bug ID: 20652 Summary: Sort After Item Type Search Fails Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: jyorio@esilibrary.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Steps to reproduce: Advanced Search Choose an Item type (do not enter any other search limits) Search Click on Sort (it doesn't appear to matter what you sort on) The results don't sort. I did notice that the URL changes and a string of %20s follows the sort_by= For example: sort_by=title_az%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20&limit=mc-itype,phr:62 If I cut the %20s out of the URL and load it, then the sorted results appear. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|17.11 |master CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Depends on| |19461 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Certainly caused by commit 7d2cb42dceeeb004ab7447fd6beccab5fac37e23 Bug 19461: Add floating toolbar to staff client catalog search results Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19461 [Bug 19461] Add floating toolbar to staff client catalog search results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 74822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74822&action=edit Bug 20652: Fix result sorting after search on limit only 1 chomp was missing, spaces were replaced with %20 This patch adds extra chomps, but it does not hurt Test plan: Advanced Search Choose an Item type (do not enter any other search limits) Search Click on Sort (it doesn't appear to matter what you sort on) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74822|0 |1 is obsolete| | --- Comment #3 from Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> --- Created attachment 75571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75571&action=edit Bug 20652: Fix result sorting after search on limit only 1 chomp was missing, spaces were replaced with %20 This patch adds extra chomps, but it does not hurt Test plan: Advanced Search Choose an Item type (do not enter any other search limits) Search Click on Sort (it doesn't appear to matter what you sort on) Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-luc.lapointe@inLibro | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75571|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 75581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75581&action=edit Bug 20652: Fix result sorting after search on limit only 1 chomp was missing, spaces were replaced with %20 This patch adds extra chomps, but it does not hurt Test plan: Advanced Search Choose an Item type (do not enter any other search limits) Search Click on Sort (it doesn't appear to matter what you sort on) Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sort After Item Type Search |Sort after item type search |Fails |fails CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to master for 18.11. Awesome work all, thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This patch has been pushed to 18.05.x, will be in 18.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Bug 20652 depends on bug 19461, which changed state. Bug 19461 Summary: Add floating toolbar to staff client catalog search results https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20652 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Bug 19461 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org