https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95187&action=edit Bug 23994: Fix random failure from AdditionalFields.t (U18) t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t .. 1/12 # Failed test '->additional_field_values should return the correct values' # at t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t line 82. # Structures begin differing at: # $got->[0]{value} = 'bar value for basket2' # $expected->[0]{value} = 'foo value for basket2' # Looks like you failed 1 test of 12. We do not really know why, but the values are not returned in the order they are stored in DB. Fixing this random failure for now at test level. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- As discussed on IRC, this works and gets the tests passing again... no idea why it returns differently on U18 but the order is unimportant in the context anyway. Passing QA and Pushing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- I cannot make this fail in 19.05.x, do we need it in that version? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Lucas Gass from comment #3)

I cannot make this fail in 19.05.x, do we need it in that version?

I have this failing locally often (whereas it seems ok in the CI), it must depend a lot of the machine. So need in 19.05.x is confirmed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.