[Bug 43960] New: Round account line amounts at write time per income rounding preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43960 Bug ID: 43960 Summary: Round account line amounts at write time per income rounding preferences Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Depends on: 43957 Blocks: 23728 Target Milestone: --- Round account line amounts at write time according to the income rounding preferences. Part of the currency rounding work collected on bug 23728. accountlines.amount is decimal(28,6), and nothing stops fractions of a penny being stored (Koha::Account::add_debit, REST API, POS sales). Proposed: a single hook in Koha::Account::Line->store that rounds amount and amountoutstanding to the currency decimal_digits using IncomeRoundingMode, when IncomeRoundingTiming is not none. Fines raised by the overdue rules are handled in the fines bug. Tests: debits and credits created through add_debit, add_credit and REST are stored at currency precision. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23728 [Bug 23728] Rounding code should be moved to a Koha module so code can be centralised https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43957 [Bug 43957] Add per-currency decimal digits and configurable rounding policy preferences -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43960 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43961 Blocks| |43963 Blocks| |43964 Blocks|23728 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23728 [Bug 23728] [OMNIBUS] Currency precision and rounding: central engine, per-currency digits, configurable policy https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43961 [Bug 43961] POS accepts prices and quantities that produce fractions of a penny https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43963 [Bug 43963] Round fines when charged and retire the RoundFinesAtPayment tolerance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43964 [Bug 43964] Maintenance script to find and optionally fix account lines with excess decimal places -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43960 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43960 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 210151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210151&action=edit Bug 43960: Round account line amounts at write time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43960 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43960 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #210151|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43960 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 210179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210179&action=edit Bug 43960: Round account line amounts at write time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43960 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|43963 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43963 [Bug 43963] Round fines when charged and retire the RoundFinesAtPayment tolerance -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org