[Bug 12098] New: User can edit some subcriptions he should be prevented to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 Bug ID: 12098 Summary: User can edit some subcriptions he should be prevented to Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: frederic@tamil.fr QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com If the user doesn't have the superserials permission, or isn't superlibrarian, you can still edit a subscription accessing the subscription detail page through the serial collection page (for records with multiple subscriptions) or accessing the detail page directly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12080 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m, | |katrin.fischer@bsz-bw.de, | |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Perhaps we should move JD's patches from bug 12080 here? I don't like the thought that his patches are hidden by being obsoleted on another bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- (In reply to M. Tompsett from comment #1)
Perhaps we should move JD's patches from bug 12080 here? I don't like the thought that his patches are hidden by being obsoleted on another bug.
Jonathan have them on his repo, and he will re-post them here. That's my understanding. If you prefer, or would like to test them now, I can attach his patches here as they are. Just tell. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Jonathan said he would be gone for a week - so reattaching the patches here would be nice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 27242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27242&action=edit Refactor can_*_subscription in C4::Serials -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 27243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27243&action=edit Fix C4::Serials::can_edit_subscription -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27242|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27280&action=edit Bug 12080: Fix C4::Serials::can_edit_subscription This patch adds some unit tests for the can_edit_subscription and add a new can_show_subscription subroutines. http://bugs.koha-community.org/show_bug.cgi?id=12098 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27243|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27281&action=edit Bug 12080: Refactor can_*_subscription in C4::Serials http://bugs.koha-community.org/show_bug.cgi?id=12098 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- After applying all the patches for 12048 - 12080 - 12098 t/db_dependent/Bookseller.t fails for me. I can imagine the test might be wrong now or needs to be rewritten a bit. I will continue testing for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27280|0 |1 is obsolete| | Attachment #27281|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27290&action=edit [PASSED QA] Bug 12098: Fix C4::Serials::can_edit_subscription This patch adds some unit tests for the can_edit_subscription and add a new can_show_subscription subroutines. http://bugs.koha-community.org/show_bug.cgi?id=12098 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Notes on second patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27291&action=edit [PASSED QA] Bug 12098: Refactor can_*_subscription in C4::Serials http://bugs.koha-community.org/show_bug.cgi?id=12098 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested on top of patches for 12048 and 12080. Subscription search - superlibrarian, IndyBranches on/off - always sees all subscriptions - superserials, IndyBranches on/off - always sees all subscriptions - no superserials, IndyBranches on - only sees own subscriptions Note: Subscriptions without branches will only show, when all subscriptions are visible. In a future enh it might be good to enforce setting a branch, when IndyBranches is used. - no superserials, IndyBranches off - always sees all subscriptions Subscription editing - superlibrarian, IndyBranches on/off - can edit all subscriptions - superserials, IndyBranches on/off - can edit all subscriptions - no superserials, IndyBranches on - can only edit own subscriptons and subscriptions without branch NOTE: it would make sense to also allow Edit > Edit as new (duplicate) here, so one can copy the subscription from another branch to modify it for the own branch. Passes tests in t, xt and QA script, also newly provided unit tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with an important follow-up that puts the C4::Serials::can_show_subscription routine into use (as otherwise, it would be a routine that had zero actual affect). BUT NOTE: Note that there is user-visible change: if a subscription has a blank library, all users with serials permissions will be able to view and/or edit it. It remains to be determined whether we *want* such subscriptions to exist, or if they should only be tied to specific libraries. If this change in behavior isn't desirable, please open a new bug. Thanks, Jonathan! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #12 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org