[Bug 9343] New: SIP doesn't handle debarred date/status correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9343 Bug ID: 9343 Summary: SIP doesn't handle debarred date/status correctly Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: SIP2 Assignee: adrien.saurat@biblibre.com Reporter: adrien.saurat@biblibre.com CC: colin.campbell@ptfs-europe.com The SIP engine didn't evolve when the debarred status switched from a boolean to a date. This needs to be fixed in C4/SIP/ILS/Patron.pm, where the $debarred variable, which should be filled as a boolean, gets the date instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9343 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 14397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14397&action=edit proposed patch Just after the modified line, a warn raised by $debug can show the changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9343 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9343 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14397|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14711&action=edit Bug 9343: handles the new format of Debarred The debarred status in DB switched from a boolean to a date. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9343 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9343 --- Comment #3 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 14718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14718&action=edit Bug 9343: handles the new format of Debarred The debarred status in DB switched from a boolean to a date. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Elliott Davis <elliott@bywatersolions.com> Correctly pulls debared flag instead of debarment date. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9343 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14711|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9343 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |elliott@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9343 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9343 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Does not apply to 3.10.x please rebase if you will it to be that branch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9343 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14718|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15000&action=edit Bug 9343: handles the new format of Debarred [3.10.x] The debarred status in DB switched from a boolean to a date. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Elliott Davis <elliott@bywatersolions.com> Correctly pulls debared flag instead of debarment date. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9343 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.3 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org