[Bug 41456] New: Item type filter on the hold history view does not work correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Bug ID: 41456 Summary: Item type filter on the hold history view does not work correctly Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Depends on: 41451 We should be able to search using the item type's code or description. We also need to have the item types listed in a dropdown list. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41451 [Bug 41451] Hold history search fails when itemtype column present -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41457 [Bug 41457] Hold history table does not deal with column visibility correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190537&action=edit Bug 41456: Fix item type searching and filtering on the holds history table Use should use coded_values for the library and item type column so that we can search using the code and the description. With this patch we now have a dropdown list with the libraries and item types in the table's headers. Test plan: 0. Turn on AllowHoldItemTypeSelection 1. Create a hold and select an item type Note: I think there is a bug if you select it from "Hold next available item", use "Hold details". Please confirm? 2. Go to the holds history view 3. Filter and search by item type description and code. Same for library. Use the dropdown list in the headers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190537|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 190553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190553&action=edit Bug 41456: Fix item type searching and filtering on the holds history table Use should use coded_values for the library and item type column so that we can search using the code and the description. With this patch we now have a dropdown list with the libraries and item types in the table's headers. Test plan: 0. Turn on AllowHoldItemTypeSelection 1. Create a hold and select an item type Note: I think there is a bug if you select it from "Hold next available item", use "Hold details". Please confirm? 2. Go to the holds history view 3. Filter and search by item type description and code. Same for library. Use the dropdown list in the headers. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- For step 1, if I select "Request specific item type" (Books): - from under the "Hold next available item" section, it shows in the patron's holds history as "Any item type" (doesn't matter what I select here) - from under "Hold details" section, it shows in the patron's holds history as "Book" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the patron's release notes| |holds history table in the | |staff interface. The search | |filter now works as | |expected - using the | |library name or library | |code and requested item | |type name or item type code | |(when | |AllowHoldItemTypeSelection | |is enabled) now work as | |expected, and the column | |filters for both of these | |now use dropdown lists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190553|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190702&action=edit Bug 41456: Fix item type searching and filtering on the holds history table Use should use coded_values for the library and item type column so that we can search using the code and the description. With this patch we now have a dropdown list with the libraries and item types in the table's headers. Test plan: 0. Turn on AllowHoldItemTypeSelection 1. Create a hold and select an item type Note: I think there is a bug if you select it from "Hold next available item", use "Hold details". Please confirm? 2. Go to the holds history view 3. Filter and search by item type description and code. Same for library. Use the dropdown list in the headers. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This seems to have broken Cypress tests: cypress run --spec /kohadevbox/koha/t/cypress/integration/KohaTable/PendingHolds_spec.ts Error: Properties not allowed: item_type_id. at /kohadevbox/koha/t/cypress/plugins/dist/api-client.cjs.js:303:55 at processTicksAndRejections (node:internal/process/task_queues:95:5) 1) "before each" hook for "Should render library filters" 2) "after each" hook for "Should render library filters" 0 passing (3s) 2 failing Can you have a look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Also causing t/db_dependent/api/v1/holds.t to fail, I believe. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- This might be a problem... I remembered I thought about that when I wrote the original patch but then forgot to add a warning about it: we are modifying the REST API spec, and what the route accepts/returns. I would like Tomas and/or Martin's thinking on this one. We may want to revert the first patch, but IMO the change is correct (item_type => item_type_id), and acceptable if we only push it to 26.05.00 and don't backport it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190894&action=edit Bug 41456: Rename more item_type => item_type_id in hold's api spec Patch from commit b475de2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190894|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190919&action=edit Bug 41456: Rename more item_type => item_type_id in hold's api spec Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- As discussed on Mattermost, I believe the follow-up is the right approach here and I've tested it and confirmed it's good (PQA) I think we should also look at the codebase for other instances of this being inconsistent and fix those in follow-up bugs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41530 [Bug 41530] item_type vs item_type_id inconsistencies in the API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I think this might now be causing t/cypress/integration/t/insertData.ts to fail. I'm not 100% certain but it's my best guess right now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 191418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191418&action=edit Bug 41456: (follow-up) Change item_type to item_type_id and add _strings in test data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 --- Comment #16 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41456 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #17 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This patch doesn’t apply cleanly to 25.05, so I’m not planning to backport it at this time. If you’re able to update it for 25.05 compatibility, I’d be happy to take another look. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org