[Bug 41285] New: ERM: Agreements are missing space before and after options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41285 Bug ID: 41285 Summary: ERM: Agreements are missing space before and after options Initiative type: --- Sponsorship --- status: Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Created attachment 189894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189894&action=edit screenshot of table with agreement When looking at the list of agrements, there is a filter on top of the table. This filter section is missing some whitespace around and before options, as shown in the screenshot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41285 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41285 --- Comment #1 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- Created attachment 201404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201404&action=edit Bug 41285: added margin to flatpicker css -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41285 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |sam.sowanick@corvallisorego | |n.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41285 --- Comment #2 from Samuel Sowanick <sam.sowanick@corvallisoregon.gov> --- To test: 1. go to ERM > Agreements. 2. Notice the spacing. 3. Apply patch. 4. Go back to ERM > Agreements. 5. Notice now with updated spacing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41285 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201404|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41285 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 201500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201500&action=edit Bug 41285: Add spacing around ERM agreements filter options WWhen viewing the list of ERM agrements, there is whitespace missing around the filter options before the table list the agreements. Test plan: 1. Enable the ERM system preference: set ERMModule to "Enable". 2. Go to ERM > Agreements. 3. Create an agreement. 4. Note that there is whitespace missing around some options: - after "...on:" - before "Show mine only..." 5. Apply the patch. 6. Rebuild everything: yarn build 7. Restart everything: restart_all 8. Clear the browser cache and access the agreements page again. 9. Note that there is now whitespace around the filter options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41285 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA Patch complexity|--- |Small patch Component|Templates |ERM Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com CC| |david@davidnind.com, | |jonathan.druart@gmail.com, | |jonathan.field@openfifth.co | |.uk, | |martin.renvoize@openfifth.c | |o.uk, | |matt.blenkinsop@openfifth.c | |o.uk, | |pedro.amorim@openfifth.co.u | |k --- Comment #4 from David Nind <david@davidnind.com> --- Thanks for the patch Samuel! I have Failed QA, as this change also affects other date pickers in the ERM module (presumably it also affects other date pickers for other Vue-based modules) - it causes misalignment of the date fields in other forms, for example: 1. Agreements > New agreement > Periods > Add new period (Start date, End date, and Cancellation deadline) 2. Licenses > New license (Start date, End date) I'm not a developer, so it would be best to ask on the Development channel in the Koha Mattermost Chat on the best way to fix this. Notes: 1. I have updated the commit message (added the test plan and added a description - see the commit message guidelines at https://wiki.koha-community.org/wiki/Commit_messages ) 2. Changed the assignee for the bug to you. 3. Changed the component to ERM. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41285 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |sam.sowanick@corvallisorego | |n.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41285 Samuel Sowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201500|0 |1 is obsolete| | --- Comment #5 from Samuel Sowanick <sam.sowanick@corvallisoregon.gov> --- Created attachment 201775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201775&action=edit Bug 41285: Add spacing around ERM agreements filter options When viewing the list of ERM agrements, there is whitespace missing around the filter options before the table list the agreements. Test plan: 1. Enable the ERM system preference: set ERMModule to "Enable". 2. Go to ERM > Agreements. 3. Create an agreement. 4. Note that there is whitespace missing around some options: - after "...on:" - before "Show mine only..." 5. Apply the patch. 6. Rebuild everything: yarn build 7. Restart everything: restart_all 8. Clear the browser cache and access the agreements page again. 9. Note that there is now whitespace around the filter options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41285 Samuel Sowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201775|0 |1 is obsolete| | --- Comment #6 from Samuel Sowanick <sam.sowanick@corvallisoregon.gov> --- Created attachment 201776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201776&action=edit Bug 41285: Add spacing around ERM agreements filter options - Updated Patch Notes -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org