[Bug 24347] New: Add a 'search to order' option similar to 'search to hold'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Bug ID: 24347 Summary: Add a 'search to order' option similar to 'search to hold' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org On bug 11149 it was noted that the search options when reordering an existing record are limited. Instead of relying on ccl queries or rebuilding search features in the acq module, it could be nice to have a "search to order" feature. This could work similar to the "search to hold" functionality. Only you would not start from a patron record, but from your basket. Searching in the catalog you would see an "Add to order" link that would redirect you to the order page of your basket with the record already linked to the order. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- If anyone is interested in this feature I recommend helping test Bug 23944, "Phase out use of jquery.cookie.js in favor of js.cookie.js" which I would view as a dependency. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96838&action=edit Bug 24347: Add a 'search to order' option similar to 'search to hold' This patch modifes the process of searching for an existing record to add to a basket. Now the search is performed as a keyword search in the regular catalog rather than via a custom search script. Options are added to the search results and detail pages to add results to an order. This process follows the same pattern as the "Search to hold" feature: When the search is initiated, a cookie is set with the requisite information--in this case vendor id and basket number. If the search results or bibliographic detail pages detect that a "searchToOrder" cookie is present, the correct "Add order" link will be shown. Like with the "search to hold" feature, the cookie expires in 10 minutes. To test, apply the patch and log into the staff client as a user who has permission to add to a basket in acquisitions. - Go to Acquisitions -> Vendor -> Basket -> Add to basket. - Using the "From an existing record" option, perform a search. - On the search results page, test the "Add order" link which appears with each result. Clicking the link should take you to the "New order" page for the correct vendor and basket. The catalog details section of the form should include the correct information. - From the search results page view the bibliographic details page for any record. There should be a new toolbar button, "Add order." Verify that it works correctly. - Test the same thing from all bibliographic detail pages: Normal, MARC, Labeled MARC, ISBD, as well as the items page (moredetail.pl). - Test this process for both the locations in acquisitions where one can add to an existing basket: Vendor search results and the basket detail page - Test the cookie timeout: Wait 10 minutes and perform another catalog search. The "Add order" link should no longer be present. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96839&action=edit Bug 24347: (follow-up) Remove custom catalog search from acquisitions This patch removes the "neworderbiblio" script and template which are made obsolete by the "search to order" feature. deleted: acqui/neworderbiblio.pl deleted: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderbiblio.tt Some documentation in addorder.pl has been corrected to remove reference to neworderbiblio.pl. To test, apply the patch and verify that the correct files have been removed. Search the Koha codebase to verify that no links to acqui/neworderbiblio.pl remain. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96838|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 97948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97948&action=edit Bug 24347: Add a 'search to order' option similar to 'search to hold' This patch modifes the process of searching for an existing record to add to a basket. Now the search is performed as a keyword search in the regular catalog rather than via a custom search script. Options are added to the search results and detail pages to add results to an order. This process follows the same pattern as the "Search to hold" feature: When the search is initiated, a cookie is set with the requisite information--in this case vendor id and basket number. If the search results or bibliographic detail pages detect that a "searchToOrder" cookie is present, the correct "Add order" link will be shown. Like with the "search to hold" feature, the cookie expires in 10 minutes. To test, apply the patch and log into the staff client as a user who has permission to add to a basket in acquisitions. - Go to Acquisitions -> Vendor -> Basket -> Add to basket. - Using the "From an existing record" option, perform a search. - On the search results page, test the "Add order" link which appears with each result. Clicking the link should take you to the "New order" page for the correct vendor and basket. The catalog details section of the form should include the correct information. - From the search results page view the bibliographic details page for any record. There should be a new toolbar button, "Add order." Verify that it works correctly. - Test the same thing from all bibliographic detail pages: Normal, MARC, Labeled MARC (enable viewLabeledMARC system preference), ISBD, as well as the items page (moredetail.pl). - Test this process for both the locations in acquisitions where one can add to an existing basket: Vendor search results and the basket detail page - Test the cookie timeout: Wait 10 minutes and perform another catalog search. The "Add order" link should no longer be present. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96839|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 97949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97949&action=edit Bug 24347: (follow-up) Remove custom catalog search from acquisitions This patch removes the "neworderbiblio" script and template which are made obsolete by the "search to order" feature. deleted: acqui/neworderbiblio.pl deleted: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderbiblio.tt Some documentation in addorder.pl has been corrected to remove reference to neworderbiblio.pl. To test, apply the patch and verify that the correct files have been removed. Search the Koha codebase to verify that no links to acqui/neworderbiblio.pl remain. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97948|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98101&action=edit Bug 24347: Add a 'search to order' option similar to 'search to hold' This patch modifes the process of searching for an existing record to add to a basket. Now the search is performed as a keyword search in the regular catalog rather than via a custom search script. Options are added to the search results and detail pages to add results to an order. This process follows the same pattern as the "Search to hold" feature: When the search is initiated, a cookie is set with the requisite information--in this case vendor id and basket number. If the search results or bibliographic detail pages detect that a "searchToOrder" cookie is present, the correct "Add order" link will be shown. Like with the "search to hold" feature, the cookie expires in 10 minutes. To test, apply the patch and log into the staff client as a user who has permission to add to a basket in acquisitions. - Go to Acquisitions -> Vendor -> Basket -> Add to basket. - Using the "From an existing record" option, perform a search. - On the search results page, test the "Add order" link which appears with each result. Clicking the link should take you to the "New order" page for the correct vendor and basket. The catalog details section of the form should include the correct information. - From the search results page view the bibliographic details page for any record. There should be a new toolbar button, "Add order." Verify that it works correctly. - Test the same thing from all bibliographic detail pages: Normal, MARC, Labeled MARC, ISBD, as well as the items page (moredetail.pl). - Test this process for both the locations in acquisitions where one can add to an existing basket: Vendor search results and the basket detail page - Test the cookie timeout: Wait 10 minutes and perform another catalog search. The "Add order" link should no longer be present. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97949|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98102&action=edit Bug 24347: (follow-up) Remove custom catalog search from acquisitions This patch removes the "neworderbiblio" script and template which are made obsolete by the "search to order" feature. deleted: acqui/neworderbiblio.pl deleted: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderbiblio.tt Some documentation in addorder.pl has been corrected to remove reference to neworderbiblio.pl. To test, apply the patch and verify that the correct files have been removed. Search the Koha codebase to verify that no links to acqui/neworderbiblio.pl remain. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx a lot Owen for picking up my idea and running with it! Possible improvement I could imagine: - Add a link to jump directly to Advanced search - Improve the styling of the 'Add to order' pop up to make all our different options a bit easier to handle (not related to this bug actually) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This introduces a new cookie right.. should this get recorded on the wiki page for cookies? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- https://wiki.koha-community.org/wiki/Use_of_Cookies - Katrin or Owen.. could you do the honours pretty please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #10)
https://wiki.koha-community.org/wiki/Use_of_Cookies - Katrin or Owen.. could you do the honours pretty please.
I already added a personal tag about it yesterday :) Is there a way we could mark them otherwise/publicly? I have an update of the cookie docs on the agenda since I think I found a few missing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Could add a public keyword I suppose.. I use those allot to share States with people.. like the Manual and needs-release-notes.. how about 'new-cookie' ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #13)
Could add a public keyword I suppose.. I use those allot to share States with people.. like the Manual and needs-release-notes.. how about 'new-cookie' ?
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Cookie description added! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Would it make sense to have the "Add order" link a bit more visible? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #16)
Would it make sense to have the "Add order" link a bit more visible?
As you have to start from the basket I don't mind the current display - people will be looking for the link. But open to ideas, what were you thinking of? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #17)
(In reply to Jonathan Druart from comment #16)
Would it make sense to have the "Add order" link a bit more visible?
As you have to start from the basket I don't mind the current display - people will be looking for the link. But open to ideas, what were you thinking of?
To be honest I spent 10 min trying to understand which parameter was missing, and why the previous view (the table with the "Order" buttons on the right) did not appear. I thought it was a bug! If we are coming from the acquisition module we certainly only want to do that action, however the link is lost between all the other links. I do not have an idea that could be ergonomic however (I thought maybe cats, snow or stars around the new link? but...) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #18)
(In reply to Katrin Fischer from comment #17)
(In reply to Jonathan Druart from comment #16)
Would it make sense to have the "Add order" link a bit more visible?
As you have to start from the basket I don't mind the current display - people will be looking for the link. But open to ideas, what were you thinking of?
To be honest I spent 10 min trying to understand which parameter was missing, and why the previous view (the table with the "Order" buttons on the right) did not appear. I thought it was a bug! If we are coming from the acquisition module we certainly only want to do that action, however the link is lost between all the other links. I do not have an idea that could be ergonomic however (I thought maybe cats, snow or stars around the new link? but...)
I think the inbuilt list for odering lacked some of the information that you would want to see. To me this works similar now than the 'search to hold' or 'order from holds ratio report' where we display an additional link, when the feature was activated. What could be nice is maybe displaying a 'back to basket' link where the 'last patron' thing is? Just thinking how we could further streamline navigation... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #20 from Joy Nelson <joy@bywatersolutions.com> --- New feature not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24111 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature allows release notes| |staff to add items to an | |order via a new 'Search to | |order' function accessible | |from the basket. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a 'search to order' |Add a 'search to order' |option similar to 'search |function similar to 'search |to hold' |to hold' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a 'search to order' |Add a 'search to order' |function similar to 'search |function |to hold' | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature allows |This new feature allows release notes|staff to add items to an |staff to add items to an |order via a new 'Search to |order via a new 'Search to |order' function accessible |order' function accessible |from the basket. |from the basket. The order | |can then be created either | |directly from the result | |list or the detail pages of | |the catalog. | |This replaces | |the former search | |functionality for existing | |records within the | |acquisitions module and | |makes it possible to use | |all search features and | |information shown in the | |normal catalog. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Did anyone sponsor this one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27900 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27900 [Bug 27900] regression: add from existing record with null results deadends -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org