https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #43 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Why do you add in catalogue/search.pl: +use String::Random; +@results_per_page_options = do { my %seen; grep { !$seen{$_}++ } @results_per_page_options }; Could you 'do' this without a do statement? Do you need uniq from List::More ? Is it really needed btw? Do you expect duplicate numbers in this pref.. results.tt Why are you changing the lines with respect to list counts? What is the relation with this patch? opac-search.pl -$offset = ($page-1)*$results_per_page if $page>1; Why do you remove it ? - ($error, $results_hashref, $facets) = C4::Search::pazGetRecords($query,$simple_query,\@sort_by,\@servers,$results_per_page,$offset,$expanded_facet,undef,$query_type,$scan); + ($error, $results_hashref, $facets) = C4::Search::pazGetRecords($query,$simple_query,\@sort_by,\@servers,$results_per_page,$offset,$expanded_facet,$query_type,$scan); You remove a undef parameter. Why? Is this a bug on its own? What is the relation with this report? Please clarify or adjust. -- You are receiving this mail because: You are watching all bug changes.