[Bug 10465] New: Reference to fields 780 and 785 in UNIMARC XSLT should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 Bug ID: 10465 Summary: Reference to fields 780 and 785 in UNIMARC XSLT should be removed Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: mathieu.saby@univ-rennes2.fr There is some code supposed to manage 780 and 785 field in unimarc xslt files for opac and maybe staff interface. These fields does not exist in unimarc, so the code must be removed. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Assignee|oleonard@myacpl.org |mathieu.saby@univ-rennes2.f | |r Severity|minor |trivial -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 20883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20883&action=edit Bug 10465 : remove useless reference to fields 780 and 785 in UNIMARC XSLT files UNIMARCslim2OPACDetail.xsl and UNIMARCslim2intranetDetail.xsl contains references to 780 and 785 fields, that exist in Marc21 but not in UNIMARC. This patch remove the code related to 780 and 785 fields. No effect should be visible. To test : in a UNIMARC Koha 1. be sure that OPACXSLTDetailsDisplay , OPACXSLTResultsDisplay , XSLTDetailsDisplay and XSLTResultsDisplay sysprefs are set to "default" 2. apply the patch 3. search some records in staff interface : the list view and the detail view must be exacty the same as before you apply the patch. 4. search some records in OPAC : the list view and the detail view must be exacty the same as before you apply the patch. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20883|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21151&action=edit [SIGNED-OFF] Bug 10465 : remove useless reference to fields 780 and 785 in UNIMARC XSLT files UNIMARCslim2OPACDetail.xsl and UNIMARCslim2intranetDetail.xsl contains references to 780 and 785 fields, that exist in Marc21 but not in UNIMARC. This patch remove the code related to 780 and 785 fields. No effect should be visible. To test : in a UNIMARC Koha 1. be sure that OPACXSLTDetailsDisplay , OPACXSLTResultsDisplay , XSLTDetailsDisplay and XSLTResultsDisplay sysprefs are set to "default" 2. apply the patch 3. search some records in staff interface : the list view and the detail view must be exacty the same as before you apply the patch. 4. search some records in OPAC : the list view and the detail view must be exacty the same as before you apply the patch. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: No diplay change, no koha-qa errors. Removes what can't be displayed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21151|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21310&action=edit [PASSED QA] Bug 10465 : remove useless reference to fields 780 and 785 in UNIMARC XSLT files UNIMARCslim2OPACDetail.xsl and UNIMARCslim2intranetDetail.xsl contains references to 780 and 785 fields, that exist in Marc21 but not in UNIMARC. This patch remove the code related to 780 and 785 fields. No effect should be visible. To test : in a UNIMARC Koha 1. be sure that OPACXSLTDetailsDisplay , OPACXSLTResultsDisplay , XSLTDetailsDisplay and XSLTResultsDisplay sysprefs are set to "default" 2. apply the patch 3. search some records in staff interface : the list view and the detail view must be exacty the same as before you apply the patch. 4. search some records in OPAC : the list view and the detail view must be exacty the same as before you apply the patch. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: No diplay change, no koha-qa errors. Removes what can't be displayed. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked detail pages in OPAC and intranet still display correctly and without errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Mathieu! I note that it looks like the equivalent of the MARC21 780/785 in UNIMARC is a bunch of 4XX fields, for anybody who wants to implement preceding/succeeding links correctly in the UNIMARC XSLT templates. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 --- Comment #5 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Thanks. I thought it was made but I will test it. We use our own XSLT so we did not noticed the bugs of the standard one... Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 --- Comment #6 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Same changes must be made in new bootstrap opac theme. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Mathieu! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 --- Comment #8 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- And I need to port it to boostrap theme. Homework for this evening... Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 --- Comment #9 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- done : see bug 11246 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11246 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org