[Bug 19766] New: Preview routing slip is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766 Bug ID: 19766 Summary: Preview routing slip is broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 19058 The method reserve_id is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 859. The method set is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 871. Can't call method "store" on an undefined value at /home/vagrant/kohaclone/C4/Reserves.pm line 871. This is caused by commit ba1f2f93ef58c8dd935add3e215facdd4a589d12 Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19058 [Bug 19058] Move C4::Reserves::GetReserveId to Koha::Holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69591&action=edit Bug 19766: (bug 19058 follow-up) Fix Preview routing slip This patch fixes the following errors: The method reserve_id is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 859. The method set is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 871. Can't call method "store" on an undefined value at /home/vagrant/kohaclone/C4/Reserves.pm line 871. This is caused by commit ba1f2f93ef58c8dd935add3e215facdd4a589d12 Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace We are calling ->reserve_id on a Koha::Holds set. Test plan: - Serials -> Find subscription -> "Edit routing list" in the sidebar - Add 1+ recipients - Save -> "Save and preview routing slip" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69591|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69592&action=edit Bug 19766: (bug 19058 follow-up) Fix Preview routing slip This patch fixes the following errors: The method reserve_id is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 859. The method set is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 871. Can't call method "store" on an undefined value at /home/vagrant/kohaclone/C4/Reserves.pm line 871. This is caused by commit ba1f2f93ef58c8dd935add3e215facdd4a589d12 Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace We are calling ->reserve_id on a Koha::Holds set. Test plan: - Serials -> Find subscription -> "Edit routing list" in the sidebar - Add 1+ recipients - Save -> "Save and preview routing slip" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19761 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761 [Bug 19761] Move template JavaScript to the footer: Serials, part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69592|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69593&action=edit Bug 19766: (bug 19058 follow-up) Fix Preview routing slip This patch fixes the following errors: The method reserve_id is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 859. The method set is not covered by tests at /home/vagrant/kohaclone/C4/Reserves.pm line 871. Can't call method "store" on an undefined value at /home/vagrant/kohaclone/C4/Reserves.pm line 871. This is caused by commit ba1f2f93ef58c8dd935add3e215facdd4a589d12 Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace We are calling ->reserve_id on a Koha::Holds set. Test plan: - Serials -> Find subscription -> "Edit routing list" in the sidebar - Add 1+ recipients - Save -> "Save and preview routing slip" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to stable for 17.11.01, awesome work all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Bug 19058 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We seem to have the same problem in 16.11 - but the patch here doesn't apply and the errors are different: Can't call method "branchname" on an undefined value at /home/vagrant/kohaclone/serials/routing-preview.pl line 69. I will file a new bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19858 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org