[Bug 19753] New: Move template JavaScript to the footer: Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Bug ID: 19753 Summary: Move template JavaScript to the footer: Acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for some of the acquisitions templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69532&action=edit Bug 19753: Move template JavaScript to the footer: Acquisitions This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. This patch adds a JavaScript file, acquisitions-menu.js, which controls the highlighting of the current page in the sidebar. Highlighting will be temporarily broken for pages which have not been modified to include this file To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions home page - Datatable, Inactive budget controls - Vendor search results - Acquisitions -> Vendor search - Datatables, "Show all" links - Basket - Acquisitions -> Vendor -> Basket - Datatables, button controls, add managing user - Add to basket from a staged file - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - Datatables, tabs, selection controls - Edit basket - Acquisitions -> Vendor -> Edit basket - Form validation - EDIFACT messages - Acquisitions -> EDIFACT messages - Datatables, message preview - Orders search - Acquisitions -> Order search - Full orders search form - Patron autocomplete in "Basket created by" field - Datepickers - Orders search results - Datatables, column visibility - Invoices - Acquisitions -> Vendor -> Invoices -> Invoice - Form validation, datepickers, datatables - Invoice files (enable AcqEnableFiles preference) - Manage invoice files - File list datatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19754 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754 [Bug 19754] Move template JavaScript to the footer: Acquisitions, part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Simon Pouchol <simon.pouchol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69532|0 |1 is obsolete| | --- Comment #2 from Simon Pouchol <simon.pouchol@biblibre.com> --- Created attachment 69795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69795&action=edit Bug 19753: Move template JavaScript to the footer: Acquisitions This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. This patch adds a JavaScript file, acquisitions-menu.js, which controls the highlighting of the current page in the sidebar. Highlighting will be temporarily broken for pages which have not been modified to include this file To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions home page - Datatable, Inactive budget controls - Vendor search results - Acquisitions -> Vendor search - Datatables, "Show all" links - Basket - Acquisitions -> Vendor -> Basket - Datatables, button controls, add managing user - Add to basket from a staged file - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - Datatables, tabs, selection controls - Edit basket - Acquisitions -> Vendor -> Edit basket - Form validation - EDIFACT messages - Acquisitions -> EDIFACT messages - Datatables, message preview - Orders search - Acquisitions -> Order search - Full orders search form - Patron autocomplete in "Basket created by" field - Datepickers - Orders search results - Datatables, column visibility - Invoices - Acquisitions -> Vendor -> Invoices -> Invoice - Form validation, datepickers, datatables - Invoice files (enable AcqEnableFiles preference) - Manage invoice files - File list datatable Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Simon Pouchol <simon.pouchol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |simon.pouchol@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69795|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70081&action=edit Bug 19753: Move template JavaScript to the footer: Acquisitions This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. This patch adds a JavaScript file, acquisitions-menu.js, which controls the highlighting of the current page in the sidebar. Highlighting will be temporarily broken for pages which have not been modified to include this file To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions home page - Datatable, Inactive budget controls - Vendor search results - Acquisitions -> Vendor search - Datatables, "Show all" links - Basket - Acquisitions -> Vendor -> Basket - Datatables, button controls, add managing user - Add to basket from a staged file - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - Datatables, tabs, selection controls - Edit basket - Acquisitions -> Vendor -> Edit basket - Form validation - EDIFACT messages - Acquisitions -> EDIFACT messages - Datatables, message preview - Orders search - Acquisitions -> Order search - Full orders search form - Patron autocomplete in "Basket created by" field - Datepickers - Orders search results - Datatables, column visibility - Invoices - Acquisitions -> Vendor -> Invoices -> Invoice - Form validation, datepickers, datatables - Invoice files (enable AcqEnableFiles preference) - Manage invoice files - File list datatable Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70082&action=edit Bug 19753: (QA follow-up) Style invoices menu item when on individual invoice page Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19401 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Patch doesn't apply --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please rebase on top of bug 19401. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401 [Bug 19401] No confirm message when deleting an invoice from invoice detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70081|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70123&action=edit Bug 19753: Move template JavaScript to the footer: Acquisitions This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. This patch adds a JavaScript file, acquisitions-menu.js, which controls the highlighting of the current page in the sidebar. Highlighting will be temporarily broken for pages which have not been modified to include this file To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions home page - Datatable, Inactive budget controls - Vendor search results - Acquisitions -> Vendor search - Datatables, "Show all" links - Basket - Acquisitions -> Vendor -> Basket - Datatables, button controls, add managing user - Add to basket from a staged file - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - Datatables, tabs, selection controls - Edit basket - Acquisitions -> Vendor -> Edit basket - Form validation - EDIFACT messages - Acquisitions -> EDIFACT messages - Datatables, message preview - Orders search - Acquisitions -> Order search - Full orders search form - Patron autocomplete in "Basket created by" field - Datepickers - Orders search results - Datatables, column visibility - Invoices - Acquisitions -> Vendor -> Invoices -> Invoice - Form validation, datepickers, datatables - Invoice files (enable AcqEnableFiles preference) - Manage invoice files - File list datatable Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70082|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70124&action=edit Bug 19753: (QA follow-up) Style invoices menu item when on individual invoice page Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70081|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70082|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70123|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70124|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70082|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70128&action=edit Bug 19753: (QA follow-up) Style invoices menu item when on individual invoice page Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70128|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70081|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70129&action=edit Bug 19753: Move template JavaScript to the footer: Acquisitions This patch modifies some staff client acquisitions templates so that JavaScript is included in the footer instead of the header. This patch adds a JavaScript file, acquisitions-menu.js, which controls the highlighting of the current page in the sidebar. Highlighting will be temporarily broken for pages which have not been modified to include this file To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions home page - Datatable, Inactive budget controls - Vendor search results - Acquisitions -> Vendor search - Datatables, "Show all" links - Basket - Acquisitions -> Vendor -> Basket - Datatables, button controls, add managing user - Add to basket from a staged file - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file - Datatables, tabs, selection controls - Edit basket - Acquisitions -> Vendor -> Edit basket - Form validation - EDIFACT messages - Acquisitions -> EDIFACT messages - Datatables, message preview - Orders search - Acquisitions -> Order search - Full orders search form - Patron autocomplete in "Basket created by" field - Datepickers - Orders search results - Datatables, column visibility - Invoices - Acquisitions -> Vendor -> Invoices -> Invoice - Form validation, datepickers, datatables - Invoice files (enable AcqEnableFiles preference) - Manage invoice files - File list datatable Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70130&action=edit Bug 19753: (QA follow-up) Style invoices menu item when on individual invoice page Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21989 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21989 [Bug 21989] JS error in "Add orders from MARC file" - addorderiso2709.pl -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org