https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434 --- Comment #35 from David Cook <dcook@prosentient.com.au> --- (In reply to Srdjan Jankovic from comment #34)

I could have done it both ways, but these days I prefer client side. * As a sever side dude, I prefer that clients use their cycles

I think client capabilities really range a lot, so as a server side dude I'd rather present as consistent a baseline as possible.

* Tomorrow we decide to make search an api call, this still works

Your API call would still need to return the text for you to replace, so that doesn't really make sense. The API call could return translated text. You'd just need a locale parameter.

And a personal, not a valid reason: I find that translations are easier (cleaner) in js

I haven't done much with translations, but I believe you with that one. That said, if we used resource files for certain strings as I've suggested elsewhere, translations would be simple. In a persistent environment, you only load the file once, so there's not much overhead. But that's just my 2 cents. I'm not offering up any alternative patches, so I'm mostly just curious about the rationale. Thanks for taking the time to respond :). -- You are receiving this mail because: You are watching all bug changes.