[Bug 12220] New: bootstrap not responsive on all devices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 Bug ID: 12220 Summary: bootstrap not responsive on all devices Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org I'm reporting this for a library since I'm not sure if this is the issue or if there is another problem: ---------------- There's a header meta-tag being shoved to browsers that I think is preventing some mobile devices from properly resizing their screens. From any OPAC session on catalog.hmcpl.org, you'll find the following in the <head>: <meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1"> I believe the "maximum-scale=1" is the cause of this. This is problematic for us as we are just starting to roll out a new OPAC design, using wall-mounted iPads. The 10" screen is not a problem if a patron can easily zoom in on the info they need -- the setting above prevents that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Anyone have any ideas on this? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se --- Comment #2 from Viktor Sarge <viktor.sarge@regionhalland.se> --- (In reply to Nicole C. Engard from comment #1)
Anyone have any ideas on this?
My understanding is that they have indeed found the problem and that the maximum-scale attribute is often used to prevent content from being blown up and get blurry images on for example iPad. It would be easy to remove I guess, but since it will have all manners of effects on different platform I think there should be more discussion on the issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 Aaron Sakovich <asakovich@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |asakovich@hmcpl.org --- Comment #3 from Aaron Sakovich <asakovich@hmcpl.org> --- FYI, I wrote the original comment Nicole quoted above in a query to her. Viktor, in retrospect, I don't think the problem is so much iPads, as it is phones. If the responsive design has flipped into phone mode, then I know some designers want to prevent zooming. Unfortunately, this meta-tag doesn't discriminate between a narrow-screened phone-mode and a wide-screened iPad-mode. Perhaps a 'maximum-scale=2' or '...=4' would be more appropriate than saying "Nein! Ist verboten!!"? Or is there another way to programmatically determine if the responsive display is in a narrow-screen phone-mode and then enforce the restriction, leaving the larger-screen iPads unimpeded? (I've always been averse to having a server tell users what they can't do on their device's UI, so we were dismayed when we discovered we couldn't pinch-to-zoom on iPads. Personally, I'd remove it completely if it were left to me -- which I know it's not. Fortunately.) Open to suggestions! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 29229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29229&action=edit Bug 12220 - bootstrap not responsive on all devices The bootstrap theme includes a meta tag attribute which disables zooming on some devices. This was unintentional and not desirable. This patch removes the problematic attribute. See: http://blog.javierusobiaga.com/stop-using-the-viewport-tag-until-you-know-ho To test: Apply the patch and view the OPAC on a device with a touch interface. Attempt to zoom in on any OPAC page. Zooming should work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29229|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 29268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29268&action=edit Bug 12220 - bootstrap not responsive on all devices The bootstrap theme includes a meta tag attribute which disables zooming on some devices. This was unintentional and not desirable. This patch removes the problematic attribute. See: http://blog.javierusobiaga.com/stop-using-the-viewport-tag-until-you-know-ho To test: Apply the patch and view the OPAC on a device with a touch interface. Attempt to zoom in on any OPAC page. Zooming should work. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29268|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29285&action=edit Bug 12220 - bootstrap not responsive on all devices The bootstrap theme includes a meta tag attribute which disables zooming on some devices. This was unintentional and not desirable. This patch removes the problematic attribute. See: http://blog.javierusobiaga.com/stop-using-the-viewport-tag-until-you-know-ho To test: Apply the patch and view the OPAC on a device with a touch interface. Attempt to zoom in on any OPAC page. Zooming should work. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Reproduced using a smartphone. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> --- This would be great in 3.14 and 3.16 as well if it won't break things. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.2. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org