[Bug 18989] New: Allow displaying biblios with all items hidden by OpacHiddenItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Bug ID: 18989 Summary: Allow displaying biblios with all items hidden by OpacHiddenItems Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 10584 made Koha hide biblios for which all items match some criteria (in OpacHiddenItems) so they are hidden. There should be a syspref controlling this behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |tomascohen@gmail.com Depends on| |10584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 [Bug 10584] Hide OPAC bibilo details if all items are hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Only for the record,the way removal is implemented makes search results show 19 records instead of 20 (if one record is removed). We should definitely leverage on the search engine for this kind of stuff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is why the numbering in the result lists is removed, when you use OpacHiddenItems - to hide the 'holes'. Using the search engine would be better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- It would be great if this could be done per itemtype. That would allow you to easily define an electronic record itemtype without having to create dummy items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Owen Leonard from comment #3)
It would be great if this could be done per itemtype. That would allow you to easily define an electronic record itemtype without having to create dummy items.
I think this is already covered. The problem this bug higlights is that if all items are marked as hidden, then the biblio is hidden. You can safely create a biblio without items and it will be displayed correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17277 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17277 [Bug 17277] Current Location column in Holdings table showing empty under OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17277 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17277 [Bug 17277] Current Location column in Holdings table showing empty under OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Patricio Marrone <marrone.patricio@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19064 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Carl <ctodd@hcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ctodd@hcc.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24403 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Still valid. We have to patch to comment code for some of our libraries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Why not write a patch to make this a configuration option instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23923 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 109656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109656&action=edit Bug 18989: Allow displaying biblios with all items hidden by OpacHiddenItems Bug 10584 made Koha hide biblios for which all items match some criteria (in OpacHiddenItems) so they are hidden. Add syspref OpacHiddenItemsHidesRecord controlling this behaviour. Test plan : 1) 1.1) Create some biblio records with one item having damaged=1 1.2) Define system preference OpacHiddenItems = damaged: 1 2) 2.1) Set system preference OpacHiddenItemsHidesRecord to 'don't hide' 2.2) At OPAC : perform a search showing those records and some more 2.3) Check you see the all the records 2.4) For a record with hidden item check you don't get HTTP 404 for : normal view, ISBD view, MARC view 2.5) Check you can had tags on this record 2.6) Add record to basket, check you see it in basket 3) 3.1) Set system preference OpacHiddenItemsHidesRecord to 'hide' 3.2) At OPAC : perform a search showing those records and some more 3.3) Check you don't see the records with hidden item 3.4) For a record with hidden item check you get HTTP 404 for : normal view, ISBD view, MARC view 3.5) Show basket, check you see the records with hidden item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 109657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109657&action=edit Bug 18989: add atomic update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I propose system preference "OpacHiddenItemsHidesRecord" so that you get it when searching "OpacHiddenItems" :D Feel free to share your opinion. I hope we can move on with this old problem ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109657|0 |1 is obsolete| | --- Comment #10 from Kelly McElligott <kelly@bywatersolutions.com> --- Created attachment 114738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114738&action=edit Bug 18989: add atomic update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17787 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109656|0 |1 is obsolete| | Attachment #114738|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116000&action=edit Bug 18989: Allow displaying biblios with all items hidden by OpacHiddenItems Bug 10584 made Koha hide biblios for which all items match some criteria (in OpacHiddenItems) so they are hidden. Add syspref OpacHiddenItemsHidesRecord controlling this behaviour. Test plan : 1) 1.1) Create some biblio records with one item having damaged=1 1.2) Define system preference OpacHiddenItems = damaged: 1 2) 2.1) Set system preference OpacHiddenItemsHidesRecord to 'don't hide' 2.2) At OPAC : perform a search showing those records and some more 2.3) Check you see the all the records 2.4) For a record with hidden item check you don't get HTTP 404 for : normal view, ISBD view, MARC view 2.5) Check you can had tags on this record 2.6) Add record to basket, check you see it in basket 3) 3.1) Set system preference OpacHiddenItemsHidesRecord to 'hide' 3.2) At OPAC : perform a search showing those records and some more 3.3) Check you don't see the records with hidden item 3.4) For a record with hidden item check you get HTTP 404 for : normal view, ISBD view, MARC view 3.5) Show basket, check you see the records with hidden item Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116001&action=edit Bug 18989: Add atomic update Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116002&action=edit Bug 18989: (QA follow-up) Terminology fixes and linking the system preference in pref description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116003&action=edit Bug 18989: (QA follow-up) Have new preference default to current behaviour At the moments the records are hidden when all items are hidden, so we need to make sure that we keep this behaviour when the preference is added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Tomas, as the current expert on OpacHiddenItems - could you have an additional look here? I did 2 small follow-ups, testing so far everything works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Somehow the default value displayed in the UI is "Don't hide". The DB shows that the value is '1'. When toggling the syspref, the value is 'yes' and 'no'. So I tried with 'yes' instead of '1' in atomicupdate/bug_18989.sql but the default value is still '1' in the DB and "Don't hide" in the UI. Any hints? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #16)
Somehow the default value displayed in the UI is "Don't hide". The DB shows that the value is '1'. When toggling the syspref, the value is 'yes' and 'no'. So I tried with 'yes' instead of '1' in atomicupdate/bug_18989.sql but the default value is still '1' in the DB and "Don't hide" in the UI.
Any hints?
Setting to failed QA. Wondering if this could have to do with the YAML library changes? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119524&action=edit Bug 18989: Fix syspref's value selection See commit 1fe1b704f9a81172f2a6b86367b314572a854d18 Bug 22824: Fix yes/no vs 1/0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed, | |rel_21_05_candidate CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Currently the bibliographic release notes| |record will be hidden in | |the OPAC, if all linked | |items are hidden by | |criteria defined in | |OpacHiddenItems. This patch | |adds a new system | |preference | |OpacHiddenItemsHidesRecord | |that allows to control this | |behavior making it possible | |to show the record, even if | |all items are hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116000|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119784&action=edit Bug 18989: Allow displaying biblios with all items hidden by OpacHiddenItems Bug 10584 made Koha hide biblios for which all items match some criteria (in OpacHiddenItems) so they are hidden. Add syspref OpacHiddenItemsHidesRecord controlling this behaviour. Test plan : 1) 1.1) Create some biblio records with one item having damaged=1 1.2) Define system preference OpacHiddenItems = damaged: 1 2) 2.1) Set system preference OpacHiddenItemsHidesRecord to 'don't hide' 2.2) At OPAC : perform a search showing those records and some more 2.3) Check you see the all the records 2.4) For a record with hidden item check you don't get HTTP 404 for : normal view, ISBD view, MARC view 2.5) Check you can had tags on this record 2.6) Add record to basket, check you see it in basket 3) 3.1) Set system preference OpacHiddenItemsHidesRecord to 'hide' 3.2) At OPAC : perform a search showing those records and some more 3.3) Check you don't see the records with hidden item 3.4) For a record with hidden item check you get HTTP 404 for : normal view, ISBD view, MARC view 3.5) Show basket, check you see the records with hidden item Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116001|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119785&action=edit Bug 18989: Add atomic update Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116002|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119786&action=edit Bug 18989: (QA follow-up) Terminology fixes and linking the system preference in pref description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116003|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119787&action=edit Bug 18989: (QA follow-up) Have new preference default to current behaviour At the moments the records are hidden when all items are hidden, so we need to make sure that we keep this behaviour when the preference is added. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119524|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119788&action=edit Bug 18989: Fix syspref's value selection See commit 1fe1b704f9a81172f2a6b86367b314572a854d18 Bug 22824: Fix yes/no vs 1/0 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen@gmail.com |fridolin.somers@biblibre.co | |m QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off QA Contact|katrin.fischer@bsz-bw.de |tomascohen@gmail.com --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tomas, can you add, or not, your stamp on this one please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi, I've been following this dev with interest, but failed to add my comments promptly. Sorry for that. One of the reasons we've been chasing leaks in the OPAC regarding hidden things, is because, too often, we don't use the same logic in all places (in which it is meaningful to do so, of course). With that in mind, we added things like Koha::Item->hidden_in_opac Koha::Biblio->hidden_in_opac So, to add my stamp, I would like this logic to be added to Koha::Biblio->hidden_in_opac instead, and leave the controllers untouched. Tests should cover all cases and we will be (forever?) sure we don't leak things anymore. I have doubts about opac-tags.pl, which has a more convoluted logic in it, and probably needs a rewrite (I think it is the missing piece in all this refactoring we've been doing). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120137&action=edit Bug 18989: (QA follow-up) Make Koha::Biblio->hidden_in_opac aware of OpacHiddenItemsHidesRecord This patch makes the method aware of the new syspref. It will only eval the rules against items if the OpacHiddenItemsHidesRecord syspref is set. Tests are added to reflect this. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120138&action=edit [OPTIONAL] Bug 18989: (QA follow-up) Make controllers use Koha::Biblio->hidden_in_opac Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I've decided to add a follow-up so we make Koha::Biblio->hidden_in_opac aware of the new syspref. But I decided to defer changing the places in which it would be used to anothe series of bugs. Some of them are trivial, but others really require big refactorings (good ones, simplifying things, optimizing as well) that are out of the scope of this nice and simple feature addition. I submit now a partial patch for those trivial cases, for the RM to decide. It will not be complete, and can be skipped to allow this feature to be pushed. And I will certainly add this to 21.11 roadmap. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- FAIL opac/opac-MARCdetail.pl FAIL valid Global symbol "$bibio" requires explicit package name (did you forget to declare "my $bibio"?) opac/opac-MARCdetail.pl had compilation errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #29)
FAIL opac/opac-MARCdetail.pl FAIL valid Global symbol "$bibio" requires explicit package name (did you forget to declare "my $bibio"?) opac/opac-MARCdetail.pl had compilation errors.
So you are considering the inclusion of the partial follow-up? I can fix that, just thought you would prefer to handle that on separate bug reports. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120138|0 |1 is obsolete| | --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120171&action=edit [OPTIONAL] Bug 18989: (QA follow-up) Make controllers use Koha::Biblio->hidden_in_opac Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There is something wrong: 1. OpacHiddenItems: "itype: [VM]" 2. OpacHiddenItemsHidesRecord: Hide 3. Biblio 271 has 2 items VM Hit /cgi-bin/koha/opac-detail.pl?biblionumber=271 => Redirected to 404, OK 4. Add a new item to 271, itemtype=Music 5. Hit /cgi-bin/koha/opac-detail.pl?biblionumber=271 => Record is displayed (OK) but all the 3 items appear in the table (KO) It is ok in master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120431&action=edit But 18989: Restore hidding items on detail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120431|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120432&action=edit Bug 18989: Restore hidding items on detail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120432|0 |1 is obsolete| | --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120558&action=edit Bug 18989: Restore hidding items on detail Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Good catch. I forgot this file didn't get the hiding logic refactoring yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- What about opac-shelves? Items are not hidden there... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28299 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28299 [Bug 28299] OpacHiddenItems not working on opac-shelves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #37 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #36)
What about opac-shelves?
Items are not hidden there...
See bug 28299. Additional question: Does it really make sense to have this one part of 21.05 with all the other OpacHiddenItems bugs we have (see bug 24403)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #38 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #37)
(In reply to Jonathan Druart from comment #36)
What about opac-shelves?
Items are not hidden there...
See bug 28299.
Additional question: Does it really make sense to have this one part of 21.05 with all the other OpacHiddenItems bugs we have (see bug 24403)?
I think it makes total sense. Most of those bugs are cosmetic (facets that won't return results, wrong counts). The other ones shouldn't prevent this to get into master. Those need to be rewritten using Koha::Biblio->hidden_in_opac and friends, which takes into account what is introduced on this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28299 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #39 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #40 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28600 [Bug 28600] Variable "$patron" is not available -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #41 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #1)
Only for the record,the way removal is implemented makes search results show 19 records instead of 20 (if one record is removed).
We should definitely leverage on the search engine for this kind of stuff.
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19704 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 --- Comment #42 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #1)
Only for the record,the way removal is implemented makes search results show 19 records instead of 20 (if one record is removed).
We should definitely leverage on the search engine for this kind of stuff.
Although there are times like bug 19704 where the search engine isn't involved... and sysprefs like "OpacHiddenItemsExceptions" add the patron category to the calculation which might make that search engine idea impossible. I reckon the whole OpacHidden* needs an overhaul... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org