[Bug 11766] New: Use validation plugin when creating new authority type
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11766 Bug ID: 11766 Summary: Use validation plugin when creating new authority type Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/authtypes.pl?op=add_form OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 11764 The new authority type entry form uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11765 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11766 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25291&action=edit Bug 11766 - Use validation plugin when creating new authority type The new authority type entry form uses custom form validation JavaScript. This patch removes it in favor of using HTML5 validation attributes and Koha's built-in validation plugin. To test, go to Administration -> Authority types and click "New authority type." Try submitting the form without entering any data. You should see a warning about required fields. Upon entering text in those fields the warning should disappear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11766 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11767 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11766 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11766 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25291|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 25409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25409&action=edit Bug 11766 - Use validation plugin when creating new authority type The new authority type entry form uses custom form validation JavaScript. This patch removes it in favor of using HTML5 validation attributes and Koha's built-in validation plugin. To test, go to Administration -> Authority types and click "New authority type." Try submitting the form without entering any data. You should see a warning about required fields. Upon entering text in those fields the warning should disappear. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11766 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11766 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25409|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25424&action=edit r Attachment to Bug 11766 - Use validation plugin when creating new authority type Bug 11766 - Use validation plugin when creating new authority type The new authority type entry form uses custom form validation JavaScript. This patch removes it in favor of using HTML5 validation attributes and Koha's built-in validation plugin. To test, go to Administration -> Authority types and click "New authority type." Try submitting the form without entering any data. You should see a warning about required fields. Upon entering text in those fields the warning should disappear. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11766 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11766 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 Nice work, HTML5 is really usefull. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org