http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Patch for 3.16.x, 3.18.x and master. The intranet does not need this change (already done). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34274|0 |1 is obsolete| | --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 34313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34313&action=edit Bug 13428: Fix regression on deleting facets Test plan: Search for something click on a facet with diacritic click on another facet remove the facet with diacritic Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #4)

...

Signed-off-by: Mason James <mtj@kohaaloha.com>

this tested OK for me on 3.16, 3.18 and master branches

tested OK on prog and BS opac themes, for 3.16 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34313|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34339&action=edit [PASSED QA] Bug 13428: Fix regression on deleting facets Test plan: Search for something click on a facet with diacritic click on another facet remove the facet with diacritic Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x (no string changes) will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Jonathan Druart from comment #9)

This should not have been pushed before bug 13425, because now the facets deletion is broken :)

Yep 13425 opac changes are pushed to master, 3.18.x and 3.16.x and this only changes the opac, so needed to be pushed.

It should be pushed to 3.16.x, the patch applies cleanly.

ping Mason :)

So yep just to 3.16.x now -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 Bug 13428 depends on bug 13425, which changed state. Bug 13425 Summary: There is an xss vulnerability in 3.16, 3.18 and master in the opac and intranet facets http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13425 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.