[Bug 36758] New: We should notify an assignee when they are assigned a ticket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Bug ID: 36758 Summary: We should notify an assignee when they are assigned a ticket Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Depends on: 35657 We introduce the ability to assign tickets/concerns to users in bug 35657 but we don't trigger a notification for that assigned user. We should add the option to send a notice to the new assignee when you are not assigning to yourself. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657 [Bug 35657] Add ability to assign tickets to librarians for catalog concerns -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34255 [Bug 34255] Add an enquiry/request/workflow management module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166316&action=edit Bug 36758: Add TICKET_ASSIGNED notice This patch adds a new default TICKET_ASSIGNED notice to be used with catalog concerns to notice the assigned staff user when a ticket has been assigned to them. Test plan 1) Run the database update and confirm that the new notice has been added to the database (If on the sandboxes, skip to the next patch) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166317&action=edit Bug 36758: Add librarian object This patch adds a 'librarian' object fetch to C4::Letters::GetPreparedLetter when a called passes the 'want_librarian' flag. This allows for the notice to take full advantage of the patron object for that librarian rather than requireing old non-TT syntax for this feature. Test plan 1) We use the 'librarian' object in the new TICKET_ASSIGNED default notice, use the next patch to test that the librarian title is correctly substituted into the notice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166318&action=edit Bug 36758: Unit tests for assignee notification trigger This patch adds unit tests for the TICKET_ASSIGNED trigger being introduced with this patchset. Test plan 1) Run the unit tests prior to the next patch and confirm they fail 2) Apply the next patch and confirm the unit tests now pass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166319&action=edit Bug 36758: Add trigger for assignee notification trigger This patch adds a new notice trigger to allow notifying assigned staff that they have been assigned a new catalog concern to action. Test plan 1) Enable catalog concerns (either via staff or opac interfaces) 2) Report a new concern (either via staff or opac interfaces) 3) As a staff user, assign the concern to another staff user 4) Check that the new 'TICKET_ASSIGNED' notice has be queued for that staff user. 5) Re-assign the catalog concern to yourself 6) Note that you do not see a 'TICKET_ASSIGNED@ notice queued as you self-assigned. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Note to RM.. I introduce a new feature to C4::Letters::GetPreparedLetter in here (see 'Add librarian object'). It's perhaps wise to split this into it's own bug, but it's simplest to test inline here. Let me know if you'd like it split out as it will inevitably be very helpful in the transition to TT notices everywhere. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166316|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 166390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166390&action=edit Bug 36758: Add TICKET_ASSIGNED notice This patch adds a new default TICKET_ASSIGNED notice to be used with catalog concerns to notice the assigned staff user when a ticket has been assigned to them. Test plan 1) Run the database update and confirm that the new notice has been added to the database (If on the sandboxes, skip to the next patch) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166317|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 166391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166391&action=edit Bug 36758: Add librarian object This patch adds a 'librarian' object fetch to C4::Letters::GetPreparedLetter when a called passes the 'want_librarian' flag. This allows for the notice to take full advantage of the patron object for that librarian rather than requireing old non-TT syntax for this feature. Test plan 1) We use the 'librarian' object in the new TICKET_ASSIGNED default notice, use the next patch to test that the librarian title is correctly substituted into the notice. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166318|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 166392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166392&action=edit Bug 36758: Unit tests for assignee notification trigger This patch adds unit tests for the TICKET_ASSIGNED trigger being introduced with this patchset. Test plan 1) Run the unit tests prior to the next patch and confirm they fail 2) Apply the next patch and confirm the unit tests now pass Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166319|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 166393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166393&action=edit Bug 36758: Add trigger for assignee notification trigger This patch adds a new notice trigger to allow notifying assigned staff that they have been assigned a new catalog concern to action. Test plan 1) Enable catalog concerns (either via staff or opac interfaces) 2) Report a new concern (either via staff or opac interfaces) 3) As a staff user, assign the concern to another staff user 4) Check that the new 'TICKET_ASSIGNED' notice has be queued for that staff user. 5) Re-assign the catalog concern to yourself 6) Note that you do not see a 'TICKET_ASSIGNED@ notice queued as you self-assigned. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166390|0 |1 is obsolete| | Attachment #166391|0 |1 is obsolete| | Attachment #166392|0 |1 is obsolete| | Attachment #166393|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 169238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169238&action=edit Bug 36758: Add TICKET_ASSIGNED notice This patch adds a new default TICKET_ASSIGNED notice to be used with catalog concerns to notice the assigned staff user when a ticket has been assigned to them. Test plan 1) Run the database update and confirm that the new notice has been added to the database (If on the sandboxes, skip to the next patch) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 169239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169239&action=edit Bug 36758: Add librarian object This patch adds a 'librarian' object fetch to C4::Letters::GetPreparedLetter when a called passes the 'want_librarian' flag. This allows for the notice to take full advantage of the patron object for that librarian rather than requireing old non-TT syntax for this feature. Test plan 1) We use the 'librarian' object in the new TICKET_ASSIGNED default notice, use the next patch to test that the librarian title is correctly substituted into the notice. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 169240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169240&action=edit Bug 36758: Unit tests for assignee notification trigger This patch adds unit tests for the TICKET_ASSIGNED trigger being introduced with this patchset. Test plan 1) Run the unit tests prior to the next patch and confirm they fail 2) Apply the next patch and confirm the unit tests now pass Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 169241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169241&action=edit Bug 36758: Add trigger for assignee notification trigger This patch adds a new notice trigger to allow notifying assigned staff that they have been assigned a new catalog concern to action. Test plan 1) Enable catalog concerns (either via staff or opac interfaces) 2) Report a new concern (either via staff or opac interfaces) 3) As a staff user, assign the concern to another staff user 4) Check that the new 'TICKET_ASSIGNED' notice has be queued for that staff user. 5) Re-assign the catalog concern to yourself 6) Note that you do not see a 'TICKET_ASSIGNED@ notice queued as you self-assigned. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement to catalog release notes| |concerns allows staff to be | |notified when a new concern | |is assigned to them for | |action (when | |CatalogConcerns and | |OpacCatalogConcerns are | |enabled). It uses a new | |TICKET_ASSIGNED notice. No | |notice is sent when it is | |self-assigned. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement to catalog |This enhancement to catalog release notes|concerns allows staff to be |concerns notifies staff |notified when a new concern |when a new concern is |is assigned to them for |assigned to them for action |action (when |(when CatalogConcerns and |CatalogConcerns and |OpacCatalogConcerns are |OpacCatalogConcerns are |enabled). It uses a new |enabled). It uses a new |TICKET_ASSIGNED notice. No |TICKET_ASSIGNED notice. No |notice is sent when it is |notice is sent when it is |self-assigned. |self-assigned. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have fixed this typo: [%- INCLUDE 'patron-title.inc' patron => libraian -%] (In reply to Martin Renvoize from comment #5)
Note to RM.. I introduce a new feature to C4::Letters::GetPreparedLetter in here (see 'Add librarian object'). It's perhaps wise to split this into it's own bug, but it's simplest to test inline here. Let me know if you'd like it split out as it will inevitably be very helpful in the transition to TT notices everywhere.
I think if this is needed for backport, maybe we could do the separate bug then. Keeping it in this patch set for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but this is breaking the tests. I did 3 follow-up patches, please look at them as well. They should only be the normal DBRev, Tidy and a few typo fixes in docs and letter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170226&action=edit Bug 36758: (follow-up) Fix unit tests We do two things here.. * We're making the improvement to C4::Letters that sets librarian to a patron object more resilient by testing for the userenv first. * We correct the logic in Koha::Ticket such that we always store changes when there's a ticket update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Follow-up pushed to main, confirmed it fixes the tests locally. Fingers crossed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Bug 36758 depends on bug 35657, which changed state. Bug 35657 Summary: Add ability to assign tickets to librarians for catalog concerns https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/957 CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36758 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement to catalog |This enhancement to catalog release notes|concerns notifies staff |concerns notifies staff |when a new concern is |when a new concern is |assigned to them for action |assigned to them for action |(when CatalogConcerns and |(when CatalogConcerns and |OpacCatalogConcerns are |OpacCatalogConcerns are |enabled). It uses a new |enabled). It uses a new |TICKET_ASSIGNED notice. No |TICKET_ASSIGNED notice. No |notice is sent when it is |notice is sent when it is |self-assigned. |self-assigned. | | | |**Sponsored | |by** *PTFS Europe* -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org