[Bug 18177] New: Many unused columns in aqbooksellers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Bug ID: 18177 Summary: Many unused columns in aqbooksellers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org I've found that the following columns are not actually used (in Koha's codebase): - address2 - address3 - address4 - othersupplier - currency - booksellerfax - booksellerurl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- address2, address3 and address4 are used if they exist on the DB, by the template. They are concatenated using \n and splitted back on save... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Component|Architecture, internals, |Database |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100861&action=edit Bug 18177: remove aqbooksellers.othersupplier This patchset removes some columns from the aqbooksellers table that are not used: * booksellerfax * booksellerurl * bookselleremail * currency The first 3 ones are certainly leftover from bug 10402. Test plan: For each for these fields you will make sure that they cannot be edited from the interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100862&action=edit Bug 18177: remove aqbooksellers.booksellerfax -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100863&action=edit Bug 18177: remove aqbooksellers.booksellerurl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100864&action=edit Bug 18177: remove aqbooksellers.bookselleremail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100865&action=edit Bug 18177: remove aqbooksellers.currency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100866&action=edit Bug 18177: DB changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100867&action=edit Bug 18177: DBIC changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100861|0 |1 is obsolete| | Attachment #100862|0 |1 is obsolete| | Attachment #100863|0 |1 is obsolete| | Attachment #100864|0 |1 is obsolete| | Attachment #100865|0 |1 is obsolete| | Attachment #100866|0 |1 is obsolete| | Attachment #100867|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100868&action=edit Bug 18177: remove aqbooksellers.othersupplier This patchset removes some columns from the aqbooksellers table that are not used: * booksellerfax * booksellerurl * bookselleremail * othersupplier * currency The first 3 ones are certainly leftover from bug 10402. Test plan: For each for these fields you will make sure that they cannot be edited from the interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100869&action=edit Bug 18177: remove aqbooksellers.booksellerfax -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100870&action=edit Bug 18177: remove aqbooksellers.booksellerurl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100871&action=edit Bug 18177: remove aqbooksellers.bookselleremail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100872&action=edit Bug 18177: remove aqbooksellers.currency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100873&action=edit Bug 18177: DB changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100874&action=edit Bug 18177: DBIC changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The 4 fields address[1-4] are built from the "Physical address" input. However, if the address entered has more than 4 lines, the following ones are dropped. That is for a separate bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15272 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15272 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15272 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272 [Bug 15272] aqbookseller addresses are combined into "physical address" field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Frank Hansen <frank.hansen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frank.hansen@ub.lu.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #17 from Frank Hansen <frank.hansen@ub.lu.se> --- When we migrated from your previous ILS (Virtua), I kept some vendor contact information in booksellerfax, bookselleremail and currency. This means that we are will lose this information when you drop them from DB. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101612&action=edit Bug 18177: Do not remove columns if at least one value exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Frank Hansen from comment #17)
When we migrated from your previous ILS (Virtua), I kept some vendor contact information in booksellerfax, bookselleremail and currency. This means that we are will lose this information when you drop them from DB.
Thanks Frank for this feedback? What about this last patch? We are going to remove the column only if there is no data, otherwise a warning will be displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Frank Hansen from comment #17)
When we migrated from your previous ILS (Virtua), I kept some vendor contact information in booksellerfax, bookselleremail and currency. This means that we are will lose this information when you drop them from DB.
Thanks Frank for this feedback! What about this last patch? We are going to remove the column only if there is no data, otherwise a warning will be displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #20)
(In reply to Frank Hansen from comment #17)
When we migrated from your previous ILS (Virtua), I kept some vendor contact information in booksellerfax, bookselleremail and currency. This means that we are will lose this information when you drop them from DB.
Thanks Frank for this feedback!
What about this last patch? We are going to remove the column only if there is no data, otherwise a warning will be displayed.
Maybe we can give some advise for migrating that data? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #22 from Frank Hansen <frank.hansen@ub.lu.se> --- (In reply to Jonathan Druart from comment #20)
(In reply to Frank Hansen from comment #17)
When we migrated from your previous ILS (Virtua), I kept some vendor contact information in booksellerfax, bookselleremail and currency. This means that we are will lose this information when you drop them from DB.
Thanks Frank for this feedback!
What about this last patch? We are going to remove the column only if there is no data, otherwise a warning will be displayed.
Yes, this will at least keep the data in those columns so they're not getting lost. But is the plan to remove those fields completely from UI as well? If that is the case, we have no use for them. We can probably live without those columns anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Unused should not be in the GUI - if they are, we might need to keep some! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- They are not displayed (view or edit) anywhere. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #25 from Frank Hansen <frank.hansen@ub.lu.se> --- (In reply to Jonathan Druart from comment #24)
They are not displayed (view or edit) anywhere.
When I dig a little deeper into how we migrated, it turned out that we copied the same value to multiple columns. For example, currency is the same as invoiceprice; booksellerfax is the same as fax; and bookselleremail was also inserted in aqcontacts.email. So this means that we will not lose any data at all. The columns othersupplier and booksellerurl is not used here at Lund University. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100868|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 101687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101687&action=edit Bug 18177: remove aqbooksellers.othersupplier This patchset removes some columns from the aqbooksellers table that are not used: * booksellerfax * booksellerurl * bookselleremail * othersupplier * currency The first 3 ones are certainly leftover from bug 10402. Test plan: For each for these fields you will make sure that they cannot be edited from the interface. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100869|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 101688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101688&action=edit Bug 18177: remove aqbooksellers.booksellerfax Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100870|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 101689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101689&action=edit Bug 18177: remove aqbooksellers.booksellerurl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100871|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 101690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101690&action=edit Bug 18177: remove aqbooksellers.bookselleremail Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100872|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 101691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101691&action=edit Bug 18177: remove aqbooksellers.currency Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100873|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 101692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101692&action=edit Bug 18177: DB changes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100874|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 101693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101693&action=edit Bug 18177: DBIC changes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101612|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 101694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101694&action=edit Bug 18177: Do not remove columns if at least one value exists Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks like I overlapped with incoming comments.. really pleased to see this cleanup being done. I've signed off as the patches all do as intended and I'm happy to agree that these fields have not been used in the codebase for some time. The final patch is nice to have in cases where people have migrated data as a 'just in case'.. Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101687|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 101958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101958&action=edit Bug 18177: remove aqbooksellers.othersupplier This patchset removes some columns from the aqbooksellers table that are not used: * booksellerfax * booksellerurl * bookselleremail * othersupplier * currency The first 3 ones are certainly leftover from bug 10402. Test plan: For each for these fields you will make sure that they cannot be edited from the interface. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101688|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 101959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101959&action=edit Bug 18177: remove aqbooksellers.booksellerfax Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101689|0 |1 is obsolete| | --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 101960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101960&action=edit Bug 18177: remove aqbooksellers.booksellerurl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101690|0 |1 is obsolete| | --- Comment #39 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 101961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101961&action=edit Bug 18177: remove aqbooksellers.bookselleremail Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101691|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 101962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101962&action=edit Bug 18177: remove aqbooksellers.currency Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101692|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 101963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101963&action=edit Bug 18177: DB changes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101693|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 101964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101964&action=edit Bug 18177: DBIC changes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101694|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 101965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101965&action=edit Bug 18177: Do not remove columns if at least one value exists Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- + warn "Warning - Cannot remove column aqbooksellers.$column. At least one value exists"; Does this warn find its way to the interface. Probably not. Print it ? I will pass QA. Feel free to add follow-up. @RM: Watch for DBIx changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #44)
+ warn "Warning - Cannot remove column aqbooksellers.$column. At least one value exists";
Does this warn find its way to the interface. Probably not. Print it ? I will pass QA. Feel free to add follow-up.
@RM: Watch for DBIx changes
warnings should be seen from the interface, maybe at the bottom in the red part? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- They will indeed be displayed at the bottom of the page in red when I tested :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102011&action=edit Bug 18177: (follow-up) remove aqbooksellers.currency There was an occurrence in tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #49 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18177 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Many unused columns in |Remove unused columns in |aqbooksellers |aqbooksellers CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org