[Bug 11182] New: Warnings in circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Bug ID: 11182 Summary: Warnings in circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: srdjan@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Eliminate unnecessary warnings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 22662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22662&action=edit bug_11182: get rid of some warnings To testi - circulation: * For a child patron, check that "Upgrade to adult" link on the "More" drop-down is clickable * Set sys pref FineNotifyAtCheckin to yes (Notify), and check in an overdue item that attracts fine. Fine amount should be displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |srdjan@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22662|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 22864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22864&action=edit bug_11182: get rid of some warnings To test - circulation: * For a child patron, check that "Upgrade to adult" link on the "More" drop-down is clickable * Set sys pref FineNotifyAtCheckin to yes (Notify), and check in an overdue item that attracts fine. Fine amount should be displayed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22864|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 22865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22865&action=edit bug_11182: get rid of some warnings To test - circulation: * For a child patron, check that "Upgrade to adult" link on the "More" drop-down is clickable * Set sys pref FineNotifyAtCheckin to yes (Notify), and check in an overdue item that attracts fine. Fine amount should be displayed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Found some additional circ/circulations.pl warnings. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24171&action=edit Bug 11182 - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Sorry to make this a split effort, but since my error log entries really did overlap with this bug, I figured I'd add my patch here. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24171|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24179&action=edit Bug 11182 - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24171|1 |0 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 24171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24171 Bug 11182 - Warnings in circulation Silly git bz obsoleted this. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22865|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24181&action=edit [SIGNED OFF] Bug 11182 - get rid of some warnings After fuller testing, there were five problems found: circulation.pl:273 borrower_debarments.inc:65 returns.pl:269 returns.pl:284 returns.pl:540 This patch catches returns.pl:269 and returns.pl:540 TEST PLAN --------- 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name and click 'Submit' 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log NOTE: only the warnings from lines 269 and 540 in returns.pl are the ones to note. 12) Apply this patch 13) Repeat steps 6 through 11, there should no new warnings related to lines 269 or 540 from returns.pl. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24171|0 |1 is obsolete| | Attachment #24179|0 |1 is obsolete| | --- Comment #10 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 24196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24196&action=edit Bug 11182 - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 --- Comment #11 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 24198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24198&action=edit Bug 11182 - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24181|0 |1 is obsolete| | --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 24209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24209&action=edit Bug 11182 - get rid of some warnings After fuller testing, there were five problems found: circulation.pl:273 borrower_debarments.inc:65 returns.pl:269 returns.pl:284 returns.pl:540 This patch catches returns.pl:269 and returns.pl:540 Oops. Cut-and-paste error. Corrected step 5. :) TEST PLAN --------- 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure FineNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name and click 'Submit' 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log NOTE: only the warnings from lines 269 and 540 in returns.pl are the ones to note. 12) Apply this patch 13) Repeat steps 6 through 11, there should no new warnings related to lines 269 or 540 from returns.pl. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24196|0 |1 is obsolete| | Attachment #24198|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24516&action=edit Bug 11182 - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24517&action=edit Bug 11182 - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24518&action=edit Bug 11182 - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24516|0 |1 is obsolete| | Attachment #24517|0 |1 is obsolete| | Attachment #24518|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24519&action=edit Bug 11182 - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24209|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24520&action=edit Bug 11182 - get rid of some warnings After fuller testing, there were five problems found: circulation.pl:273 borrower_debarments.inc:65 returns.pl:269 returns.pl:284 returns.pl:540 This patch catches returns.pl:269 and returns.pl:540 Oops. Cut-and-paste error. Corrected step 5. :) TEST PLAN --------- 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure FineNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name and click 'Submit' 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log NOTE: only the warnings from lines 269 and 540 in returns.pl are the ones to note. 12) Apply this patch 13) Repeat steps 6 through 11, there should no new warnings related to lines 269 or 540 from returns.pl. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24519|0 |1 is obsolete| | Attachment #24520|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24522&action=edit Bug 11182 [1] - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24523&action=edit Bug 11182 [2] - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24524&action=edit Bug 11182 [3] - get rid of some warnings After fuller testing, there were five problems found: circulation.pl:273 borrower_debarments.inc:65 returns.pl:269 returns.pl:284 returns.pl:540 This patch catches returns.pl:269 and returns.pl:540 Oops. Cut-and-paste error. Corrected step 5. :) TEST PLAN --------- 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure FineNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name and click 'Submit' 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log NOTE: only the warnings from lines 269 and 540 in returns.pl are the ones to note. 12) Apply this patch 13) Repeat steps 6 through 11, there should no new warnings related to lines 269 or 540 from returns.pl. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24522|0 |1 is obsolete| | --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 24955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24955&action=edit Bug 11182 [1] - Warnings in circulation TEST PLAN --------- 1) Log into staff client 2) Click 'Circulation' 3) Click 'Check out' 4a) Type a patron name, click 'Submit' 4b) If necessary, select which one, and click 'Select' 5) Check the error logs, new warnings 6) Apply patch 7) Click 'Circulation' 8) Click 'Check out' 9a) Type a patron name, click 'Submit' 9b) If necessary, select which one, and click 'Select' 10) Check the error logs, no new warnings 11) Click the 'Restrictions' tab 12) Click 'Add manual restriction' 13) Add a dummy restriction 14) Click the 'Restrictions' tab 15) Click 'Remove' 16) Click 'OK' 17) Confirm that no additional error log entries were added and adding/deleting restrictions hasn't broken. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24523|0 |1 is obsolete| | --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 24956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24956&action=edit Bug 11182 [2] - Warnings in circulation This deals with the warning when Circulation system preference 'WaitingNotifyAtCheckin' is set to 'Notify' and an overdue item is checked in. TEST PLAN --------- 0) Feel free to backup your koha-error_log file, and then toast it. $ echo > ~/koha-dev/var/log/koha-error_log 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure WaitingNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log | grep 284 NOTE: the returns.pl one that will be fixed by this. 12) Apply this patch 13) Repeat steps 6 through 7, there should no new line 284 entries. Signed-off-by: Jesse Weaver <pianohacker@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24524|0 |1 is obsolete| | --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 24957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24957&action=edit Bug 11182 [3] - get rid of some warnings After fuller testing, there were five problems found: circulation.pl:273 borrower_debarments.inc:65 returns.pl:269 returns.pl:284 returns.pl:540 This patch catches returns.pl:269 and returns.pl:540 Oops. Cut-and-paste error. Corrected step 5. :) TEST PLAN --------- 1) Log into staff client 2) Koha administration 3) Global system preferences 4) Circulation 5) Make sure FineNotifyAtCheckin is set to Notify. 6) Check out tab 7) Type patron's name and click 'Submit' 8) Select patron if required 9) Check out an item, but set the due date to be overdue. 10) Check in the overdue item. 11) Check the error log $ cat ~/koha-dev/var/log/koha-error_log NOTE: only the warnings from lines 269 and 540 in returns.pl are the ones to note. 12) Apply this patch 13) Repeat steps 6 through 11, there should no new warnings related to lines 269 or 540 from returns.pl. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 24958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24958&action=edit Bug 11182: (QA followup) warning if itemBarcodeFallbackSearch set To reproduce: - On top of the previous patches, if you enable the itemBarcodeFallbackSearch syspref and do a search for a term that returns at least one result, there will be warnings for each result without items attached. To test: - In the checkout form enter a term that should return results (some of them without items attached) => There are warnings on the logs regarding a split of undef variable - Apply the patch - Repeat the first step => No warings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #25 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Srdjan, Mark, and Tomás! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org