http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11751 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6712 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11751 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25211&action=edit Bug 11751: Institution related code is unused and obsolete Test plan: Looking at the code and using grep, git grep, etc. verify this patch does not remove something in use. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11751 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- *** Bug 11816 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11751 --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 25547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25547&action=edit Bug 11751: remove dead code related to handling members of institution patrons This patch removes some dead code concerning the handling of patrons that are members of other, institutional patrons. This code did not work; removing it clears the field if somebody wants to do a better implementation of such relationships between patrons. This patch: [1] Removes the memberofinstitution system preference. [2] Removes the following routines: C4::Members::get_institutions() C4::Members::add_member_orgs() (and removing this routine removes a reference to a borrowers_to_borrowers table that does not exist). There should be no changes whatsoever to system functionality with this patch (with the trivial exception of the absence of the memberofinstitution system preference). Test plan: [1] Look at the code and use grep, git grep, etc. verify this patch does not remove something in use. [2] Verify that there are no regressions upon adding or editing a patron record. [3] Verify that the memberofinstitution system preference has been removed Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11751 --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- As you can see from the duplicate bug I filed, I went down /exactly/ the same road before I discovered the existence of this patch. I've signed off on it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11751 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |brendan@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11751 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |fridolyn.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #8 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Too big to push to 3.14, I set as resolved in 3.16. -- You are receiving this mail because: You are watching all bug changes.