https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22204 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29114 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29114 [Bug 29114] Can not add barcodes with whitespaces at the beginning to the list -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132781|0 |1 is obsolete| | --- Comment #3 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 132881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132881&action=edit Bug 30409: barcodedecode() should always trim barcode Barcode is trimmed of leading/trailing whitespaces in many instances before the barcodedecode sub was called. This patch instead makes that barcodedecode sub is going to trim it itself and removes unnecessary, and repetitive code that was used before barcodedecode was called. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132881|0 |1 is obsolete| | --- Comment #4 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 132884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132884&action=edit Bug 30409: barcodedecode() should always trim barcode Barcode is trimmed of leading/trailing whitespaces in many instances before the barcodedecode sub was called. This patch instead makes that barcodedecode sub is going to trim it itself and removes unnecessary, and repetitive code that was used before barcodedecode was called. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Could you please add a test plan? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 --- Comment #8 from Andrew Nugged <nugged@gmail.com> --- Petro, please prioritize. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132885|0 |1 is obsolete| | --- Comment #9 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 135258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135258&action=edit Bug 30409: barcodedecode() should always trim barcode Barcode is trimmed of leading/trailing whitespaces in many instances before the barcodedecode sub was called. This patch instead makes that barcodedecode sub is going to trim it itself and removes unnecessary, and repetitive code that was used before barcodedecode was called. Steps to test: 1. Edit item with any barcode, add a bunch of whitespaces at the start and at the bottom of it. Save the item. Ensure that this action ruins the barcode and ensure that the spaces are still there by editing the same item again. 2. Apply the patch. 3. Edit the same item again in the same fashion. Ensure that now all whitespaces are getting trimmed and it doesn't affect the barcode in any negative way. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Signed Off |Failed QA --- Comment #13 from David Nind <david@davidnind.com> --- After signing off, I checked again and have changed to Failed QA - as trimming spaces on the check out, check in, renew, course reserves forms doesn't seem to work. It certainly works when editing the item and saving it - the spaces before and after are removed. However, after applying the patch, but not editing the item where spaces before and after the barcode were added in step 1, I tried: . Circulation > Check out: doesn't work - barcode not found . Circulation > Check in: doesn't work - barcode not found . Circulation > Renew: doesn't work - barcode not found . Course reserves > Add reserves for [course name]: doesn't work - barcode not found . Search the catalog: works (finds record with item barcode, as it did before the patch was applied) I hope I have understood what the patch is supposed to do correctly! Notes: The OPAC continue to work as expected (search with spaces before and after the barcode, and advanced search). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 --- Comment #15 from Peter Vashchuk <stalkernoid@gmail.com> --- Hey David, could you please check this again? How I reproduced your problems with the patch applied: - Circulation > Check in: I used " 39999000008098 " and it did work, it trimmed all trailing whitespaces and found the correct item with the barcode I was looking for, - Circulation > Check out: I used " 39999000008098 " again and again it did work, it trimmed all trailing whitespaces and found the correct item. - Circulation > Renew: I used " 39999000008098 " again, worked as well. - Course reserves > Add reserves for [course name]: used " 39999000008098 " input and it worked here as well. I also tried different barcodes and they all work while trailing whitespaces were properly removed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #16 from David Nind <david@davidnind.com> --- Hi Peter. I was too slow retesting, as the patch no longer applies 8-(... git bz apply 30409 Bug 30409 - barcodedecode() should always trim barcode 135453 - Bug 30409: barcodedecode() should always trim barcode Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 30409: barcodedecode() should always trim barcode .git/rebase-apply/patch:18: trailing whitespace. For proper functioning of this filter, calling the function on the .git/rebase-apply/patch:22: trailing whitespace. The optional $filter argument is to allow for testing or explicit .git/rebase-apply/patch:23: trailing whitespace. behavior that ignores the System Pref. Valid values are the same as the warning: 3 lines add whitespace errors. Using index info to reconstruct a base tree... M course_reserves/add_items.pl .git/rebase-apply/patch:18: trailing whitespace. For proper functioning of this filter, calling the function on the .git/rebase-apply/patch:22: trailing whitespace. The optional $filter argument is to allow for testing or explicit .git/rebase-apply/patch:23: trailing whitespace. behavior that ignores the System Pref. Valid values are the same as the warning: 3 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging course_reserves/add_items.pl CONFLICT (content): Merge conflict in course_reserves/add_items.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 30409: barcodedecode() should always trim barcode -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135453|0 |1 is obsolete| | --- Comment #17 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 135705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135705&action=edit Bug 30409: barcodedecode() should always trim barcode Barcode is trimmed of leading/trailing whitespaces in many instances before the barcodedecode sub was called. This patch instead makes that barcodedecode sub is going to trim it itself and removes unnecessary, and repetitive code that was used before barcodedecode was called. Steps to test: 1. Edit item with any barcode, add a bunch of whitespaces at the start and at the bottom of it. Save the item. Ensure that this action ruins the barcode and ensure that the spaces are still there by editing the same item again. 2. Apply the patch. 3. Edit the same item again in the same fashion. Ensure that now all whitespaces are getting trimmed and it doesn't affect the barcode in any negative way. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 --- Comment #20 from David Nind <david@davidnind.com> --- (In reply to Peter Vashchuk from comment #18)

Rebased on current master

Thanks Peter. Have retested and changed to signed off. Things now seem to work as expected. I think what I was getting confused with, was that if a barcode in the actual item had spaces before and after, then this was not found on input forms. This was the case both before and after the patch was applied: 1. Edit a barcode for an item so that it has spaces before and after. 2. Check input forms such as Check out - item not found. 3. After patch applied, item still not found, for example Check out input form. 4. Edit item, save - spaces before and after removed and now found on input forms even if extra spaces added on input forms. Other testing notes: 1. Card barcodes: worked before and after patch for Check out, Search patrons, and Patron lists. 2. Item barcodes: worked before and after patch applied: . From header block: Check out, Check in, Renew . Add reserves . Search (keyword) . From Circulation screen: Check out, Check in, Renew, Transfers, Overdue report . Batch checkout . Tools: Batch item deletion, Batch item modification 3. Item barcodes: didn't work before the patch, but now works after patch applied: . Tools: Barcode image generator, Rotating collections, Inventory 4. Item barcodes: didn't work before the patch, and don't work after patch - possible future enhancements: . Lists . Quick spine label creator . Item search - barcode is -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 --- Comment #22 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 135962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135962&action=edit Bug 30409: (QA follow-up) Fix grammar in syspref help text Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 136067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136067&action=edit Bug 30409: (QA follow-up) Avoid uninitialized variable warnings Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31152 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30409 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 14335 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.