[Bug 20029] New: Verbosity issue that makes the QA tools test suite report 2 failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20029 Bug ID: 20029 Summary: Verbosity issue that makes the QA tools test suite report 2 failures Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: QA tools Assignee: jonathan.druart@bugs.koha-community.org Reporter: victor.grousset@biblibre.com 1. On a fresh Jessie DevBox 2. As vagrant, allow the kohadev-koha user to run the QA tool test suite sudo chown -R kohadev-koha /home/koha/qa-test-tools 3. kshell 4. cd /home/koha/qa-test-tools 5. prove -v t/Perl.t 6. Then you should see two failures According to Joubu:
it is just an output issue I guess try `qa -c 1 -v 1` and `qa -c 1 -v 2` the output is the same, -v 1 should only display the filename, not the details
Results of this test ################################################################### kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ qa -c 1 -v 1 testing 1 commit(s) (applied to e1770d0 'Bug 19973: Fix SQL syntax error in uk') Processing files before patches |========================>| 1 / 1 (100.00%) Processing files after patches |========================>| 1 / 1 (100.00%) OK cataloguing/value_builder/unimarc_field_100.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ qa -c 1 -v 2 testing 1 commit(s) (applied to e1770d0 'Bug 19973: Fix SQL syntax error in uk') Processing files before patches |========================>| 1 / 1 (100.00%) Processing files after patches |========================>| 1 / 1 (100.00%) OK cataloguing/value_builder/unimarc_field_100.pl OK critic OK forbidden patterns OK git manipulation OK pod OK spelling OK valid ################################################################### -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20029 --- Comment #1 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Failing tests are 22 and 23. not ok 22 - Check verbosity output (0) # Failed test 'Check verbosity output (0)' # at t/Perl.t line 261. # got: ' FAIL i_fail_yaml.yaml # OK git manipulation # FAIL yaml_valid # # FAIL perl/Authority.pm # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # FAIL pod coverage # OK spelling # OK valid # # OK perl/i_dont_fail_spelling.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_compil.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # FAIL valid # # FAIL perl/i_fail_critic.pl # FAIL critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_license.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_patterns.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # FAIL valid # # FAIL perl/i_fail_spelling.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # FAIL spelling # OK valid # # FAIL perl/i_fail_template_name.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_unused_declared_variables.pl # FAIL critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # OK perl/i_m_ok.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/updatedatabase.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL sql/kohastructure.sql # FAIL charset_collate # OK git manipulation # # FAIL sql/sysprefs.sql # OK git manipulation # FAIL semicolon # FAIL sysprefs_order # # FAIL tmpl/i_fail_patterns.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # FAIL tmpl/i_fail_patterns_theme.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # FAIL tmpl/i_fail_patterns_tt_plugins.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # FAIL valid_template # # FAIL tmpl/i_fail_tt_valid.tt # OK forbidden patterns # OK git manipulation # OK spelling # FAIL tt_valid # OK valid_template # # FAIL tmpl/i_fail_valid_template.tt # OK forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # FAIL valid_template # # OK tmpl/i_will_be_correct_tt_valid.tt # OK forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # ' # expected: ' FAIL i_fail_yaml.yaml # FAIL perl/Authority.pm # OK perl/i_dont_fail_spelling.pl # FAIL perl/i_fail_compil.pl # FAIL perl/i_fail_critic.pl # FAIL perl/i_fail_license.pl # FAIL perl/i_fail_patterns.pl # FAIL perl/i_fail_spelling.pl # FAIL perl/i_fail_template_name.pl # FAIL perl/i_fail_unused_declared_variables.pl # OK perl/i_m_ok.pl # FAIL perl/updatedatabase.pl # FAIL sql/kohastructure.sql # FAIL sql/sysprefs.sql # FAIL tmpl/i_fail_patterns.tt # FAIL tmpl/i_fail_patterns_theme.tt # FAIL tmpl/i_fail_patterns_tt_plugins.tt # FAIL tmpl/i_fail_tt_valid.tt # FAIL tmpl/i_fail_valid_template.tt # OK tmpl/i_will_be_correct_tt_valid.tt # ' not ok 23 - Check verbosity output (1) # Failed test 'Check verbosity output (1)' # at t/Perl.t line 262. # got: ' FAIL i_fail_yaml.yaml # OK git manipulation # FAIL yaml_valid # # FAIL perl/Authority.pm # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # FAIL pod coverage # OK spelling # OK valid # # OK perl/i_dont_fail_spelling.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_compil.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # FAIL valid # # FAIL perl/i_fail_critic.pl # FAIL critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_license.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_patterns.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # FAIL valid # # FAIL perl/i_fail_spelling.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # FAIL spelling # OK valid # # FAIL perl/i_fail_template_name.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_unused_declared_variables.pl # FAIL critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # OK perl/i_m_ok.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/updatedatabase.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL sql/kohastructure.sql # FAIL charset_collate # OK git manipulation # # FAIL sql/sysprefs.sql # OK git manipulation # FAIL semicolon # FAIL sysprefs_order # # FAIL tmpl/i_fail_patterns.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # FAIL tmpl/i_fail_patterns_theme.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # FAIL tmpl/i_fail_patterns_tt_plugins.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # FAIL valid_template # # FAIL tmpl/i_fail_tt_valid.tt # OK forbidden patterns # OK git manipulation # OK spelling # FAIL tt_valid # OK valid_template # # FAIL tmpl/i_fail_valid_template.tt # OK forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # FAIL valid_template # # OK tmpl/i_will_be_correct_tt_valid.tt # OK forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # ' # expected: ' FAIL i_fail_yaml.yaml # OK git manipulation # FAIL yaml_valid # # FAIL perl/Authority.pm # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # OK perl/i_dont_fail_spelling.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_compil.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # FAIL valid # # FAIL perl/i_fail_critic.pl # FAIL critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_license.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_patterns.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # FAIL valid # # FAIL perl/i_fail_spelling.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # FAIL spelling # OK valid # # FAIL perl/i_fail_template_name.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/i_fail_unused_declared_variables.pl # FAIL critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # OK perl/i_m_ok.pl # OK critic # OK forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL perl/updatedatabase.pl # OK critic # FAIL forbidden patterns # OK git manipulation # OK pod # OK spelling # OK valid # # FAIL sql/kohastructure.sql # FAIL charset_collate # OK git manipulation # # FAIL sql/sysprefs.sql # OK git manipulation # FAIL sysprefs_order # # FAIL tmpl/i_fail_patterns.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # FAIL tmpl/i_fail_patterns_theme.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # FAIL tmpl/i_fail_patterns_tt_plugins.tt # FAIL forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # FAIL valid_template # # FAIL tmpl/i_fail_tt_valid.tt # OK forbidden patterns # OK git manipulation # OK spelling # FAIL tt_valid # OK valid_template # # FAIL tmpl/i_fail_valid_template.tt # OK forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # FAIL valid_template # # OK tmpl/i_will_be_correct_tt_valid.tt # OK forbidden patterns # OK git manipulation # OK spelling # OK tt_valid # OK valid_template # # ' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20029 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- commit aa1a156ade9afb8f6e1268dd85bab6d0b6fa3831 Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Date: Mon Jan 22 11:51:26 2018 -0300 updatedatabase.pl must be valid But fail since Bug 19760: Die if koha-conf is not accessible commit 09b5f33c1a03e5c99e3b40a1ee9ff2ab4167fa6e Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Date: Mon Jan 22 11:18:17 2018 -0300 follow-up pod coverage commit a7805b48e2d72626630ddc3ad72fc50ed7c303dc Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Date: Mon Jan 22 11:12:18 2018 -0300 follow-up Lines should not terminate by semicolons in sysprefs.sql Test output has not been updated in previous commit commit 139edc158a9a2e546911ea9041ef37cdaafaefb9 Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Date: Mon Jan 22 11:10:52 2018 -0300 follow-up Add the --failures flag Fix silly conditions -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org