[Bug 28360] New: Link to make article reqests should display on detail page when user is not logged in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28360 Bug ID: 28360 Summary: Link to make article reqests should display on detail page when user is not logged in Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org I feel like this is a possible regression as it still works from the result list. I the result list the link to make article requests is always displayed, triggering the login screen, when the user is not logged in yet. On the detail page this link has disappeared on the right side if the user is not logged in (tested it latest 20.11) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28360 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just retested this in 20.11: ArticleRequestsLinkControl = Always show - Result list: Article request link always shows - Detail page: Article request link only shows when logged in I think this is because of the check on the artreqpossible template variable - I suspect it can only be 1 if the user is logged in: my $artreqpossible = $patron ? $biblio->can_article_request( $patron ) : $itemtype ? $itemtype->may_article_request : q{}; $template->param( artreqpossible => $artreqpossible ); The code for the same variable in the result list is certainly different, but completely mysterious to me: # BZ17530: 'Intelligent' guess if result can be article requested $res->{artreqpossible} = ( $art_req_itypes->{ $res->{itemtype} // q{} } || $art_req_itypes->{ '*' } ) ? 1 : q{}; I am not sure how to fix this :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28360 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- In my tests in master (as of 21.06.00.022), the "request article" link shows up in search results and on the detail page regardless of the ArticleRequestsLinkControl setting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28360 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |tomascohen@gmail.com --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** This bug has been marked as a duplicate of bug 29168 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org