http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 24950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24950&action=edit proposed patch When merging authority records in librarian interface biblio records linked to deleted authority are not being corrected (i.e. have still old heading and orpaned link in $9). Test plan: 1. Have two authorities in the catalogue, linked to biblio records. 2. Merge them with the new merge facility (cf. Bug 5202). 3. Have a look a the biblio record(s) previously linked to the removed authority. It should still have the old heading AND orpaned authority link in $9. 4. Apply the patch. 5. Refresh the test records (or use another set). 6. Repeat 1-3. Headings should be refreshed and the correct authid link should be in $9 now. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Janusz, I am working on this - could you check if merging 2 records from different frameworks works ok for you? I tried merging one "default" and "personal name" but the merge screen comes up empty? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Aha - wrote the last comment too soon - reindexing fixed it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24977|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24983&action=edit [PASSED QA] Bug 11652: merging authority records does not correct biblios When merging authority records in librarian interface biblio records linked to deleted authority are not being corrected (i.e. have still old heading and orpaned link in $9). Test plan: 1. Have two authorities in the catalogue, linked to biblio records. 2. Merge them with the new merge facility (cf. Bug 5202). 3. Have a look a the biblio record(s) previously linked to the removed authority. It should still have the old heading AND orpaned authority link in $9. 4. Apply the patch. 5. Refresh the test records (or use another set). 6. Repeat 1-3. Headings should be refreshed and the correct authid link should be in $9 now. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Note: new record count on the authority record will show after reindexing. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- This is pending review by Jared. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 --- Comment #10 from Janusz Kaczmarek <januszop@gmail.com> --- Jared, this patch does not depend on dontmerge, nor, most probably, on any other pref. I will try to be as straightforward as I can -- sorry if this will be too straightforward. First of all, the play is around biblio records. Authorities are OK. Now, how does you standard master Koha behave when you merge *two*different*authority* records *from*librarian*interface* (just in case: not from merge_authority.pl script) -- what do you see as $9 in the heading field in *biblio* rec. that was previously linked to the authority which has just been merged (i.e. deleted)? In my case it is the "old" $9 (of the merged = deleted authority) which is now "orphaned", i.e. there is no authority record with this authid. Which is wrong. This patch should correct this -- after applying it you should see "new" authid in $9 (and the heading field itself should be accordingly changed). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Pushed to the bug_11652 branch mm/jcamins for merging into master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Janusz! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11652 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12579 -- You are receiving this mail because: You are watching all bug changes.