[Bug 18648] New: Get rid of tt directives in translation for macles.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Bug ID: 18648 Summary: Get rid of tt directives in translation for macles.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tt contains template directives inside a div tag: <span title="[% FOREACH lib IN cell.libs %][% lib.lib |html %] - [% END %]"> This is exposed in translation tool. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Get rid of tt directives in |Translatability: Get rid of |translation for macles.tt |tt directives in | |translation for macles.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 63592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63592&action=edit Bug 18648 - Translatability: Get rid of tt directives in translation for macles.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tt contains template directives inside a div tag: <span title="[% FOREACH lib IN cell.libs %][% lib.lib |html %] - [% END %]"> This is exposed in translation tool. To test: - Carefully examine code changes - Apply patch, verify that the directive is no longer exposed (picked for po files) - If you know where / how this macles is used, verify that it behaves as before -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63592|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63599&action=edit [SIGNED-OFF] Bug 18648 - Translatability: Get rid of tt directives in translation for macles.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tt contains template directives inside a div tag: <span title="[% FOREACH lib IN cell.libs %][% lib.lib |html %] - [% END %]"> This is exposed in translation tool. To test: - Carefully examine code changes - Apply patch, verify that the directive is no longer exposed (picked for po files) - If you know where / how this macles is used, verify that it behaves as before Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Marc Véron <veron@veron.ch> --- Found an issue - needs some more workk... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63599|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 63853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63853&action=edit Bug 18648: Translatability: Get rid of tt directives in translation for macles.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tt contains template directives inside a div tag: <span title="[% FOREACH lib IN cell.libs %][% lib.lib |html %] - [% END %]"> This is exposed in translation tool. To test: - Carefully examine code changes - Apply patch, verify that the directive is no longer exposed (picked for po files), e.g. by creating a new "language" aa-AA and examing aa-AA-staff-prog.po - If you know where / how this macles is used, verify that it behaves as before (Note: New patch, needs new sign off) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63853|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63987&action=edit Bug 18648: Translatability: Get rid of tt directives in translation for macles.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tt contains template directives inside a div tag: <span title="[% FOREACH lib IN cell.libs %][% lib.lib |html %] - [% END %]"> This is exposed in translation tool. To test: - Carefully examine code changes - Apply patch, verify that the directive is no longer exposed (picked for po files), e.g. by creating a new "language" aa-AA and examing aa-AA-staff-prog.po - If you know where / how this macles is used, verify that it behaves as before (Note: New patch, needs new sign off) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Patch complexity|--- |Trivial patch --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64060&action=edit Bug 18648: Fix syntax 'unexpected end of input' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- This patch removes the hyphen separator : [% FOREACH lib IN cell.libs %][% lib.lib |html %] - [% END %] replaced by : [% FOREACH lib IN cell.libs %][% lib.lib |html %][% END %] Is is normal ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 --- Comment #11 from Marc Véron <veron@veron.ch> --- (In reply to Fridolin SOMERS from comment #10)
This patch removes the hyphen separator : [% FOREACH lib IN cell.libs %][% lib.lib |html %] - [% END %] replaced by : [% FOREACH lib IN cell.libs %][% lib.lib |html %][% END %]
Is is normal ?
No, sorry, that's my error, thanks for pointing it out. Since it is already pushed to master I will file a new bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 --- Comment #12 from Marc Véron <veron@veron.ch> --- *** Bug 18769 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 --- Comment #13 from Marc Véron <veron@veron.ch> --- (In reply to Marc Véron from comment #11)
(In reply to Fridolin SOMERS from comment #10)
This patch removes the hyphen separator : [% FOREACH lib IN cell.libs %][% lib.lib |html %] - [% END %] replaced by : [% FOREACH lib IN cell.libs %][% lib.lib |html %][% END %]
Is is normal ?
No, sorry, that's my error, thanks for pointing it out. Since it is already pushed to master I will file a new bug.
Patch follows on this bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 --- Comment #14 from Marc Véron <veron@veron.ch> --- Created attachment 64160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64160&action=edit Bug 18648: Restore hyphen See comment #10 Hyphen restored and moved as string inside the tt directive to avoid that it is picked for translation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64160|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64162&action=edit Bug 18648: Restore hyphen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marc Véron from comment #14)
Created attachment 64160 [details] [review] Bug 18648: Restore hyphen
See comment #10 Hyphen restored and moved as string inside the tt directive to avoid that it is picked for translation.
This patch did not work: Template process failed: file error - parse error - /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tt line 56: unexpected token (_) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #15)
Created attachment 64162 [details] [review] Bug 18648: Restore hyphen
Pushed to master! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #20 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org