[Bug 33149] New: Use template wrapper for breadcrumbs: Circulation part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 Bug ID: 33149 Summary: Use template wrapper for breadcrumbs: Circulation part 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update some circulation templates so that they use the new template wrapper for breadcrumbs. - circ/article-requests.tt - circ/bookcount.tt - circ/branchoverdues.tt - circ/branchtransfers.tt - circ/checkout-notes.tt - circ/circulation_batch_checkouts.tt - circ/circulation-home.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 147793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147793&action=edit Bug 33149: Use template wrapper for breadcrumbs: Circulation part 1 This patch updates several circulation templates so that they use the new WRAPPER for displaying breadcrumbs. The patch also makes a minor change to bookcount.pl to allow for correct display of the record title using the biblio-title include. Navigation context for bookcount.tt has been changed to "catalog" from "circulation" because the page is linked to from a catalog-related page. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Circulation home page - Checkout notes - Article requests - Transfer - Overdues with fines - Check out -> Check out to patron -> - Batch check out - Catalog -> Search -> Bibliographic record -> Items - View item's checkout history. The updated page should show this new breadcrumb sequence: Home -> Catalog -> [title] -> Items -> Circulation statistics -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 Bug 33149 depends on bug 32507, which changed state. Bug 32507 Summary: Use template wrapper to build breadcrumb navigation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147793|0 |1 is obsolete| | --- Comment #2 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 148901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148901&action=edit Bug 33149: Use template wrapper for breadcrumbs: Circulation part 1 This patch updates several circulation templates so that they use the new WRAPPER for displaying breadcrumbs. The patch also makes a minor change to bookcount.pl to allow for correct display of the record title using the biblio-title include. Navigation context for bookcount.tt has been changed to "catalog" from "circulation" because the page is linked to from a catalog-related page. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Circulation home page - Checkout notes - Article requests - Transfer - Overdues with fines - Check out -> Check out to patron -> - Batch check out - Catalog -> Search -> Bibliographic record -> Items - View item's checkout history. The updated page should show this new breadcrumb sequence: Home -> Catalog -> [title] -> Items -> Circulation statistics Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrew.auld@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148901|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 149071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149071&action=edit Bug 33149: Use template wrapper for breadcrumbs: Circulation part 1 This patch updates several circulation templates so that they use the new WRAPPER for displaying breadcrumbs. The patch also makes a minor change to bookcount.pl to allow for correct display of the record title using the biblio-title include. Navigation context for bookcount.tt has been changed to "catalog" from "circulation" because the page is linked to from a catalog-related page. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Circulation home page - Checkout notes - Article requests - Transfer - Overdues with fines - Check out -> Check out to patron -> - Batch check out - Catalog -> Search -> Bibliographic record -> Items - View item's checkout history. The updated page should show this new breadcrumb sequence: Home -> Catalog -> [title] -> Items -> Circulation statistics Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Probably we should move this page to the catalog folder, however, the permission here is circ based, so it would be a bigger job and requires discussion. IN the context of breadcrumbs, the change makes sense and is small so passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 --- Comment #6 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org