[Bug 40590] New: OPACAuthorIdentifiersAndInformation shows empty list elements for unknown 024$2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 Bug ID: 40590 Summary: OPACAuthorIdentifiersAndInformation shows empty list elements for unknown 024$2 Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org I believe this might be a regression from the first implementation. When there are 024$2 in the authority record that we cannot resolve into a link yet, it shows an empty list element in the OPAC (with the list "button"). This is quite irritating especially if there are multiple. In our case the authority records are not created locally, but imported from the national authority database, so 024$2 cannot be fully controlled. I hope the display should be relative easy to fix in the templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- To test: - Have a record with at least 2 persons (100, 700) linked to an authority record - Have one authority record without any 024 - Have 2 024 in the other authority: 024 $a someidyoumakeup $2orcid 024 $a someidyoumakeup $2somethingelse - Check the detail page in OPAC > author links tab - Check the authority detail page in OPAC, right top side The $2somethingelse is not "supported" and should create the empty list element. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|24.11 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185134&action=edit Bug 40590: Prevent OPACAuthorIdentifiersAndInformation from showing empty list elements for unknown 024$2 This patch modifies the template which is used to display additional author information if OPACAuthorIdentifiersAndInformation is displayed. The change prevents an empty list item from appearing. To test, apply the patch and go to system preferences in the staff interface. - Search for OPACAuthorIdentifiersAndInformation and make sure that "Identifiers (024$2$a)" is checked. - Have a record with at least 2 persons (100, 700) linked to an authority record - One of those authority records should not have an 024 tag - The other authority record should have two 024 tags: - 024 $a someidyoumakeup $2orcid - 024 $a someidyoumakeup $2somethingelse - Check the detail page in OPAC -> "Author information" tab - Check the authority detail page in OPAC, under "Author information" in the right-hand column. Before the patch, '$2somethingelse' is not "supported" and will create the empty list element. After the patch there should be no empty list item. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks a lot, Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185134|0 |1 is obsolete| | --- Comment #4 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 185286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185286&action=edit Bug 40590: Prevent OPACAuthorIdentifiersAndInformation from showing empty list elements for unknown 024$2 This patch modifies the template which is used to display additional author information if OPACAuthorIdentifiersAndInformation is displayed. The change prevents an empty list item from appearing. To test, apply the patch and go to system preferences in the staff interface. - Search for OPACAuthorIdentifiersAndInformation and make sure that "Identifiers (024$2$a)" is checked. - Have a record with at least 2 persons (100, 700) linked to an authority record - One of those authority records should not have an 024 tag - The other authority record should have two 024 tags: - 024 $a someidyoumakeup $2orcid - 024 $a someidyoumakeup $2somethingelse - Check the detail page in OPAC -> "Author information" tab - Check the authority detail page in OPAC, under "Author information" in the right-hand column. Before the patch, '$2somethingelse' is not "supported" and will create the empty list element. After the patch there should be no empty list item. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185286|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 185521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185521&action=edit Bug 40590: Prevent OPACAuthorIdentifiersAndInformation from showing empty list elements for unknown 024$2 This patch modifies the template which is used to display additional author information if OPACAuthorIdentifiersAndInformation is displayed. The change prevents an empty list item from appearing. To test, apply the patch and go to system preferences in the staff interface. - Search for OPACAuthorIdentifiersAndInformation and make sure that "Identifiers (024$2$a)" is checked. - Have a record with at least 2 persons (100, 700) linked to an authority record - One of those authority records should not have an 024 tag - The other authority record should have two 024 tags: - 024 $a someidyoumakeup $2orcid - 024 $a someidyoumakeup $2somethingelse - Check the detail page in OPAC -> "Author information" tab - Check the authority detail page in OPAC, under "Author information" in the right-hand column. Before the patch, '$2somethingelse' is not "supported" and will create the empty list element. After the patch there should be no empty list item. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate, | |rel_25_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00,25.05.03 |25.11.00,25.05.03,24.11.09 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de Keywords|rel_25_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40590 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org