http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle.m.hall@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17372|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17568&action=edit Bug 10030 - MaxFines checks against amount, not amount outstanding If a patron has over time accumulated fines greater than the amount defined in MaxFine, the patron will never get more fines even if they have previously paid off those fines. This bug was introduced by the patch for Bug 7420. Test Plan: 1) Create a patron 2) Create a fine of 10.00 for that patron 3) Pay off the fine 4) Set MaxFines to 5.00 5) Check out an item to the patron, backdate the due date so the item should generate fines. 6) Run fines.pl, observe that no fine was created 7) Apply the patch 8) Rerun fines.pl 9) Observe that the fine was created correctly Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Kyle, I see some strange behaviour with your patch applied: System preferences: maxfine: empty Circulation rules: mpl-staff-books maxfine 15.00 fine 5.00 grace period: 0 interval 1 Logged in branch: mpl Home library of items: mpl Patron home library: mpl I set the due date to about 8-9 days ago using the specify due date feature. I then returned the book using the checkbox on the checkout tab. Suddenly I have credit of 15.00 on my patron account... Couldn't repeat that switching back to master. Could you please check? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Now I can't reproduce on master too - or with your patch. It happened 3 times, I have no time now to figure out what's going on there. Someone taking a closer look would be appreciated. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The problems I experienced were related to the fact that you should use 'new' items/due dates to make sure this works consistently. I am continuing the tests, but reading the code of the sub I couldn't help wondering - do we really want to count in Sundry fines? http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Overdues.pm;h=b... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Tested. Works. Added a trivial followup too for false warning raised (detected while testing this). Simple code change looks good. The question Katrin raised:

I am continuing the tests, but reading the code of the sub I couldn't help wondering - do we really want to count in Sundry fines? This question is certainly valid, but imo falls outside the scope of this report. This patch just fixes the wrongly used column in adding the total amount.

Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.