[Bug 39406] New: Issues on serial collection page sort from old to new now
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 Bug ID: 39406 Summary: Issues on serial collection page sort from old to new now Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Keywords: regression Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com The serial issues on the serial collection page used to sort from new to old, which meant that the issues you were most likely to edit were at the top. Now the table sorts from old to new, which leaves the new items in a long list at the bottom. The old sorting should be restored. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Can you provide a commit id where it was working? I don't find anything in the git log that could cause a regression. I guess the following changes would fix the problem: diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt index 67c39806aae..1e2f62b4746 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt @@ -361,7 +361,7 @@ } $(".subscription-year-table").kohaTable({ columnDefs: [{ targets: [0, -1], orderable: false, searchable: false }], - order: [[0, "desc"]], + order: [[3, "desc"]], dom: "t", autoWidth: false, paginate: false, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I compared it with the latest 22.11 version as that was, what I had at hand immediately. The sorting there is different. KIT who reported was using 23.11 before I believe. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu --- Comment #3 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Katrin Fischer from comment #2)
I compared it with the latest 22.11 version as that was, what I had at hand immediately. The sorting there is different. KIT who reported was using 23.11 before I believe.
Yes we are using 23.11.06 and the order of serial issues is from new to old. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 --- Comment #4 from Michaela Sieber <michaela.sieber@kit.edu> --- We seems that the problem is the column 0 (which is the column with the checkboxes) As Jonathan mentioned this column should be sorted descending (which means it would be sorted by serialid desc) Maybe this is a bug in the new DataTables version because column 0 ist declared as not sortable? The new DataTables version was intruduced in Koha version 24.11 (see bug 36640) We suggest to sort the table by column 1, which is the date published. It should NOT be sorted by column 3 because this is the date received. To change the sorting to the publication date is comprehensible for users and it gives the user the opportunity to change the sorting of the serial issues by editing the Date published. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 182473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182473&action=edit Bug 39406: Make serial issues sort from new to old on collection page This patch fixes the serial collection table to sort in descending order on the date published column. To test: 1. Create a subscription if you don't already have one. 2. Go to the Serial Collection tab using the left navigation. 3. Click the Generate Next button a bunch of times to generate some serial issues. Note that the issues are displaying in the table in ascending order, with the oldest date published at the top. 4. Apply the patch and refresh the page 5. Confirm the issues are now displaying in the table in descending order, with the newest date published at the top. 6. Click the Generate Next button again and confirm the issue is inserted at the top of the table. Sponsored-by: Pymble Ladies' College -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |aleisha@catalyst.net.nz Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy, Sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Great to see a patch here! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182473|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 182564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182564&action=edit Bug 39406: Make serial issues sort from new to old on collection page This patch fixes the serial collection table to sort in descending order on the date published column. To test: 1. Create a subscription if you don't already have one. 2. Go to the Serial Collection tab using the left navigation. 3. Click the Generate Next button a bunch of times to generate some serial issues. Note that the issues are displaying in the table in ascending order, with the oldest date published at the top. 4. Apply the patch and refresh the page 5. Confirm the issues are now displaying in the table in descending order, with the newest date published at the top. 6. Click the Generate Next button again and confirm the issue is inserted at the top of the table. Sponsored-by: Pymble Ladies' College Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the serial release notes| |collection table so that | |issues now sort in | |descending order based on | |the date published column | |(the latest issue at the | |top). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy, Sandbox |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 kch-tr.lhl-consortium@nhs.net <kch-tr.lhl-consortium@nhs.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kch-tr.lhl-consortium@nhs.n | |et -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39406 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #11 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org