[Bug 41395] New: Terminology: Target item cannot be reserved from other branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 Bug ID: 41395 Summary: Terminology: Target item cannot be reserved from other branches Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Target item cannot be reserved from other branches koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:209 branches should be libraries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... and reserved: be placed on hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Same here: Target item cannot be placed on reserve for this branch koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:223 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #0)
Target item cannot be reserved from other branches koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:209
How does one trigger this error message? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure :( It sounds a bit like it relates to certain circulation rule settings? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 190617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190617&action=edit Bug 41395: Terminology: Target item cannot be reserved from other branches This patch corrects some terminology in the holds template, replacing "reserve" with "hold" and "branch" with "library." The patch also removes a duplicate CASE for cannotReserveFromOtherBranches. I'm not sure how to test, and I wonder whether this error intercepted earlier in the code somewhere. The change is simple, so I hope a check of the patch will be enough. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190617|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 190644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190644&action=edit Bug 41395: Terminology: Target item cannot be reserved from other branches This patch corrects some terminology in the holds template, replacing "reserve" with "hold" and "branch" with "library." The patch also removes a duplicate CASE for cannotReserveFromOtherBranches. I'm not sure how to test, and I wonder whether this error intercepted earlier in the code somewhere. The change is simple, so I hope a check of the patch will be enough. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190644|0 |1 is obsolete| | --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 190678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190678&action=edit Bug 41395: Terminology: Target item cannot be reserved from other branches Testing Steps 1. Set the system preference CanReserveFromOtherBranches to “Don’t allow.” 2. Enable the system preference IndependentBranches. 3. Place a hold on an item from your local branch. 4. View the existing hold and select it. 5. Click “Move selected”, then choose “Record level holds to a different record.” * For testing, the original hold was placed on biblionumber 10 (Centerville item). * The hold was then moved to biblionumber 41 (Fairview item), which should not allow holds from another branch. 6. Observe the error message: “Hold ID: 4 Target item cannot be reserved from other branches.” 7. Apply the patch and refresh the page. 8. Observe the updated error message: “Hold ID: 4 Target item cannot be placed on hold from other libraries.” Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Updates the terminology for release notes| |two circulation-related | |messages (reserves to | |holds, branches to | |libraries): | | | |- "Target item cannot be | |reserved from other | |branches" to "Target item | |cannot be placed on hold | |from other libraries" | |- "No reserves allowed" to | |"No holds allowed" CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.01 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 --- Comment #9 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41395 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org