[Bug 19818] New: Add id into tag html from moremember.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Bug ID: 19818 Summary: Add id into tag html from moremember.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: stephane.delaye@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In this screen /cgi-bin/koha/members/moremember.pl? I have several li tags html without id. So when I want custom the labels with the preference system 'intranetuserjs', i can't... from the record patron (memberentry.pl)...it is possible .... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, you can still change the labels, but it's not as easy. Try using :contains('...') on the page with the text of the label. But using ids would make this easier - marking this patch for Academy. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- *** Bug 19416 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Zoe Bennett <zoebennett1308@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 --- Comment #3 from Zoe Bennett <zoebennett1308@gmail.com> --- Created attachment 70540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70540&action=edit Bug 19818: Added id's to the li tags for labels To test: 1)Go to the screen: /cgi-bin/koha/members/moremember.pl 2)On the right of the screen, right click one of the labels below 'Library use' etc, and Inspect Element 3) View <li> tags which should now each have a unique <id> tag for each -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |zoebennett1308@gmail.com |ity.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70540|0 |1 is obsolete| | --- Comment #4 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 70555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70555&action=edit Bug 19818: Added id's to the li tags for labels To test: 1)Go to the screen: /cgi-bin/koha/members/moremember.pl 2)On the right of the screen, right click one of the labels below 'Library use' etc, and Inspect Element 3) View <li> tags which should now each have a unique <id> tag for each Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Looking good, just a small isuue: the spaces need to be used for indentation, not tabs. QA tool reports: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt FAIL forbidden patterns forbidden pattern: tab char (line 495) forbidden pattern: tab char (line 492) forbidden pattern: tab char (line 396) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Zoe Bennett <zoebennett1308@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 --- Comment #6 from Zoe Bennett <zoebennett1308@gmail.com> --- Created attachment 70641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70641&action=edit Bug 19818: Fixing forbidden pattern by using spaces rather than tabs for indentation on lines 396, 492 & 495 in koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |victor.grousset@biblibre.co | |m --- Comment #7 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Hi, after discussing with delaye, can I add a patch with following changes? (except if for {learning, fun, wanting this bug to be finished quickly} reasons someone else wants to do it) 1. Change some of the new ids, e.g. #surname → #alt-contact-surname To add more semantic and avoid id collisions. Mosty in #patron-alternative-contact 2. #borrowernumber → #library-use-borrowernumber #borrowernumber is already used in «Upload patron image» 3. #zip/postalcode → #zip-postal-code / are valid in HTML but will be a pain when using selectors in CSS or JavaScript https://stackoverflow.com/questions/27255591/using-forward-slash-as-id-attri... 4. In #patron-alternate-address add ids, this section was forgotten. The trap was that me must fill all the field when editing the patron to ensure that they are displayed in the profile. 5. Add ids to the <li>s of #patron-information -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 --- Comment #8 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Can I continue the work on this bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Victor, I think it's safe to take this one, if you want to. Please make your changes in a follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|zoebennett1308@gmail.com |victor.grousset@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 helene <hickeyhe@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 --- Comment #10 from helene <hickeyhe@wgc.school.nz> --- Created attachment 84040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84040&action=edit Bug 19818: Added appropriate id to all the list items under libary use heading. 1) Go to the patron details for a patron 2) On the right of the screen, right click one of the labels below 'Library use' etc, and Inspect Element 3) View <li> tags which should now each have a unique <id> tag for each -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 helene <hickeyhe@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|victor.grousset@biblibre.co |hickeyhe@wgc.school.nz |m | CC| |hickeyhe@wgc.school.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|josef.moravec@gmail.com |katrin.fischer@bsz-bw.de Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like the codebase changed a bit since the patch was written. There is a conflict now in moremember.tt. Can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 helene <hickeyhe@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 helene <hickeyhe@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84040|0 |1 is obsolete| | --- Comment #12 from helene <hickeyhe@wgc.school.nz> --- Created attachment 84103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84103&action=edit Bug 19818: Added appropriate id to all the list items under libary use heading. 1) Go to the patron details for a patron 2) On the right of the screen, right click one of the labels below 'Library use' etc, and Inspect Element 3) View <li> tags which should now each have a unique <id> tag for each -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #11)
It looks like the codebase changed a bit since the patch was written. There is a conflict now in moremember.tt. Can you please rebase?
Helene is your patch supposed to be applied on master with or without the patches already on this bug? The older patches don't apply now. The best way to approach this might be to obsolete the older patches and re-implement their changes on master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 helene <hickeyhe@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 helene <hickeyhe@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70555|0 |1 is obsolete| | Attachment #70641|0 |1 is obsolete| | Attachment #84103|0 |1 is obsolete| | --- Comment #14 from helene <hickeyhe@wgc.school.nz> --- Created attachment 84111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84111&action=edit Bug 19818: Thanks, this patch should work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 84146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84146&action=edit Bug 19818: Add id into tag html from moremember.tt 1) Go to the patron details for a patron 2) On the right of the screen, right click one of the labels below 'Library use' etc, and Inspect Element 3) View <li> tags which should now each have a unique <id> tag for each Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84111|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22134 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22134 [Bug 22134] Add account expiration information to patron details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84146|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84239&action=edit Bug 19818: Add id into tag html from moremember.tt 1) Go to the patron details for a patron 2) On the right of the screen, right click one of the labels below 'Library use' etc, and Inspect Element 3) View <li> tags which should now each have a unique <id> tag for each Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #19 from Jesse Maseto <jesse@bywatersolutions.com> --- Merge conflict with 18.05.x. Please rebase if needed in 18.05.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org