[Bug 11676] New: Loading shelving locations based on the item's homebranch instead of the user's logged-in branch.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Bug ID: 11676 Summary: Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: olli-antti.kivilahti@jns.fi QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl ------------ - SYNOPSIS - ------------ When editing items, the shelving locations list does not reflect the shelving locations available for the home branch of the editable item? So if you are editing an item in another branch than the item's homebranch, you have a set of different/wrong shelving locations for the item you are editing, based on the branch where you are logged into, not the item you are editing. This is problematic when we receive and catalog items centrally and then transport them to other libraries. Changing the item editing behaviour to get the available shelving locations based on the item's homebranch instead of the users logged in library. ---------- - DESIGN - ---------- -When loading the koha/cataloguing/additem.pl?op=edititem, check if the item's homebranch exists and load the available shelving locations for the homebranch. -After changing "Permanent location", load new shelving locations based on the homebranch using an AJAX query. ---Only touch the <option value="CART">Book Cart</option> elements to be as unintrusive as possible. -When javascript is disabled, this feature only loads the available shelving locations on page load. ----------------- - IN DISCUSSION - ----------------- -Can this feature be on by default or do we need Yet.Another.System.Preference? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |olli-antti.kivilahti@jns.fi -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 25034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25034&action=edit Bug 11676 - Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. For pageload. -Modifies the Koha::GetAuthorisedValues() to support passing a branchcode as a parameter -Modifies cataloguing/additem.pl to find the items.homebranch and pass this to the GetAuthorisedValues(). ------------- - TEST PLAN - ------------- 1. Define shelving locations for a specific branch: Go to Administration -> Authorised values -> category: LOC, Add a new value X specific to branch A, Add a new value Y specific to branch B. 2. Set your logged in library to branch C. 3. Edit an item. Set the Permanent location to branch A. Save the item. 4. Edit the item. Shelving locations has location X selectable in addition to the default ones. Set the Permanent location to branch B. Save the item. 5. Edit the item. Shelving locations has location Y selectable in addition to the default ones. Set the Permanent location to branch C. Save the item. 6. Edit the item. Shelving locations has neither Y or X selectable. Don't save. 7. Set your logged in branch to A. 8. Edit the item. Shelving locations has neither Y or X selectable. Don't save. This is how we do it! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 25035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25035&action=edit Bug 11676 - Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. Svc AJAX-wrapper. This patch provides a HTTP-interface for the C4::Koha::GetAuthorisedValues() using the existing svc web interface. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 --- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 25036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25036&action=edit Bug 11676 - Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. Javascript bits. Makes the Shelving locations automatically refresh when the "Permanent location" (homebranch) changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25034|0 |1 is obsolete| | --- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 25060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25060&action=edit Bug 11676 - Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. For pageload. -Modifies the Koha::GetAuthorisedValues() to support passing a branchcode as a parameter -Modifies cataloguing/additem.pl to find the items.homebranch and pass this to the GetAuthorisedValues(). ------------- - TEST PLAN - ------------- 1. Define shelving locations for a specific branch: Go to Administration -> Authorised values -> category: LOC, Add a new value X specific to branch A, Add a new value Y specific to branch B. 2. Set your logged in library to branch C. 3. Edit an item. Set the Permanent location to branch A. Save the item. 4. Edit the item. Shelving locations has location X selectable in addition to the default ones. Set the Permanent location to branch B. Save the item. 5. Edit the item. Shelving locations has location Y selectable in addition to the default ones. Set the Permanent location to branch C. Save the item. 6. Edit the item. Shelving locations has neither Y or X selectable. Don't save. 7. Set your logged in branch to A. 8. Edit the item. Shelving locations has neither Y or X selectable. Don't save. This is how we do it! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25035|0 |1 is obsolete| | --- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 25061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25061&action=edit Bug 11676 - Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. Svc AJAX-wrapper. This patch provides a HTTP-interface for the C4::Koha::GetAuthorisedValues() using the existing svc web interface. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25036|0 |1 is obsolete| | --- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 25062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25062&action=edit Bug 11676 - Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. Javascript bits. Makes the Shelving locations automatically refresh when the "Permanent location" (homebranch) changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25061|0 |1 is obsolete| | --- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 25064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25064&action=edit Bug 11676 - Loading shelving locations based on the item's homebranch instead of the user's logged-in branch. Svc AJAX-wrapper. This patch provides a HTTP-interface for the C4::Koha::GetAuthorisedValues() using the existing svc web interface. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 --- Comment #8 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 25065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25065&action=edit C4::Auth.pm Documentation improvement check_cookie_auth() didn't describe the content and how to use the permissions hash and I had to rummage through code to figure out how the flags are properly passed. I hope this will help the next one not to take that hit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 --- Comment #9 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 26796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26796&action=edit Bug 11676 - Loading shelving locations based on stuff. For acquisitions. Found out that there is another way of adding items, which has a different mechanism (datatables yay) of addition, so this feature enables shelving location updating in the newordere Centralized the shelving location fetching code (to koha-to-marc-mapping-api.js) to have a central place to share related features. ------------- - TEST PLAN - ------------- Same as in the first patch, but this time use the neworderempty.pl-script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 --- Comment #10 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 26965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26965&action=edit Bug 11676 - Loading shelving locations based on stuff. For acquisitions. Found out that there is another way of adding items, which has a different mechanism (datatables yay) of addition, so this feature enables shelving location updating in the newordere Centralized the shelving location fetching code (to koha-to-marc-mapping-api.js) to have a central place to share related features. ------------- - TEST PLAN - ------------- Same as in the first patch, but this time use the neworderempty.pl-script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- This patch doesn't apply with git-bz. I'm not sure if it's a simple conflict or perhaps the patches are out of order? fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11676 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- This still doesn't apply, and it is worse now. You would think that someone would have hash referenced the parameters for generate_subfield_form when they added $restrictededition. *sigh* -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org