[Bug 16092] New: Use Font Awesome Icons when deleting branch category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Bug ID: 16092 Summary: Use Font Awesome Icons when deleting branch category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: hector.hecaxmmx@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 16047, 16091 Found when signed-off bug 16091. Introduce the Font Awesome icons when delete a branch category. Also change admin/branch.pl type => 'error' to type => 'alert' to fit with wiki <https://wiki.koha-community.org/wiki/Interface_patterns#Errors_and_messages> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16047 [Bug 16047] Software error on deleting a group with no category code https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16091 [Bug 16091] Can not delete branch category not used by any library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 --- Comment #1 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 49280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49280&action=edit Bug 16092: Introduce the Font Awesome icons when delete a branch category. Also change admin/branch.pl type => 'error' to type => 'alert' to fit with wiki <https://wiki.koha-community.org/wiki/Interface_patterns#Errors_and_messages> To test: 1) Apply on top 16047 and 16091 1) Go to Admin -> Libraries and groups 2) Try to delete a library with patrons and bib items 3) See the error message in yellow 4) Try to delete a branch category/group without any library attached to it 5) Apply patch and repeat steps 1 to 4. Notice about the changes 6) Test buttons Yes, delete and No, do not delete and verify that they work as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia@hotmail.com, | |hector.hecaxmmx@gmail.com, | |oleonard@myacpl.org, | |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15784 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49280|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 49281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49281&action=edit Bug 16092: Introduce the Font Awesome icons when delete a branch category. Also change admin/branch.pl type => 'error' to type => 'alert' to fit with wiki <https://wiki.koha-community.org/wiki/Interface_patterns#Errors_and_messages> To test: 1) Apply on top 16047 and 16091 1) Go to Admin -> Libraries and groups 2) Try to delete a library with patrons and bib items 3) See the error message in yellow 4) Try to delete a branch category/group without any library attached to it 5) Apply patch and repeat steps 1 to 4. Notice about the changes 6) Test buttons Yes, delete and No, do not delete and verify that they work as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Bug 16092 depends on bug 16091, which changed state. Bug 16091 Summary: Can not delete branch category not used by any library https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16091 What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Still applies without DUPLICATE BUG 16091, the patch applies in both ways applying on top 16047 only or applying 16047 and 16015 on top.
Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging admin/branches.pl
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16015 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Use Font Awesome Icons when |Use Font Awesome Icons when |deleting branch category |deleting branch group Status|Signed Off |Patch doesn't apply --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, but this no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 16092: Introduce the Font Awesome icons when delete a branch category. fatal: sha1 information is lacking or useless (admin/branches.pl). The patch code also seems to include a lot more than the Font Awesome icon change - please correct bug title to reflect this :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49281|0 |1 is obsolete| | --- Comment #5 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 49639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49639&action=edit Bug 16092: Fix error dialog and introduce the Font Awesome icons when delete a branch category Also change admin/branch.pl type => 'error' to type => 'alert' to fit with wiki <https://wiki.koha-community.org/wiki/Interface_patterns#Errors_and_messages> To test: 1) Apply on top 16047 and 16091 1) Go to Admin -> Libraries and groups 2) Try to delete a library with patrons and bib items 3) See the error message in yellow 4) Try to delete a branch category/group without any library attached to it 5) Apply patch and repeat steps 1 to 4. Notice about the changes 6) Test buttons Yes, delete and No, do not delete and verify that they work as expected Signed-off-by: Marc Véron <veron@veron.ch> NOTE: Patch rebased and reword title according with QA comment 4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use Font Awesome Icons when |Fix error dialog and use |deleting branch group |Font Awesome Icons when | |deleting branch group Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|16091 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16091 [Bug 16091] Can not delete branch category not used by any library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49639|0 |1 is obsolete| | --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 49640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49640&action=edit Bug 16092: Fix error dialog and introduce the Font Awesome icons when delete a branch category Also change admin/branch.pl type => 'error' to type => 'alert' to fit with wiki <https://wiki.koha-community.org/wiki/Interface_patterns#Errors_and_messages> To test: 1) Go to Admin -> Libraries and groups 2) Try to delete a library with patrons and bib items 3) See the error message in yellow 4) Try to delete a branch category/group without any library attached to it 5) Apply patch and repeat steps 1 to 4. Notice about the changes 6) Test buttons Yes, delete and No, do not delete and verify that they work as expected Signed-off-by: Marc Véron <veron@veron.ch> NOTE: Patch rebased and reword title according with QA comment 4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49640|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49733&action=edit Bug 16092: Fix error dialog and introduce the Font Awesome icons when delete a branch category Also change admin/branch.pl type => 'error' to type => 'alert' to fit with wiki <https://wiki.koha-community.org/wiki/Interface_patterns#Errors_and_messages> To test: 1) Go to Admin -> Libraries and groups 2) Try to delete a library with patrons and bib items 3) See the error message in yellow 4) Try to delete a branch category/group without any library attached to it 5) Apply patch and repeat steps 1 to 4. Notice about the changes 6) Test buttons Yes, delete and No, do not delete and verify that they work as expected Signed-off-by: Marc Véron <veron@veron.ch> NOTE: Patch rebased and reword title according with QA comment 4 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16092 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org