https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26175 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26175 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 107947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107947&action=edit Bug 26175: Remove warn if undefined barcode in misc/export_records.pl When using misc/export_records.pl --deleted_barcodes if barcode is NULL you get warn : Use of uninitialized value in say at /home/koha/src/misc/export_records.pl Also exporting barcode if empty string makes no sense. Test plan : 1) Delete an item with barcode = NULL 2) Run : misc/export_records.pl --date=`date +%d/%m/%Y` --deleted_barcodes --filename=/tmp/deleted_barcodes 3) Check you se no warn "Use of uninitialized value in say ..." 4) Delete an item with barcode = '' 5) Run 2) 6) Check there is no empty line in /tmp/deleted_barcodes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26175 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26175 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108054|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108190&action=edit Bug 26175: Remove warn if undefined barcode in misc/export_records.pl When using misc/export_records.pl --deleted_barcodes if barcode is NULL you get warn : Use of uninitialized value in say at /home/koha/src/misc/export_records.pl Also exporting barcode if empty string makes no sense. Test plan : 1) Delete an item with barcode = NULL 2) Run : misc/export_records.pl --date=`date +%d/%m/%Y` --deleted_barcodes --filename=/tmp/deleted_barcodes 3) Check you se no warn "Use of uninitialized value in say ..." 4) Delete an item with barcode = '' 5) Run 2) 6) Check there is no empty line in /tmp/deleted_barcodes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26175 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- How is this --deleted_barcodes flag used? I don't understand why it is in this script. Why don't we display an empty line instead? Imagine someone using it to know the number of deleted records (wc -l). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26175 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #5)

How is this --deleted_barcodes flag used?

I don't understand why it is in this script.

Why don't we display an empty line instead? Imagine someone using it to know the number of deleted records (wc -l).

Hi, It is used to update a portal : After exporting modified/created records, we exported a list of deleted barcodes to remove items from the portal (they may not be in a modified record). Barcode is enough because other datas are fetched live via ILS-DI. An empty line does not mean anything I think. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26175 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26175 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26175 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26175 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111730&action=edit Bug 26175: (QA follow-up) Add tests for previous cashups -- You are receiving this mail because: You are watching all bug changes.