[Bug 34028] New: Two factor authentication (2FA) shows the wrong values for manual entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 Bug ID: 34028 Summary: Two factor authentication (2FA) shows the wrong values for manual entry Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org In koha-testing-docker, if you enable 2FA, you'll see the following: `To add the entry manually, provide the following details to the application on your phone. Account: Centerville Key: Centerville_koha Time based: Yes` "Account" should be "Centerville: Centerville_koha", and "Key" should be the the "secret" value. The "Account" is really just a label, but the "Key" needs to be the shared secret. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 152398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152398&action=edit Bug 34028: Fix manual entry for two factor authentication This patch changes the "Account" and "Key" display so that you can manually enter two factor authentication details into an authenticator app. The details are the same as those provided by scanning the QR code. Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=TwoFactorAuthentication 2. Change setting to "Enable" 3. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 4. Click "More" on record toolbar and choose "Manage two-factor authentication" 5. Click "Enable two-factor authentication" 6. Scan the QR code into an authenticator app and note it creates an entry called "Centerville: Centerville_koha" 7. Manually enter an entry into an authenticator app (like Google Authenticator) 7a. Add the "Account" as shown on the Koha screen 7b. Add the "Key" as shown on the Koha screen 8. Note that the entries added by QR code and manual entry have the same label and both were accepted by the authenticator app -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 31119 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 30586 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 [Bug 28786] Two-factor authentication for staff client - TOTP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152398|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 152465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152465&action=edit Bug 34028: Fix manual entry for two factor authentication This patch changes the "Account" and "Key" display so that you can manually enter two factor authentication details into an authenticator app. The details are the same as those provided by scanning the QR code. Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=TwoFactorAuthentication 2. Change setting to "Enable" 3. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 4. Click "More" on record toolbar and choose "Manage two-factor authentication" 5. Click "Enable two-factor authentication" 6. Scan the QR code into an authenticator app and note it creates an entry called "Centerville: Centerville_koha" 7. Manually enter an entry into an authenticator app (like Google Authenticator) 7a. Add the "Account" as shown on the Koha screen 7b. Add the "Key" as shown on the Koha screen 8. Note that the entries added by QR code and manual entry have the same label and both were accepted by the authenticator app Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the details release notes| |displayed for manually | |entering two-factor | |authentication (2FA) | |details into a 2FA | |application (when enabling | |2FA). Currently, the wrong | |information is displayed - | |so you can't successfully | |add the account manually to | |your 2FA application. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152465|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 152473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152473&action=edit Bug 34028: Fix manual entry for two factor authentication This patch changes the "Account" and "Key" display so that you can manually enter two factor authentication details into an authenticator app. The details are the same as those provided by scanning the QR code. Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=TwoFactorAuthentication 2. Change setting to "Enable" 3. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 4. Click "More" on record toolbar and choose "Manage two-factor authentication" 5. Click "Enable two-factor authentication" 6. Scan the QR code into an authenticator app and note it creates an entry called "Centerville: Centerville_koha" 7. Manually enter an entry into an authenticator app (like Google Authenticator) 7a. Add the "Account" as shown on the Koha screen 7b. Add the "Key" as shown on the Koha screen 8. Note that the entries added by QR code and manual entry have the same label and both were accepted by the authenticator app Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Solid fix, works as expected. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.01 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Key is missing on the auth screen: https://snipboard.io/PlARWt.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153009&action=edit Bug 34028: Show the secret when registering from the auth screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Waiting on follow-up to be pushed before we consider this for 22.11.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate, | |rel_23_05_candidate CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- @Frido can you please take a look at the follow-up for 23.05.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Pedro Amorim from comment #13)
@Frido can you please take a look at the follow-up for 23.05.x?
Followup pushed to 23.05.x for 23.05.03 : Bug 34028: Show the secret when registering from the auth screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.01 |23.11.00,23.05.01,22.11.09 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |rel_22_11_candidate, | |rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org