[Bug 22697] New: Reindent catalogue/result.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697 Bug ID: 22697 Summary: Reindent catalogue/result.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 22695 Target Milestone: --- The template for catalog search results in the staff client would be much more readable if it were indented consistently. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 [Bug 22695] Remove non-XSLT search results view from the staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87924&action=edit Bug 22697: Reindent catalogue/result.tt This patch reindents the template for staff client catalogue search results. The only non-whitespace changes are comments to help identify closing tags and template directives. To test, apply the patch and perform a catalog search in the staff client. The results should look correct. The diff using the '-w' flag to ignore whitespace should highlight only moved lines and added comments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87924|0 |1 is obsolete| | --- Comment #2 from Michal Denar <black23@gmail.com> --- Created attachment 87947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87947&action=edit Bug 22697: Reindent catalogue/result.tt This patch reindents the template for staff client catalogue search results. The only non-whitespace changes are comments to help identify closing tags and template directives. To test, apply the patch and perform a catalog search in the staff client. The results should look correct. The diff using the '-w' flag to ignore whitespace should highlight only moved lines and added comments. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87947|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88131&action=edit Bug 22697: Reindent catalogue/result.tt This patch reindents the template for staff client catalogue search results. The only non-whitespace changes are comments to help identify closing tags and template directives. To test, apply the patch and perform a catalog search in the staff client. The results should look correct. The diff using the '-w' flag to ignore whitespace should highlight only moved lines and added comments. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=22679 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED Version(s)| |19.05.00 released in| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697 Bug 22697 depends on bug 22695, which changed state. Bug 22695 Summary: Remove non-XSLT search results view from the staff client https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org