[Bug 7329] New: The "undo import into catalog" command deletes items onloan without checking
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Bug #: 7329 Summary: The "undo import into catalog" command deletes items onloan without checking Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 - low Component: MARC Bibliographic record staging/import AssignedTo: gmcharlt@gmail.com ReportedBy: christophe.croullebois@biblibre.com QAContact: ian.walls@bywatersolutions.com To test, stage MARC records and import with items created. Next, check out one or more items. Then undo import into catalog, and you'll see that record and item(s) will be deleted. I have made a patch that checks the "on loan" status before deleting item, and do noting in this case, so the record can't be deleted due to existing item. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |christophe.croullebois@bibl | |ibre.com --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-12-07 11:08:43 UTC --- Created attachment 6635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6635 new proposed patch thx for testing -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois@bibl | |ibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-16 07:23:12 UTC --- I noticed 2 some problems for this patch: 1) I had one item checked out and 1 available item with missing home and holding branch (not sure that was the reason). Both were not removed from the catalog. 2) After 'undoing' the import the bib# for the 2 records remaining in the catalog due to errors were gone from the list. 3) I reimported and the bib# were still missing. 4) I undid the import again and now it reports to have removed all records. My 2 problematic records show up in the list as reverted, but they are still available in my catalog. I think 3) and 4) are perhaps side effects of 2)? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-16 07:23:37 UTC --- Created attachment 6829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6829 screenshot after step 1) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Blocks| |8149 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 --- Comment #4 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 10070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10070&action=edit Bug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch table, if items are not deleted beacause on loan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |sophie.meynieux@biblibre.co | |m --- Comment #5 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- First patch was ok but uncomplete. This follow-up keep tracks in import tool itself, that some biblios remain in the catalog because corresponding items are issued and can't be deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10070|0 |1 is obsolete| | --- Comment #6 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 10125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10125&action=edit Bug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch table, if items are not deleted because they are issued. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 --- Comment #7 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Followup corrected to take care of biblios with several items -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10070|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am ready to sign-off on the first three patches, but there is a small thing I have to note. If you have a record with more than one item and one of the items is checked out, undoing the import will delete all items except for the checked out one. So this is perfectly correct. However, if you repeat the import after that, the additional items do not get readded to the record. I think this is only a very small issue and the import works a lot nicer with the patches. so signing off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6635|0 |1 is obsolete| | Attachment #10070|0 |1 is obsolete| | Attachment #10125|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10155&action=edit [SIGNED-OFF] Bug 7329: Items onloan are deleted when undoing import into catalog this patch checks the "on loan" and "reserved" status before deleting item, and do noting in this case, so the record can't be deleted due to existing item. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10156&action=edit [SIGNED-OFF] Bug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch table, if items are not deleted beacause on loan. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10157&action=edit [SIGNED-OFF] Bug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch table, if items are not deleted because they are issued. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 --- Comment #12 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Katrin ; the problem is that the record is not totally reverted (one item left) and not totally imported (some items have been deleted). Should we add a status for this situation ("partially reverted" or "partially imported" ) ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it would be nice, but perhaps could be a different bug and enhancement :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Ian Walls <koha.sekjal@gmail.com> --- Patch 1: uses DelItemCheck instead of DelItem, with logic to handle when an item cannot be deleted. Good use of existing subroutine. Passed QA. Patch 2 + 3: Work together to prevent the biblio from being NULLifed if the item isn't deleted. SQL only change, with a comment, marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|rel_3_6 |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- No string changes, pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org