[Bug 15801] New: Move the framework related code to Koha::BiblioFramework[s] - part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Bug ID: 15801 Summary: Move the framework related code to Koha::BiblioFramework[s] - part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Blocks: 15779 Three subroutines from the C4::Koha module deal with biblio frameworks and could be replaced or moved to Koha::BiblioFramework: - getframeworks - getframeworkinfo - GetFrameworksLoop Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14889 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47923&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::GetFrameworksLoop The C4::Koha::GetFrameworksLoop retrieves biblio frameworks and returns them ordered by the description (frameworktext). If a parameter is passed, a selected flag is set. The selection of the options should be done on the template side. These 2 calls can be replaced with Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); Test plan: 1/ Go on a Labeled MARC biblio view (catalogue/labeledMARCdetail.pl) You should see a dropdown list with the biblio frameworks. The framework of the record should be selected by default 2/ Create a sql report using the biblio_framework parameter, something like: SELECT COUNT(*) FROM biblio WHERE frameworkcode=<<framework|biblio_framework>> Save and execute the report. You should get a dropdown list with the framework list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47924&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks C4::Koha::getframeworks returned a hashref of biblio frameworks. It was mainly used to generate the dropdown list of frameworks. The scripts modified in this patch did not necessary order the element by description (frameworktext), the displays were not consistent from one screen to another. Using the same search method everywhere: Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); We will know always get the framework in the same order. Test plan: Following the different pages modified by this patch, and make sure the frameworks are displayed correctly in the dropdown list: 1/ acqui/z3950_search.pl - Create an order from an external source. 2/ admin/fieldmapping.pl - Define some mappings keyword / MARC field 3/ admin/marctagstructure.pl - On the MARC frameworks admin page, select another framework than the default one and click on the 'Search' button 4/ catalogue/MARCdetail.pl - On the MARC defail page, change the framework you want to use to display the record 5/ cataloguing/addbiblio.pl - Add or edit a biblio record, change its framework. When editing, the framework of the record should be selected by default 6/ cataloguing/addbooks.pl - Go on the cataloguing home page and click on the "New record" button. You should see all the frameworks 7/ cataloguing/merge.pl - Select 2 biblio records to merge. On the first step (select the merge reference), you should be allowed to select the framework to use. 8/ tools/inventory.pl - On the inventory page, the "Item statuses" part should be populated as before this patch 9/ tools/manage-marc-import.pl - Stage records for import. Before importing them into the catalog, you should see the framework dropdown list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47925&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo This was the "Get" subroutine for the framework, it can be easily replaced with a call to the Koha::BiblioFrameworks->find method. This patch also replaces some confusing wordings (framework vs frameworkcode). Test plan: On the circulation home page, you should get a warning message if you don't have the FA (Fast cataloguing) framework Note that the admin/marctagstructure.pl has already been tested in the previous patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- To test this patch, makes sure you have the last patch from bug 14889 applied: Bug 14889: Fix typo in Koha/BiblioFrameworks.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15803 [Bug 15803] Koha::AuthorisedValues - Remove GetAuthorisedValueCategories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47923|0 |1 is obsolete| | Attachment #47924|0 |1 is obsolete| | Attachment #47925|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48938&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::GetFrameworksLoop The C4::Koha::GetFrameworksLoop retrieves biblio frameworks and returns them ordered by the description (frameworktext). If a parameter is passed, a selected flag is set. The selection of the options should be done on the template side. These 2 calls can be replaced with Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); Test plan: 1/ Go on a Labeled MARC biblio view (catalogue/labeledMARCdetail.pl) You should see a dropdown list with the biblio frameworks. The framework of the record should be selected by default 2/ Create a sql report using the biblio_framework parameter, something like: SELECT COUNT(*) FROM biblio WHERE frameworkcode=<<framework|biblio_framework>> Save and execute the report. You should get a dropdown list with the framework list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48939&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks C4::Koha::getframeworks returned a hashref of biblio frameworks. It was mainly used to generate the dropdown list of frameworks. The scripts modified in this patch did not necessary order the element by description (frameworktext), the displays were not consistent from one screen to another. Using the same search method everywhere: Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); We will know always get the framework in the same order. Test plan: Following the different pages modified by this patch, and make sure the frameworks are displayed correctly in the dropdown list: 1/ acqui/z3950_search.pl - Create an order from an external source. 2/ admin/fieldmapping.pl - Define some mappings keyword / MARC field 3/ admin/marctagstructure.pl - On the MARC frameworks admin page, select another framework than the default one and click on the 'Search' button 4/ catalogue/MARCdetail.pl - On the MARC defail page, change the framework you want to use to display the record 5/ cataloguing/addbiblio.pl - Add or edit a biblio record, change its framework. When editing, the framework of the record should be selected by default 6/ cataloguing/addbooks.pl - Go on the cataloguing home page and click on the "New record" button. You should see all the frameworks 7/ cataloguing/merge.pl - Select 2 biblio records to merge. On the first step (select the merge reference), you should be allowed to select the framework to use. 8/ tools/inventory.pl - On the inventory page, the "Item statuses" part should be populated as before this patch 9/ tools/manage-marc-import.pl - Stage records for import. Before importing them into the catalog, you should see the framework dropdown list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48940&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo This was the "Get" subroutine for the framework, it can be easily replaced with a call to the Koha::BiblioFrameworks->find method. This patch also replaces some confusing wordings (framework vs frameworkcode). Test plan: On the circulation home page, you should get a warning message if you don't have the FA (Fast cataloguing) framework Note that the admin/marctagstructure.pl has already been tested in the previous patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mirko@abunchofthings.net --- Comment #9 from Mirko Tietgen <mirko@abunchofthings.net> --- Can't apply.
fatal: sha1 information is lacking or useless (C4/Koha.pm). Dem Repository fehlen notwendige Blobs um auf einen 3-Wege-Merge zurückzufallen. Kann nicht zu 3-Wege-Merge zurückfallen. Anwendung des Patches fehlgeschlagen bei 0001 Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48940|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50259&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo This was the "Get" subroutine for the framework, it can be easily replaced with a call to the Koha::BiblioFrameworks->find method. This patch also replaces some confusing wordings (framework vs frameworkcode). Test plan: On the circulation home page, you should get a warning message if you don't have the FA (Fast cataloguing) framework Note that the admin/marctagstructure.pl has already been tested in the previous patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Sorry, does not apply again. I promise to test and sign. Applying: Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks fatal: sha1 information is lacking or useless (C4/Koha.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48938|0 |1 is obsolete| | Attachment #48939|0 |1 is obsolete| | Attachment #50259|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51385&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::GetFrameworksLoop The C4::Koha::GetFrameworksLoop retrieves biblio frameworks and returns them ordered by the description (frameworktext). If a parameter is passed, a selected flag is set. The selection of the options should be done on the template side. These 2 calls can be replaced with Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); Test plan: 1/ Go on a Labeled MARC biblio view (catalogue/labeledMARCdetail.pl) You should see a dropdown list with the biblio frameworks. The framework of the record should be selected by default 2/ Create a sql report using the biblio_framework parameter, something like: SELECT COUNT(*) FROM biblio WHERE frameworkcode=<<framework|biblio_framework>> Save and execute the report. You should get a dropdown list with the framework list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51386&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks C4::Koha::getframeworks returned a hashref of biblio frameworks. It was mainly used to generate the dropdown list of frameworks. The scripts modified in this patch did not necessary order the element by description (frameworktext), the displays were not consistent from one screen to another. Using the same search method everywhere: Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); We will know always get the framework in the same order. Test plan: Following the different pages modified by this patch, and make sure the frameworks are displayed correctly in the dropdown list: 1/ acqui/z3950_search.pl - Create an order from an external source. 2/ admin/fieldmapping.pl - Define some mappings keyword / MARC field 3/ admin/marctagstructure.pl - On the MARC frameworks admin page, select another framework than the default one and click on the 'Search' button 4/ catalogue/MARCdetail.pl - On the MARC defail page, change the framework you want to use to display the record 5/ cataloguing/addbiblio.pl - Add or edit a biblio record, change its framework. When editing, the framework of the record should be selected by default 6/ cataloguing/addbooks.pl - Go on the cataloguing home page and click on the "New record" button. You should see all the frameworks 7/ cataloguing/merge.pl - Select 2 biblio records to merge. On the first step (select the merge reference), you should be allowed to select the framework to use. 8/ tools/inventory.pl - On the inventory page, the "Item statuses" part should be populated as before this patch 9/ tools/manage-marc-import.pl - Stage records for import. Before importing them into the catalog, you should see the framework dropdown list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51387&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo This was the "Get" subroutine for the framework, it can be easily replaced with a call to the Koha::BiblioFrameworks->find method. This patch also replaces some confusing wordings (framework vs frameworkcode). Test plan: On the circulation home page, you should get a warning message if you don't have the FA (Fast cataloguing) framework Note that the admin/marctagstructure.pl has already been tested in the previous patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi Jonathan 1) Small qa fail FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt FAIL forbidden patterns forbidden pattern: tab char (line 66) 2) Bad: Can't change framework on edit, think that this code needs change koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt line 495+ [% FOREACH frameworkcodeloo IN frameworkcodeloop %] 3) Test plan for third patch: don't get a warning, only a link to fast catalog if FA is present and have right permissions. All other parts of all test plans works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51387|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51426&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo This was the "Get" subroutine for the framework, it can be easily replaced with a call to the Koha::BiblioFrameworks->find method. This patch also replaces some confusing wordings (framework vs frameworkcode). Test plan: On the circulation home page, you should see a "Fast cataloguing" link if the FA framework exists. Note that the admin/marctagstructure.pl has already been tested in the previous patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51427&action=edit Bug 15801: minor fixes - Fix a tab - Fix a variable name in a template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Bernardo Gonzalez Kriegel from comment #15)
Hi Jonathan
Hi Bernardo, Thanks for testing :)
1) Small qa fail FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt FAIL forbidden patterns forbidden pattern: tab char (line 66)
Fixed.
2) Bad: Can't change framework on edit, think that this code needs change
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
line 495+ [% FOREACH frameworkcodeloo IN frameworkcodeloop %]
Fixed as well.
3) Test plan for third patch: don't get a warning, only a link to fast catalog if FA is present and have right permissions.
I have updated the test plan, actually you should see a "Fast cataloguing" like if the FA framework exists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51385|0 |1 is obsolete| | --- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51432&action=edit [SIGNED-OFF] Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::GetFrameworksLoop The C4::Koha::GetFrameworksLoop retrieves biblio frameworks and returns them ordered by the description (frameworktext). If a parameter is passed, a selected flag is set. The selection of the options should be done on the template side. These 2 calls can be replaced with Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); Test plan: 1/ Go on a Labeled MARC biblio view (catalogue/labeledMARCdetail.pl) You should see a dropdown list with the biblio frameworks. The framework of the record should be selected by default 2/ Create a sql report using the biblio_framework parameter, something like: SELECT COUNT(*) FROM biblio WHERE frameworkcode=<<framework|biblio_framework>> Save and execute the report. You should get a dropdown list with the framework list. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Both dropdowns Ok No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51386|0 |1 is obsolete| | --- Comment #20 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51433&action=edit [SIGNED-OFF] Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks C4::Koha::getframeworks returned a hashref of biblio frameworks. It was mainly used to generate the dropdown list of frameworks. The scripts modified in this patch did not necessary order the element by description (frameworktext), the displays were not consistent from one screen to another. Using the same search method everywhere: Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); We will know always get the framework in the same order. Test plan: Following the different pages modified by this patch, and make sure the frameworks are displayed correctly in the dropdown list: 1/ acqui/z3950_search.pl - Create an order from an external source. 2/ admin/fieldmapping.pl - Define some mappings keyword / MARC field 3/ admin/marctagstructure.pl - On the MARC frameworks admin page, select another framework than the default one and click on the 'Search' button 4/ catalogue/MARCdetail.pl - On the MARC defail page, change the framework you want to use to display the record 5/ cataloguing/addbiblio.pl - Add or edit a biblio record, change its framework. When editing, the framework of the record should be selected by default 6/ cataloguing/addbooks.pl - Go on the cataloguing home page and click on the "New record" button. You should see all the frameworks 7/ cataloguing/merge.pl - Select 2 biblio records to merge. On the first step (select the merge reference), you should be allowed to select the framework to use. 8/ tools/inventory.pl - On the inventory page, the "Item statuses" part should be populated as before this patch 9/ tools/manage-marc-import.pl - Stage records for import. Before importing them into the catalog, you should see the framework dropdown list. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works Ok. No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51426|0 |1 is obsolete| | --- Comment #21 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51434&action=edit [SIGNED-OFF] Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo This was the "Get" subroutine for the framework, it can be easily replaced with a call to the Koha::BiblioFrameworks->find method. This patch also replaces some confusing wordings (framework vs frameworkcode). Test plan: On the circulation home page, you should see a "Fast cataloguing" link if the FA framework exists. Note that the admin/marctagstructure.pl has already been tested in the previous patch. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Link pops Ok No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51427|0 |1 is obsolete| | --- Comment #22 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51435&action=edit [SIGNED-OFF] Bug 15801: minor fixes - Fix a tab - Fix a variable name in a template Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> With all patches applied no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16792 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16792 [Bug 16792] Add Font Awesome Icon and mini button to Keyword to MARC mapping section -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51432|0 |1 is obsolete| | Attachment #51433|0 |1 is obsolete| | Attachment #51434|0 |1 is obsolete| | Attachment #51435|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54348&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::GetFrameworksLoop The C4::Koha::GetFrameworksLoop retrieves biblio frameworks and returns them ordered by the description (frameworktext). If a parameter is passed, a selected flag is set. The selection of the options should be done on the template side. These 2 calls can be replaced with Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); Test plan: 1/ Go on a Labeled MARC biblio view (catalogue/labeledMARCdetail.pl) You should see a dropdown list with the biblio frameworks. The framework of the record should be selected by default 2/ Create a sql report using the biblio_framework parameter, something like: SELECT COUNT(*) FROM biblio WHERE frameworkcode=<<framework|biblio_framework>> Save and execute the report. You should get a dropdown list with the framework list. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Both dropdowns Ok No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54349&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks C4::Koha::getframeworks returned a hashref of biblio frameworks. It was mainly used to generate the dropdown list of frameworks. The scripts modified in this patch did not necessary order the element by description (frameworktext), the displays were not consistent from one screen to another. Using the same search method everywhere: Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); We will know always get the framework in the same order. Test plan: Following the different pages modified by this patch, and make sure the frameworks are displayed correctly in the dropdown list: 1/ acqui/z3950_search.pl - Create an order from an external source. 2/ admin/fieldmapping.pl - Define some mappings keyword / MARC field 3/ admin/marctagstructure.pl - On the MARC frameworks admin page, select another framework than the default one and click on the 'Search' button 4/ catalogue/MARCdetail.pl - On the MARC defail page, change the framework you want to use to display the record 5/ cataloguing/addbiblio.pl - Add or edit a biblio record, change its framework. When editing, the framework of the record should be selected by default 6/ cataloguing/addbooks.pl - Go on the cataloguing home page and click on the "New record" button. You should see all the frameworks 7/ cataloguing/merge.pl - Select 2 biblio records to merge. On the first step (select the merge reference), you should be allowed to select the framework to use. 8/ tools/inventory.pl - On the inventory page, the "Item statuses" part should be populated as before this patch 9/ tools/manage-marc-import.pl - Stage records for import. Before importing them into the catalog, you should see the framework dropdown list. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works Ok. No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54350&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo This was the "Get" subroutine for the framework, it can be easily replaced with a call to the Koha::BiblioFrameworks->find method. This patch also replaces some confusing wordings (framework vs frameworkcode). Test plan: On the circulation home page, you should see a "Fast cataloguing" link if the FA framework exists. Note that the admin/marctagstructure.pl has already been tested in the previous patch. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Link pops Ok No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54351&action=edit Bug 15801: minor fixes - Fix a tab - Fix a variable name in a template Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> With all patches applied no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- A bit too many conflicts for me to fix - can you please take a look, Jonathan? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54348|0 |1 is obsolete| | Attachment #54349|0 |1 is obsolete| | Attachment #54350|0 |1 is obsolete| | Attachment #54351|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55688&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::GetFrameworksLoop The C4::Koha::GetFrameworksLoop retrieves biblio frameworks and returns them ordered by the description (frameworktext). If a parameter is passed, a selected flag is set. The selection of the options should be done on the template side. These 2 calls can be replaced with Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); Test plan: 1/ Go on a Labeled MARC biblio view (catalogue/labeledMARCdetail.pl) You should see a dropdown list with the biblio frameworks. The framework of the record should be selected by default 2/ Create a sql report using the biblio_framework parameter, something like: SELECT COUNT(*) FROM biblio WHERE frameworkcode=<<framework|biblio_framework>> Save and execute the report. You should get a dropdown list with the framework list. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Both dropdowns Ok No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55689&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks C4::Koha::getframeworks returned a hashref of biblio frameworks. It was mainly used to generate the dropdown list of frameworks. The scripts modified in this patch did not necessary order the element by description (frameworktext), the displays were not consistent from one screen to another. Using the same search method everywhere: Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); We will know always get the framework in the same order. Test plan: Following the different pages modified by this patch, and make sure the frameworks are displayed correctly in the dropdown list: 1/ acqui/z3950_search.pl - Create an order from an external source. 2/ admin/fieldmapping.pl - Define some mappings keyword / MARC field 3/ admin/marctagstructure.pl - On the MARC frameworks admin page, select another framework than the default one and click on the 'Search' button 4/ catalogue/MARCdetail.pl - On the MARC defail page, change the framework you want to use to display the record 5/ cataloguing/addbiblio.pl - Add or edit a biblio record, change its framework. When editing, the framework of the record should be selected by default 6/ cataloguing/addbooks.pl - Go on the cataloguing home page and click on the "New record" button. You should see all the frameworks 7/ cataloguing/merge.pl - Select 2 biblio records to merge. On the first step (select the merge reference), you should be allowed to select the framework to use. 8/ tools/inventory.pl - On the inventory page, the "Item statuses" part should be populated as before this patch 9/ tools/manage-marc-import.pl - Stage records for import. Before importing them into the catalog, you should see the framework dropdown list. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works Ok. No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55690&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo This was the "Get" subroutine for the framework, it can be easily replaced with a call to the Koha::BiblioFrameworks->find method. This patch also replaces some confusing wordings (framework vs frameworkcode). Test plan: On the circulation home page, you should see a "Fast cataloguing" link if the FA framework exists. Note that the admin/marctagstructure.pl has already been tested in the previous patch. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Link pops Ok No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55691&action=edit Bug 15801: minor fixes - Fix a tab - Fix a variable name in a template Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> With all patches applied no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55688|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 56452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56452&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::GetFrameworksLoop The C4::Koha::GetFrameworksLoop retrieves biblio frameworks and returns them ordered by the description (frameworktext). If a parameter is passed, a selected flag is set. The selection of the options should be done on the template side. These 2 calls can be replaced with Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); Test plan: 1/ Go on a Labeled MARC biblio view (catalogue/labeledMARCdetail.pl) You should see a dropdown list with the biblio frameworks. The framework of the record should be selected by default 2/ Create a sql report using the biblio_framework parameter, something like: SELECT COUNT(*) FROM biblio WHERE frameworkcode=<<framework|biblio_framework>> Save and execute the report. You should get a dropdown list with the framework list. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Both dropdowns Ok No errors Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55689|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 56453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56453&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks C4::Koha::getframeworks returned a hashref of biblio frameworks. It was mainly used to generate the dropdown list of frameworks. The scripts modified in this patch did not necessary order the element by description (frameworktext), the displays were not consistent from one screen to another. Using the same search method everywhere: Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); We will know always get the framework in the same order. Test plan: Following the different pages modified by this patch, and make sure the frameworks are displayed correctly in the dropdown list: 1/ acqui/z3950_search.pl - Create an order from an external source. 2/ admin/fieldmapping.pl - Define some mappings keyword / MARC field 3/ admin/marctagstructure.pl - On the MARC frameworks admin page, select another framework than the default one and click on the 'Search' button 4/ catalogue/MARCdetail.pl - On the MARC defail page, change the framework you want to use to display the record 5/ cataloguing/addbiblio.pl - Add or edit a biblio record, change its framework. When editing, the framework of the record should be selected by default 6/ cataloguing/addbooks.pl - Go on the cataloguing home page and click on the "New record" button. You should see all the frameworks 7/ cataloguing/merge.pl - Select 2 biblio records to merge. On the first step (select the merge reference), you should be allowed to select the framework to use. 8/ tools/inventory.pl - On the inventory page, the "Item statuses" part should be populated as before this patch 9/ tools/manage-marc-import.pl - Stage records for import. Before importing them into the catalog, you should see the framework dropdown list. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works Ok. No errors Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55690|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 56454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56454&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo This was the "Get" subroutine for the framework, it can be easily replaced with a call to the Koha::BiblioFrameworks->find method. This patch also replaces some confusing wordings (framework vs frameworkcode). Test plan: On the circulation home page, you should see a "Fast cataloguing" link if the FA framework exists. Note that the admin/marctagstructure.pl has already been tested in the previous patch. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Link pops Ok No errors Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55691|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 56455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56455&action=edit Bug 15801: minor fixes - Fix a tab - Fix a variable name in a template Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> With all patches applied no errors. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56452|0 |1 is obsolete| | Attachment #56453|0 |1 is obsolete| | Attachment #56454|0 |1 is obsolete| | Attachment #56455|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56766&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::GetFrameworksLoop The C4::Koha::GetFrameworksLoop retrieves biblio frameworks and returns them ordered by the description (frameworktext). If a parameter is passed, a selected flag is set. The selection of the options should be done on the template side. These 2 calls can be replaced with Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); Test plan: 1/ Go on a Labeled MARC biblio view (catalogue/labeledMARCdetail.pl) You should see a dropdown list with the biblio frameworks. The framework of the record should be selected by default 2/ Create a sql report using the biblio_framework parameter, something like: SELECT COUNT(*) FROM biblio WHERE frameworkcode=<<framework|biblio_framework>> Save and execute the report. You should get a dropdown list with the framework list. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Both dropdowns Ok No errors Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56767&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks C4::Koha::getframeworks returned a hashref of biblio frameworks. It was mainly used to generate the dropdown list of frameworks. The scripts modified in this patch did not necessary order the element by description (frameworktext), the displays were not consistent from one screen to another. Using the same search method everywhere: Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); We will know always get the framework in the same order. Test plan: Following the different pages modified by this patch, and make sure the frameworks are displayed correctly in the dropdown list: 1/ acqui/z3950_search.pl - Create an order from an external source. 2/ admin/fieldmapping.pl - Define some mappings keyword / MARC field 3/ admin/marctagstructure.pl - On the MARC frameworks admin page, select another framework than the default one and click on the 'Search' button 4/ catalogue/MARCdetail.pl - On the MARC defail page, change the framework you want to use to display the record 5/ cataloguing/addbiblio.pl - Add or edit a biblio record, change its framework. When editing, the framework of the record should be selected by default 6/ cataloguing/addbooks.pl - Go on the cataloguing home page and click on the "New record" button. You should see all the frameworks 7/ cataloguing/merge.pl - Select 2 biblio records to merge. On the first step (select the merge reference), you should be allowed to select the framework to use. 8/ tools/inventory.pl - On the inventory page, the "Item statuses" part should be populated as before this patch 9/ tools/manage-marc-import.pl - Stage records for import. Before importing them into the catalog, you should see the framework dropdown list. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works Ok. No errors Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56768&action=edit Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo This was the "Get" subroutine for the framework, it can be easily replaced with a call to the Koha::BiblioFrameworks->find method. This patch also replaces some confusing wordings (framework vs frameworkcode). Test plan: On the circulation home page, you should see a "Fast cataloguing" link if the FA framework exists. Note that the admin/marctagstructure.pl has already been tested in the previous patch. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Link pops Ok No errors Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56769&action=edit Bug 15801: minor fixes - Fix a tab - Fix a variable name in a template Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> With all patches applied no errors. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19372 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 [Bug 19372] Selecting MARC framework doesn't work when adding to basket from an external source -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org