[Bug 18420] New: t/dbdependent/Budgets.t fails without patron category 'S'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Bug ID: 18420 Summary: t/dbdependent/Budgets.t fails without patron category 'S' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: veron@veron.ch QA Contact: gmcharlt@gmail.com If no patron category 'S' is defined, t/dbdependent/Budgets.t fails. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17855 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|t/dbdependent/Budgets.t |Some tests fail without |fails without patron |patron category 'S' |category 'S' | --- Comment #1 from Marc Véron <veron@veron.ch> --- To reproduce make sure you have no category type 'S' defined but for example 'ST' instead. Failing: t/db_dependent/Budgets.t *) line 583 t/db_dependent/Passwordrecovery.t *) line 55 t/db_dependent/Members.t *) line 53 *) Test scipts with line"my $categorycode = 'S'; Passing: t/db_dependent/Suggestions.t lines 70 and following create a category 'S' if it does not exist. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- We should use TestBuilder here to create the categories we need. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62090&action=edit Bug 18420: Fix Budgets.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Budgets.t should return green, even if no categories.categorycode 'S' exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62091&action=edit Bug 18420: Fix Passwordrecovery.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Passwordrecovery.t should return green, even if no categories.categorycode 'S' exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62092&action=edit Bug 18420: Fix Members.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Members.t should return green, even if no categories.categorycode 'S' exists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62093&action=edit Bug 18420: Use TestBuilder to create a patron category in Suggestions.t No need to do it that way, let's use TestBuilder. Test plan: prove t/db_dependent/Suggestions.t should still return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|chris@bigballofwax.co.nz |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There are much more left. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62095&action=edit Bug 18420: Do not use 'S' as patron category code in other tests Test plan: prove all these tests, they must all pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #9 from Marc Véron <veron@veron.ch> --- Problem with: $ prove t/db_dependent/Acquisition/OrderUsers.t t/db_dependent/Acquisition/OrderUsers.t .. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`aqorders`, CONSTRAINT `aqorders_currency` FOREIGN KEY (`currency`) REFERENCES `currency` (`currency`) ON DELETE SET NULL ON UPDATE SET NULL) [for Statement "INSERT INTO `aqorders` ( `basketno`, `biblionumber`, `budget_id`, `currency`, `ecost`, `entrydate`, `ordernumber`, `orderstatus`, `quantity`, `quantityreceived`, `rrp`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='7', 1='15', 2='51', 3='EUR', 4=10, 5='01-01-2014', 6=undef, 7=1, 8=2, 9=0, 10=10] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`aqorders`, CONSTRAINT `aqorders_currency` FOREIGN KEY (`currency`) REFERENCES `currency` (`currency`) ON DELETE SET NULL ON UPDATE SET NULL) at /home/marc/koha/Koha/Acquisition/Order.pm line 50 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #10 from Marc Véron <veron@veron.ch> --- Problem with: prove t/db_dependent/Holds/LocalHoldsPriority.t t/db_dependent/Holds/LocalHoldsPriority.t .. 1/6 Odd number of elements in anonymous hash at t/db_dependent/Holds/LocalHoldsPriority.t line 60. Odd number of elements in anonymous hash at t/db_dependent/Holds/LocalHoldsPriority.t line 60. Odd number of elements in anonymous hash at t/db_dependent/Holds/LocalHoldsPriority.t line 60. Odd number of elements in anonymous hash at t/db_dependent/Holds/LocalHoldsPriority.t line 60. Odd number of elements in anonymous hash at t/db_dependent/Holds/LocalHoldsPriority.t line 60. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`reserves`, CONSTRAINT `reserves_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `reserves` ( `biblionumber`, `branchcode`, `expirationdate`, `found`, `itemnumber`, `itemtype`, `priority`, `reservedate`, `reservenotes`, `waitingdate`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='45', 1='B', 2=undef, 3=undef, 4=undef, 5=undef, 6=1, 7='2017-04-12', 8='', 9=undef] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`reserves`, CONSTRAINT `reserves_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE) at /home/marc/koha/Koha/Object.pm line 121 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62095|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62115&action=edit Bug 18420: Do not use 'S' as patron category code in other tests Test plan: prove all these tests, they must all pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- t/db_dependent/Acquisition/OrderUsers.t passes for me. Does it pass for you on master? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #13 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #12)
t/db_dependent/Acquisition/OrderUsers.t passes for me. Does it pass for you on master?
I tested on a fresh install I made when testing the onboarding tool. Ahh, fails both with and without patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #14 from Marc Véron <veron@veron.ch> --- (In reply to Marc Véron from comment #10)
Problem with: prove t/db_dependent/Holds/LocalHoldsPriority.t (...)
Test passes OK with newest patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #15 from Marc Véron <veron@veron.ch> --- (In reply to Marc Véron from comment #13)
(In reply to Jonathan Druart from comment #12)
t/db_dependent/Acquisition/OrderUsers.t passes for me. Does it pass for you on master?
I tested on a fresh install I made when testing the onboarding tool.
Ahh, fails both with and without patches.
It seemed that the failing test did not roll back the database, so I restored original VM with install mentioned above. OK, found: t/db_dependent/Acquisition/OrderUsers.t line 51 uses EUR as currency but currencies were not yet defined. Applied patches, created currency EUR, prove t/db_dependent/Acquisition/OrderUsers.t, turns green. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- t/db_dependent/Budgets.t (Wstat: 2304 Tests: 142 Failed: 9) Failed tests: 30, 44-50, 60 Non-zero exit status: 9 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62118&action=edit Bug 18420: Replace hardcoded EUR in OrderUsers.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #16)
t/db_dependent/Budgets.t (Wstat: 2304 Tests: 142 Failed: 9) Failed tests: 30, 44-50, 60 Non-zero exit status: 9
t/db_dependent/Budgets.t .. 1/142 DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_master`.`vendor_edi_accounts`, CONSTRAINT `vfk_shipment_budget` FOREIGN KEY (`shipment_budget`) REFERENCES `aqbudgets` (`budget_id`)) [for Statement "DELETE FROM aqbudgets"] at t/db_dependent/Budgets.t line 25. Obviously, this problem also exists without these patches.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #19 from Marc Véron <veron@veron.ch> --- Re-testing on current master 16.12.00.024 Database dropped and recreated. Run through install, mandatory data only. No user, library etc. created. Applied patches Restart plack Testing prove t/db_dependent/Budgets.t OK prove t/db_dependent/Passwordrecovery.t FAIL (branchcode undefined) prove t/db_dependent/Members.t OK prove t/db_dependent/Suggestions.t OK prove t/db_dependent/Acquisition/OrderUsers.t OK prove t/db_dependent/Circulation.t OK prove t/db_dependent/Circulation/IsItemIssued.t OK prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t OK prove t/db_dependent/Holds/HoldFulfillmentPolicy.t FAIL 1/10 Can't use an undefined value as an ARRAY reference at t/db_dependent/Holds/HoldFulfillmentPolicy.t line 41. prove t/db_dependent/Holds/HoldItemtypeLimit.t OK prove t/db_dependent/Holds/LocalHoldsPriority.t OK prove t/db_dependent/Holds/RevertWaitingStatus.t OK prove t/db_dependent/Members/Attributes.t OK prove t/db_dependent/Patron/Borrower_Debarments.t OK prove t/db_dependent/Patron/Borrower_Files.t OK prove t/db_dependent/Serials_2.t OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62164&action=edit Bug 18420: Fix HoldFulfillmentPolicy.t and Passwordrecovery.t We are going out of scope here, but these tests need a branch/item. Test plan: Run the adjusted tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Marc, could you signoff? I will pass QA after that. Further problems not strictly related to the bug theme, we should move to a new report. A few fixes are strictly out of scope already.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62090|0 |1 is obsolete| | --- Comment #22 from Marc Véron <veron@veron.ch> --- Created attachment 62174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62174&action=edit Bug 18420: Fix Budgets.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Budgets.t should return green, even if no categories.categorycode 'S' exists Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62091|0 |1 is obsolete| | --- Comment #23 from Marc Véron <veron@veron.ch> --- Created attachment 62175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62175&action=edit Bug 18420: Fix Passwordrecovery.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Passwordrecovery.t should return green, even if no categories.categorycode 'S' exists Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62092|0 |1 is obsolete| | --- Comment #24 from Marc Véron <veron@veron.ch> --- Created attachment 62176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62176&action=edit Bug 18420: Fix Members.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Members.t should return green, even if no categories.categorycode 'S' exists Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62093|0 |1 is obsolete| | --- Comment #25 from Marc Véron <veron@veron.ch> --- Created attachment 62177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62177&action=edit Bug 18420: Use TestBuilder to create a patron category in Suggestions.t No need to do it that way, let's use TestBuilder. Test plan: prove t/db_dependent/Suggestions.t should still return green Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62115|0 |1 is obsolete| | --- Comment #26 from Marc Véron <veron@veron.ch> --- Created attachment 62178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62178&action=edit Bug 18420: Do not use 'S' as patron category code in other tests Test plan: prove all these tests, they must all pass Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62118|0 |1 is obsolete| | --- Comment #27 from Marc Véron <veron@veron.ch> --- Created attachment 62179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62179&action=edit Bug 18420: Replace hardcoded EUR in OrderUsers.t Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62164|0 |1 is obsolete| | --- Comment #28 from Marc Véron <veron@veron.ch> --- Created attachment 62180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62180&action=edit Bug 18420: Fix HoldFulfillmentPolicy.t and Passwordrecovery.t We are going out of scope here, but these tests need a branch/item. Test plan: Run the adjusted tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62174|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62274&action=edit Bug 18420: Fix Budgets.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Budgets.t should return green, even if no categories.categorycode 'S' exists Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62175|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62275&action=edit Bug 18420: Fix Passwordrecovery.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Passwordrecovery.t should return green, even if no categories.categorycode 'S' exists Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62176|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62276&action=edit Bug 18420: Fix Members.t when no patron category 'S' exists No need to create Staff users here. Test plan: prove t/db_dependent/Members.t should return green, even if no categories.categorycode 'S' exists Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62177|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62277&action=edit Bug 18420: Use TestBuilder to create a patron category in Suggestions.t No need to do it that way, let's use TestBuilder. Test plan: prove t/db_dependent/Suggestions.t should still return green Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62178|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62278&action=edit Bug 18420: Do not use 'S' as patron category code in other tests Test plan: prove all these tests, they must all pass Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62179|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62279&action=edit Bug 18420: Replace hardcoded EUR in OrderUsers.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62180|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 62280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62280&action=edit Bug 18420: Fix HoldFulfillmentPolicy.t and Passwordrecovery.t We are going out of scope here, but these tests need a branch/item. Test plan: Run the adjusted tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA QA Contact|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I saw a failure on Circulation.t once (Subtest: CanBookBeIssued + AllowMultipleIssuesOnABiblio), but could not reproduce it. But it is not related to this bug anyhow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18445 [Bug 18445] Tests in t stumble over Auth's BEGIN block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18448 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18448 [Bug 18448] Fix a few db_dependent tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am having some problems with applying acd91afd0c623e75ea9f9d7fb3b57a39bdfb1890 Can you please check and rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still having problems, please rebase! Applying: Bug 18420: Do not use 'S' as patron category code in other tests Using index info to reconstruct a base tree... M t/db_dependent/Acquisition/OrderUsers.t M t/db_dependent/Circulation.t M t/db_dependent/Holds/HoldFulfillmentPolicy.t M t/db_dependent/Holds/HoldItemtypeLimit.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Holds/HoldItemtypeLimit.t Auto-merging t/db_dependent/Holds/HoldFulfillmentPolicy.t Auto-merging t/db_dependent/Circulation.t CONFLICT (content): Merge conflict in t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 2 months, no reply. Closing this. Please reopen with rebased patches if you think this should be included in 16.11.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18420 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62280|0 |1 is obsolete| | --- Comment #41 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 112053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112053&action=edit Bug 18420: Fix HoldFulfillmentPolicy.t and Passwordrecovery.t We are going out of scope here, but these tests need a branch/item. Test plan: Run the adjusted tests. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org