[Bug 17616] New: Select tag on elasticsearch mappings page is not closed properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17616 Bug ID: 17616 Summary: Select tag on elasticsearch mappings page is not closed properly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org See http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet... Line 250 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17616 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17616 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17616 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57460&action=edit Bug 17616: Select tag on elasticsearch mappings page is not closed properly Test plan 1) Have SearchEngine syspref set to Elastic 2) Look at source on admin/searchengine/elasticsearch/mappings.pl -> without patch you'll see select with attribute data-id="mapping_search_field_name" closing tag written badly as "/select>" -> with patch everything looks OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17616 --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 57472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57472&action=edit Bug 17616: (follow-up)Select tag on elasticsearch mappings page is not closed properly Also some close tag </selected> should be </select> Follow previous patch to test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17616 --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Good catch Héctor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57460|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 57682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57682&action=edit [SIGNED-OFF] Bug 17616: Select tag on elasticsearch mappings page is not closed properly Test plan 1) Have SearchEngine syspref set to Elastic 2) Look at source on admin/searchengine/elasticsearch/mappings.pl -> without patch you'll see select with attribute data-id="mapping_search_field_name" closing tag written badly as "/select>" -> with patch everything looks OK Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17616 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57472|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 57683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57683&action=edit [SIGNED-OFF] Bug 17616: (follow-up)Select tag on elasticsearch mappings page is not closed properly Also some close tag </selected> should be </select> Follow previous patch to test Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17616 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17616 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57682|0 |1 is obsolete| | Attachment #57683|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57690&action=edit Bug 17616: Select tag on elasticsearch mappings page is not closed properly Test plan 1) Have SearchEngine syspref set to Elastic 2) Look at source on admin/searchengine/elasticsearch/mappings.pl -> without patch you'll see select with attribute data-id="mapping_search_field_name" closing tag written badly as "/select>" -> with patch everything looks OK Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17616 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57691&action=edit Bug 17616: (follow-up)Select tag on elasticsearch mappings page is not closed properly Also some close tag </selected> should be </select> Follow previous patch to test Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17616 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14899 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 [Bug 14899] Mapping configuration page for Elastic search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17616 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Josef, Lari! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17616 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Some conflicts, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org