[Bug 37821] New: Embed geographic coordinates when indexing biblios linked to GEOGR_NAME authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37821 Bug ID: 37821 Summary: Embed geographic coordinates when indexing biblios linked to GEOGR_NAME authorities Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: tadeusz@sosnierz.com QA Contact: testopia@bugs.koha-community.org Items can be linked to GEOGR_NAME authorities, which in turn can have geographic coordinates stored in them. We have the functionality to search for items around geographic coordinates, but currently the indexer only indexes coordinates stored in 034 in the item itself, not in any authorities linked to it. Embeding the coordinates from the GEOGR_NAME authority should have a negligible impact on the size of the index, and should make geo-tagging of items a lot easier. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37821 --- Comment #1 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 170979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170979&action=edit Bug 37821: Embed geographic coordinates from GEOGR_NAME authority when indexing records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37821 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Test plan: ## Preparation 1. Set up koha-testing-docker with --es8 2. Go to "The beginnings of Rome" in staff view (http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=140) 3. Go to the linked authority record ("Rome -- History -- Kings, 753-510 B.C") by clicking the looking glass. Should end up at http://localhost:8081/cgi-bin/koha/authorities/detail.pl?authid=169 4. Click "edit record" 5. Add field 034 ("CODED CARTOGRAPHIC MATHEMATICAL DATA") 6. For subfieds `s` and `t` enter the coordinates for Rome: 41.89193 and 12.51133 7. Save the authority record ## Testing 8. In koha-shell, issue the elasticsearch query: ``` curl -X GET "es:9200/koha_kohadev_biblios/_search?pretty" -H 'Content-Type: application/json' -d' { "query": { "bool": { "must": { "match_all": {} }, "filter": { "geo_distance": { "distance": "100km", "geolocation": { "lat": 41.89, "lon": 12.51 } } } } } } ' ``` Note no results. 9. Apply the patch 10. Rebuild the index with `koha-elasticsearch --rebuild kohadev` 11. Re-run the elasticsearch query 12. Notice the expected book pop up -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37821 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tadeusz@sosnierz.com |ity.org | CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37821 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roman.dolny@jezuici.pl Status|Needs Signoff |Failed QA --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Works as described, but qa script unhappy: FAIL Koha/SearchEngine/Elasticsearch.pm FAIL pod coverage POD is missing for 'embed_geographic_name' FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/SearchEngine/Elasticsearch.pm` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37821 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170979|0 |1 is obsolete| | --- Comment #4 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 183156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183156&action=edit Bug 37821: Embed geographic coordinates from GEOGR_NAME authority when indexing records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37821 --- Comment #5 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 183157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183157&action=edit Bug 37821: POD and tidying -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37821 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37821 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183156|0 |1 is obsolete| | --- Comment #6 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 183218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183218&action=edit Bug 37821: Embed geographic coordinates from GEOGR_NAME authority when indexing records Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37821 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183157|0 |1 is obsolete| | --- Comment #7 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 183219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183219&action=edit Bug 37821: POD and tidying Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37821 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37821 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- no tidy patches, please rebase and squash -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37821 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183218|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37821 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183219|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37821 --- Comment #9 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 195317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195317&action=edit Bug 37821: Embed geographic coordinates from GEOGR_NAME authority when indexing records Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Bug 37821: POD and tidying Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37821 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org