[Bug 42296] New: Tidy all script tags - trivial ones
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 Bug ID: 42296 Summary: Tidy all script tags - trivial ones Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 42094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 [Bug 42094] Tidy all script tags (except value_builder) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197186&action=edit Bug 42296: Tidy all script tags - trivial occurrences In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch only adds 'data-tt-allowed="true"' when needed. The work to move the JS variable to a separate script tag has been done already on bug 41324. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197186|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 --- Comment #2 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201913&action=edit Bug 42296: Tidy all script tags - trivial occurrences In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch only adds 'data-tt-allowed="true"' when needed. The work to move the JS variable to a separate script tag has been done already on bug 41324. Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 --- Comment #3 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201914&action=edit Bug 42296: (follow-up) Split JS block in auth.tt Patch from commit ff3a409 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 --- Comment #4 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201915&action=edit Bug 42296: (follow-up) Remove unused base_url on barcode-print The JS variable base_url on barcode-print is never referenced. The remaining JS block did not contain TT interpolation, so data-tt-allowed can be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201913|0 |1 is obsolete| | Attachment #201914|0 |1 is obsolete| | Attachment #201915|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 --- Comment #5 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201916&action=edit Bug 42296: Tidy all script tags - trivial occurrences In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch only adds 'data-tt-allowed="true"' when needed. The work to move the JS variable to a separate script tag has been done already on bug 41324. Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201916|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 --- Comment #6 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201923&action=edit Bug 42296: Tidy all script tags - trivial occurrences In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch only adds 'data-tt-allowed="true"' when needed. The work to move the JS variable to a separate script tag has been done already on bug 41324. Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 --- Comment #7 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201924&action=edit Bug 42296: (follow-up) Split JS block in auth.tt Patch from commit ff3a409 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 --- Comment #8 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201925&action=edit Bug 42296: (follow-up) Remove unused base_url on barcode-print The JS variable base_url on barcode-print is never referenced. The remaining JS block did not contain TT interpolation, so data-tt-allowed can be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 --- Comment #9 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201926&action=edit Bug 42296: auto tidy for follow-ups Patch from commit 07c3cb7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201923|0 |1 is obsolete| | Attachment #201924|0 |1 is obsolete| | Attachment #201925|0 |1 is obsolete| | Attachment #201926|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 --- Comment #10 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 203590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203590&action=edit Bug 42296: Tidy all script tags - trivial occurrences In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch only adds 'data-tt-allowed="true"' when needed. The work to move the JS variable to a separate script tag has been done already on bug 41324. Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 --- Comment #11 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 203591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203591&action=edit Bug 42296: (follow-up) Split JS block in auth.tt Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 --- Comment #12 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 203592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203592&action=edit Bug 42296: (follow-up) Remove unused base_url on barcode-print The JS variable base_url on barcode-print is never referenced. The remaining JS block did not contain TT interpolation, so data-tt-allowed can be removed. Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 --- Comment #13 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 203593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203593&action=edit Bug 42296: auto tidy for follow-ups Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42296 --- Comment #14 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org