[Bug 24735] New: Remove QueryParser-related code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Bug ID: 24735 Summary: Remove QueryParser-related code Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org At the last development meeting we have voted to remove the QueryParser-related code https://wiki.koha-community.org/wiki/Development_IRC_meeting_19_February_202... Hea tells us that it has not been adopted, and the code/bug tracker that it is not really usable as it. As nobody is willing to work on it, we decided to remove it instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12742 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12742 [Bug 12742] Omnibus: QueryParser -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Bug 24735 depends on bug 12742, which changed state. Bug 12742 Summary: Omnibus: QueryParser https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12742 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99643&action=edit Bug 24735: Remove QueryParser-related code At the last development meeting we have voted to remove the QueryParser-related code https://wiki.koha-community.org/wiki/Development_IRC_meeting_19_February_202... Hea tells us that it has not been adopted, and the code/bug tracker that it is not really usable as it. As nobody is willing to work on it, we decided to remove it instead. Test plan: % prove t/db_dependent/Search.t must return green See commits from bug 9239 and confirm that the code is removed in this patch. Also play with the search on the UI and confirm that you do not see obvious regressions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99643|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99647&action=edit Bug 24735: Remove QueryParser-related code At the last development meeting we have voted to remove the QueryParser-related code https://wiki.koha-community.org/wiki/Development_IRC_meeting_19_February_202... Hea tells us that it has not been adopted, and the code/bug tracker that it is not really usable as it. As nobody is willing to work on it, we decided to remove it instead. Test plan: % prove t/db_dependent/Search.t must return green See commits from bug 9239 and confirm that the code is removed in this patch. Also play with the search on the UI and confirm that you do not see obvious regressions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- No regressions found, used a few different customer derived zebra configs and datasets for testing. It's great to see how much code this removes reducing our technical debt significantly. Single followup inbound for a minor qa script failure ;) Thanks Jonathan, Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- On second thoughts.. not sure about the QA script error.. perlcritic t/db_dependent/Search.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99648&action=edit Bug 24735: remove more code from tests That was use by QP tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99648|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99649&action=edit Bug 24735: remove more code from tests That was use by QP tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Excellent, you did exactly what I came to the conclusion of too.. Signed off on followup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Martin, I think we should still send the email to the mailingl ist as planned in the dev meeting before pushing this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99647|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99811&action=edit Bug 24735: Remove QueryParser-related code At the last development meeting we have voted to remove the QueryParser-related code https://wiki.koha-community.org/wiki/Development_IRC_meeting_19_February_202... Hea tells us that it has not been adopted, and the code/bug tracker that it is not really usable as it. As nobody is willing to work on it, we decided to remove it instead. Test plan: % prove t/db_dependent/Search.t must return green See commits from bug 9239 and confirm that the code is removed in this patch. Also play with the search on the UI and confirm that you do not see obvious regressions Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99812&action=edit Bug 24735: Remove more code from tests That was use by QP tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Large patch --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's always sad to remove code that has taken a lot of work and thought to get in, but at this point in time, it seems the right thing to do. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #11)
It's always sad to remove code that has taken a lot of work and thought to get in, but at this point in time, it seems the right thing to do.
I was thinking the same thing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99649|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Cleanup Koha and fight feature creep -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #15 from Joy Nelson <joy@bywatersolutions.com> --- does not apply to 19.11.x branch. please rebase if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25068 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- I think this bug may have broken master package builds (despite what dashboard.koha-community.org is saying)? I'm getting the following error when building master packages and this seems like the only reason why it would happen... make[1]: Leaving directory '/home/koha/build/koha-19.12.00-test+20200518020508.3dc1f8a8' dh_install -O--fail-missing cp: cannot stat 'debian/tmp/debian/tmp/etc/koha/searchengine': No such file or directory dh_install: cp -a debian/tmp/debian/tmp/etc/koha/searchengine debian/koha-common//etc/koha/ returned exit code 1 debian/rules:9: recipe for target 'binary' failed make: *** [binary] Error 2 dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 debuild: fatal error at line 1376: dpkg-buildpackage -rfakeroot -D -us -uc failed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #16)
I think this bug may have broken master package builds (despite what dashboard.koha-community.org is saying)?
Oh, it's already been reported as Bug 25068. Nevermind. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25068 [Bug 25068] koha-common build error caused by missing /etc/searchengine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28987 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28987 [Bug 28987] Record search by date broken in label management -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org