[Bug 20647] New: When ILL is enabled the hover effect on the ILL requests button is wrong.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Bug ID: 20647 Summary: When ILL is enabled the hover effect on the ILL requests button is wrong. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The Icon part of the button on the main staff client page does not highlight with the text for the ILL requests button the same was as it does for all other module buttons on that page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 75456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75456&action=edit Bug 20647: Correct hover effect for Ill module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75785&action=edit Bug 20647: (alternate) When ILL is enabled the hover effect on the ILL requests button is wrong This alternate patch adds a new icon to the sprite image which gives icons to the link on the staff client home page. It modifies the CSS positioning for all the links as the new image sprite is somewhat different. The SVG file from which the sprite image was generated is also updated, and the about page has been updated to give credit to the creator of the icon. Unrelated change: The cataloging link is moved to the second column. Although it's probably rare for all modules to be enabled and available, this puts the same number of links in each column. To test, apply the patch and clear your browser cache if necessary. With interlibrary loan enabled, view the staff client home page and confirm that all the module links look correct, including when you hover your mouse over them. Confirm that the about page lists the new icon under the "licenses" tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75786&action=edit Screenshot showing updated staff client home page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@ptfs-europe |oleonard@myacpl.org |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks much nicer than my fix 😀. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75456|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 75456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75456 Bug 20647: Correct hover effect for Ill module Obsoleting my patch.. Owens is much nicer.. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75785|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 76557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76557&action=edit Bug 20647: (alternate) When ILL is enabled the hover effect on the ILL requests button is wrong This alternate patch adds a new icon to the sprite image which gives icons to the link on the staff client home page. It modifies the CSS positioning for all the links as the new image sprite is somewhat different. The SVG file from which the sprite image was generated is also updated, and the about page has been updated to give credit to the creator of the icon. Unrelated change: The cataloging link is moved to the second column. Although it's probably rare for all modules to be enabled and available, this puts the same number of links in each column. To test, apply the patch and clear your browser cache if necessary. With interlibrary loan enabled, view the staff client home page and confirm that all the module links look correct, including when you hover your mouse over them. Confirm that the about page lists the new icon under the "licenses" tab. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Signing off, works as expected.. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Bug 20647 depends on bug 7317, which changed state. Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76557|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77190&action=edit Bug 20647: (alternate) When ILL is enabled the hover effect on the ILL requests button is wrong This alternate patch adds a new icon to the sprite image which gives icons to the link on the staff client home page. It modifies the CSS positioning for all the links as the new image sprite is somewhat different. The SVG file from which the sprite image was generated is also updated, and the about page has been updated to give credit to the creator of the icon. Unrelated change: The cataloging link is moved to the second column. Although it's probably rare for all modules to be enabled and available, this puts the same number of links in each column. To test, apply the patch and clear your browser cache if necessary. With interlibrary loan enabled, view the staff client home page and confirm that all the module links look correct, including when you hover your mouse over them. Confirm that the about page lists the new icon under the "licenses" tab. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I chose to treat this as a bugfix as it fixes incorrect behaviour. Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org